diff mbox

[mesa] add EGL_TEXTURE_EXTERNAL_WL to WL_bind_wayland_display spec

Message ID 1345156101-28827-1-git-send-email-rob.clark@linaro.org
State New
Headers show

Commit Message

Rob Clark Aug. 16, 2012, 10:28 p.m. UTC
From: Rob Clark <rob@ti.com>

Signed-off-by: Rob Clark <rob@ti.com>
---
 docs/WL_bind_wayland_display.spec |    5 +++++
 include/EGL/eglmesaext.h          |    1 +
 2 files changed, 6 insertions(+)

Comments

Pekka Paalanen June 9, 2014, 9:53 a.m. UTC | #1
On Thu, 16 Aug 2012 17:28:19 -0500
Rob Clark <rob.clark@linaro.org> wrote:

> From: Rob Clark <rob@ti.com>
> 
> Signed-off-by: Rob Clark <rob@ti.com>
> ---
>  docs/WL_bind_wayland_display.spec |    5 +++++
>  include/EGL/eglmesaext.h          |    1 +
>  2 files changed, 6 insertions(+)
> 
> diff --git a/docs/WL_bind_wayland_display.spec b/docs/WL_bind_wayland_display.spec
> index 02bd6ea..ce52e2d 100644
> --- a/docs/WL_bind_wayland_display.spec
> +++ b/docs/WL_bind_wayland_display.spec
> @@ -75,6 +75,7 @@ New Tokens
>          EGL_TEXTURE_Y_U_V_WL                    0x31D7
>          EGL_TEXTURE_Y_UV_WL                     0x31D8
>          EGL_TEXTURE_Y_XUXV_WL                   0x31D9
> +        EGL_TEXTURE_EXTERNAL_WL                 0x31DA
>  
>  
>  Additions to the EGL 1.4 Specification:
> @@ -143,6 +144,10 @@ Additions to the EGL 1.4 Specification:
>                  Two planes, samples Y from the first plane to r in
>                  the shader, U and V from the second plane to g and a.
>  
> +        EGL_TEXTURE_EXTERNAL_WL
> +                Treated as a single plane texture, but sampled with
> +                samplerExternalOES according to OES_EGL_image_external
> +
>      After querying the wl_buffer layout, create EGLImages for the
>      planes by calling eglCreateImageKHR with wl_buffer as
>      EGLClientBuffer, EGL_WAYLAND_BUFFER_WL as the target, NULL
> diff --git a/include/EGL/eglmesaext.h b/include/EGL/eglmesaext.h
> index d476d18..2b91897 100644
> --- a/include/EGL/eglmesaext.h
> +++ b/include/EGL/eglmesaext.h
> @@ -118,6 +118,7 @@ typedef EGLDisplay (EGLAPIENTRYP PFNEGLGETDRMDISPLAYMESA) (int fd);
>  #define EGL_TEXTURE_Y_U_V_WL            0x31D7
>  #define EGL_TEXTURE_Y_UV_WL             0x31D8
>  #define EGL_TEXTURE_Y_XUXV_WL           0x31D9
> +#define EGL_TEXTURE_EXTERNAL_WL         0x31DA
>  
>  struct wl_display;
>  struct wl_buffer;

Hi all,

it looks like this patch never made it into Mesa. Also the
implementation apparently didn't make it into Mesa, as git pick-axe
does not find any mention of EGL_TEXTURE_EXTERNAL_WL.

Still, the Weston patch was merged on Aug 31st, 2012.

Oops. :-)


Thanks,
pq
Rob Clark June 10, 2014, 2:46 p.m. UTC | #2
On Mon, Jun 9, 2014 at 5:53 AM, Pekka Paalanen <ppaalanen@gmail.com> wrote:
> On Thu, 16 Aug 2012 17:28:19 -0500
> Rob Clark <rob.clark@linaro.org> wrote:
>
>> From: Rob Clark <rob@ti.com>
>>
>> Signed-off-by: Rob Clark <rob@ti.com>
>> ---
>>  docs/WL_bind_wayland_display.spec |    5 +++++
>>  include/EGL/eglmesaext.h          |    1 +
>>  2 files changed, 6 insertions(+)
>>
>> diff --git a/docs/WL_bind_wayland_display.spec b/docs/WL_bind_wayland_display.spec
>> index 02bd6ea..ce52e2d 100644
>> --- a/docs/WL_bind_wayland_display.spec
>> +++ b/docs/WL_bind_wayland_display.spec
>> @@ -75,6 +75,7 @@ New Tokens
>>          EGL_TEXTURE_Y_U_V_WL                    0x31D7
>>          EGL_TEXTURE_Y_UV_WL                     0x31D8
>>          EGL_TEXTURE_Y_XUXV_WL                   0x31D9
>> +        EGL_TEXTURE_EXTERNAL_WL                 0x31DA
>>
>>
>>  Additions to the EGL 1.4 Specification:
>> @@ -143,6 +144,10 @@ Additions to the EGL 1.4 Specification:
>>                  Two planes, samples Y from the first plane to r in
>>                  the shader, U and V from the second plane to g and a.
>>
>> +        EGL_TEXTURE_EXTERNAL_WL
>> +                Treated as a single plane texture, but sampled with
>> +                samplerExternalOES according to OES_EGL_image_external
>> +
>>      After querying the wl_buffer layout, create EGLImages for the
>>      planes by calling eglCreateImageKHR with wl_buffer as
>>      EGLClientBuffer, EGL_WAYLAND_BUFFER_WL as the target, NULL
>> diff --git a/include/EGL/eglmesaext.h b/include/EGL/eglmesaext.h
>> index d476d18..2b91897 100644
>> --- a/include/EGL/eglmesaext.h
>> +++ b/include/EGL/eglmesaext.h
>> @@ -118,6 +118,7 @@ typedef EGLDisplay (EGLAPIENTRYP PFNEGLGETDRMDISPLAYMESA) (int fd);
>>  #define EGL_TEXTURE_Y_U_V_WL            0x31D7
>>  #define EGL_TEXTURE_Y_UV_WL             0x31D8
>>  #define EGL_TEXTURE_Y_XUXV_WL           0x31D9
>> +#define EGL_TEXTURE_EXTERNAL_WL         0x31DA
>>
>>  struct wl_display;
>>  struct wl_buffer;
>
> Hi all,
>
> it looks like this patch never made it into Mesa. Also the
> implementation apparently didn't make it into Mesa, as git pick-axe
> does not find any mention of EGL_TEXTURE_EXTERNAL_WL.
>
> Still, the Weston patch was merged on Aug 31st, 2012.
>
> Oops. :-)

heh, well I guess if weston is already using it, perhaps we should
think about merging the mesa patch ;-)

BR,
-R

>
> Thanks,
> pq
> _______________________________________________
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
diff mbox

Patch

diff --git a/docs/WL_bind_wayland_display.spec b/docs/WL_bind_wayland_display.spec
index 02bd6ea..ce52e2d 100644
--- a/docs/WL_bind_wayland_display.spec
+++ b/docs/WL_bind_wayland_display.spec
@@ -75,6 +75,7 @@  New Tokens
         EGL_TEXTURE_Y_U_V_WL                    0x31D7
         EGL_TEXTURE_Y_UV_WL                     0x31D8
         EGL_TEXTURE_Y_XUXV_WL                   0x31D9
+        EGL_TEXTURE_EXTERNAL_WL                 0x31DA
 
 
 Additions to the EGL 1.4 Specification:
@@ -143,6 +144,10 @@  Additions to the EGL 1.4 Specification:
                 Two planes, samples Y from the first plane to r in
                 the shader, U and V from the second plane to g and a.
 
+        EGL_TEXTURE_EXTERNAL_WL
+                Treated as a single plane texture, but sampled with
+                samplerExternalOES according to OES_EGL_image_external
+
     After querying the wl_buffer layout, create EGLImages for the
     planes by calling eglCreateImageKHR with wl_buffer as
     EGLClientBuffer, EGL_WAYLAND_BUFFER_WL as the target, NULL
diff --git a/include/EGL/eglmesaext.h b/include/EGL/eglmesaext.h
index d476d18..2b91897 100644
--- a/include/EGL/eglmesaext.h
+++ b/include/EGL/eglmesaext.h
@@ -118,6 +118,7 @@  typedef EGLDisplay (EGLAPIENTRYP PFNEGLGETDRMDISPLAYMESA) (int fd);
 #define EGL_TEXTURE_Y_U_V_WL            0x31D7
 #define EGL_TEXTURE_Y_UV_WL             0x31D8
 #define EGL_TEXTURE_Y_XUXV_WL           0x31D9
+#define EGL_TEXTURE_EXTERNAL_WL         0x31DA
 
 struct wl_display;
 struct wl_buffer;