| Message ID | CAGNsrLC=vpUNYR6VjAB=c9jPf3W2Pgdzw3LrYeSYAtadeano1w@mail.gmail.com |
|---|---|
| State | New |
| Headers | show |
On 2014-06-18 10:34, Fathi Boudra wrote: > patch attached. > > On 18 June 2014 09:25, Fathi Boudra <fathi.boudra@linaro.org> wrote: > > The issue is triggered with make 3.82 (as found on Fedora 20). > > If you built on Ubuntu with make 3.81, you won't observe the issue. Thanks, That worked on Fedora 20 Tested-by: Anders Roxell <anders.roxell@linaro.org> Cheers, Anders > > > > On 13 June 2014 19:11, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > >> CC right ODP list. > >> > >> > >> > >> On 06/13/2014 09:10 AM, Ciprian Barbu wrote: > >>> > >>> Hi, > >>> > >>> > >>> > >>> > >>> On Fri, Jun 13, 2014 at 9:06 AM, Maxim Uvarov <maxim.uvarov@linaro.org > >>> <mailto:maxim.uvarov@linaro.org>> wrote: > >>> > >>> > >>> > >>> > >>> On 13 June 2014 09:05, Fathi Boudra <fathi.boudra@linaro.org > >>> <mailto:fathi.boudra@linaro.org>> wrote: > >>> > >>> On 13 June 2014 19:03, Maxim Uvarov <maxim.uvarov@linaro.org > >>> <mailto:maxim.uvarov@linaro.org>> wrote: > >>> > Hi Koen, > >>> > > >>> > are you unable to build it on OE? Is OE doesn't works with > >>> wildcards? > >>> > >>> It's a Makefile, using make. Nothing specific to OE. > >>> Does it work in a native build? i.e. not in a cross build > >>> environment. > >>> > >>> for me it works for both native and arm. > >>> > >>> > >>> Works for me too, in Ubuntu 13.10 64-bit, native build. > >>> > >>> > >>> > >>> Maxim. > >>> > >>> > Thanks, > >>> > Maxim. > >>> > > >>> > > >>> > On 06/13/2014 03:28 AM, Koen Kooi wrote: > >>> >> > >>> >> > >>> >> Hi, > >>> >> > >>> >> > >>> >> ODP failed to build: > >>> >> > >>> >> > >>> >> | make: Entering an unknown directory > >>> >> > >>> >> | make: *** Makefile/: Not a directory. Stop. > >>> >> > >>> >> | make: Leaving an unknown directory > >>> >> > >>> >> > >>> >> This fixes it: > >>> >> > >>> >> > >>> >> [koen@thinkpad git]$ git diff > >>> >> > >>> >> diff --git a/test/Makefile b/test/Makefile > >>> >> > >>> >> index 500fd13..b46e280 100644 > >>> >> > >>> >> --- a/test/Makefile > >>> >> > >>> >> +++ b/test/Makefile > >>> >> > >>> >> @@ -3,7 +3,7 @@ > >>> >> > >>> >> # > >>> >> > >>> >> # SPDX-License-Identifier: BSD-3-Clause > >>> >> > >>> >> -TESTS=$(filter %, $(wildcard */)) > >>> >> > >>> >> +TESTS=api_test example generator l2fwd packet > >>> packet_netmap timer > >>> >> > >>> >> .PHONY: all clean install > >>> > >>> > >>> -- You received this message because you are subscribed to the > >>> Google > >>> Groups "[Frozen] LNG ODP Sub-team - lng-odp@linaro.org > >>> <mailto:lng-odp@linaro.org>" group. > >>> > >>> To unsubscribe from this group and stop receiving emails from it, > >>> send an email to lng-odp+unsubscribe@linaro.org > >>> <mailto:lng-odp+unsubscribe@linaro.org>. > >>> > >>> Visit this group at > >>> http://groups.google.com/a/linaro.org/group/lng-odp/. > >>> > >>> > > > > -- > Fathi Boudra > Builds and Baselines Manager | Release Manager > Linaro.org | Open source software for ARM SoCs > From 4f85cf81226c2cbcc6f73199ef7b719dd08b381e Mon Sep 17 00:00:00 2001 > From: Fathi Boudra <fathi.boudra@linaro.org> > Date: Wed, 18 Jun 2014 10:26:42 +0300 > Subject: [PATCH 1/1] Fix tests build failure with make 3.82 > > to generate the tests list: > 1. use wildcard to find list the files and directories > 2. filter out the files (only Makefile files) > 3. sort the list to always build in the same order > > Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org> > --- > test/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/test/Makefile b/test/Makefile > index 879d775..0b4d3ee 100644 > --- a/test/Makefile > +++ b/test/Makefile > @@ -3,7 +3,7 @@ > # > # SPDX-License-Identifier: BSD-3-Clause > > -TESTS=$(filter %, $(wildcard */)) > +TESTS := $(sort $(filter-out Makefile%, $(wildcard *))) > > .PHONY: all clean install > > -- > 2.0.0 >
On 06/18/2014 12:04 PM, Anders Roxell wrote: > On 2014-06-18 10:34, Fathi Boudra wrote: >> patch attached. >> >> On 18 June 2014 09:25, Fathi Boudra <fathi.boudra@linaro.org> wrote: >>> The issue is triggered with make 3.82 (as found on Fedora 20). >>> If you built on Ubuntu with make 3.81, you won't observe the issue. > Thanks, > > That worked on Fedora 20 > > Tested-by: Anders Roxell <anders.roxell@linaro.org> Anders if you have Fedora 20 can you check wildcards syntax there? It will be good not specify all directories. Maxim. > > Cheers, > Anders > >>> On 13 June 2014 19:11, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: >>>> CC right ODP list. >>>> >>>> >>>> >>>> On 06/13/2014 09:10 AM, Ciprian Barbu wrote: >>>>> Hi, >>>>> >>>>> >>>>> >>>>> >>>>> On Fri, Jun 13, 2014 at 9:06 AM, Maxim Uvarov <maxim.uvarov@linaro.org >>>>> <mailto:maxim.uvarov@linaro.org>> wrote: >>>>> >>>>> >>>>> >>>>> >>>>> On 13 June 2014 09:05, Fathi Boudra <fathi.boudra@linaro.org >>>>> <mailto:fathi.boudra@linaro.org>> wrote: >>>>> >>>>> On 13 June 2014 19:03, Maxim Uvarov <maxim.uvarov@linaro.org >>>>> <mailto:maxim.uvarov@linaro.org>> wrote: >>>>> > Hi Koen, >>>>> > >>>>> > are you unable to build it on OE? Is OE doesn't works with >>>>> wildcards? >>>>> >>>>> It's a Makefile, using make. Nothing specific to OE. >>>>> Does it work in a native build? i.e. not in a cross build >>>>> environment. >>>>> >>>>> for me it works for both native and arm. >>>>> >>>>> >>>>> Works for me too, in Ubuntu 13.10 64-bit, native build. >>>>> >>>>> >>>>> >>>>> Maxim. >>>>> >>>>> > Thanks, >>>>> > Maxim. >>>>> > >>>>> > >>>>> > On 06/13/2014 03:28 AM, Koen Kooi wrote: >>>>> >> >>>>> >> >>>>> >> Hi, >>>>> >> >>>>> >> >>>>> >> ODP failed to build: >>>>> >> >>>>> >> >>>>> >> | make: Entering an unknown directory >>>>> >> >>>>> >> | make: *** Makefile/: Not a directory. Stop. >>>>> >> >>>>> >> | make: Leaving an unknown directory >>>>> >> >>>>> >> >>>>> >> This fixes it: >>>>> >> >>>>> >> >>>>> >> [koen@thinkpad git]$ git diff >>>>> >> >>>>> >> diff --git a/test/Makefile b/test/Makefile >>>>> >> >>>>> >> index 500fd13..b46e280 100644 >>>>> >> >>>>> >> --- a/test/Makefile >>>>> >> >>>>> >> +++ b/test/Makefile >>>>> >> >>>>> >> @@ -3,7 +3,7 @@ >>>>> >> >>>>> >> # >>>>> >> >>>>> >> # SPDX-License-Identifier: BSD-3-Clause >>>>> >> >>>>> >> -TESTS=$(filter %, $(wildcard */)) >>>>> >> >>>>> >> +TESTS=api_test example generator l2fwd packet >>>>> packet_netmap timer >>>>> >> >>>>> >> .PHONY: all clean install >>>>> >>>>> >>>>> -- You received this message because you are subscribed to the >>>>> Google >>>>> Groups "[Frozen] LNG ODP Sub-team - lng-odp@linaro.org >>>>> <mailto:lng-odp@linaro.org>" group. >>>>> >>>>> To unsubscribe from this group and stop receiving emails from it, >>>>> send an email to lng-odp+unsubscribe@linaro.org >>>>> <mailto:lng-odp+unsubscribe@linaro.org>. >>>>> >>>>> Visit this group at >>>>> http://groups.google.com/a/linaro.org/group/lng-odp/. >>>>> >>>>> >> >> >> -- >> Fathi Boudra >> Builds and Baselines Manager | Release Manager >> Linaro.org | Open source software for ARM SoCs >> From 4f85cf81226c2cbcc6f73199ef7b719dd08b381e Mon Sep 17 00:00:00 2001 >> From: Fathi Boudra <fathi.boudra@linaro.org> >> Date: Wed, 18 Jun 2014 10:26:42 +0300 >> Subject: [PATCH 1/1] Fix tests build failure with make 3.82 >> >> to generate the tests list: >> 1. use wildcard to find list the files and directories >> 2. filter out the files (only Makefile files) >> 3. sort the list to always build in the same order >> >> Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org> >> --- >> test/Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/test/Makefile b/test/Makefile >> index 879d775..0b4d3ee 100644 >> --- a/test/Makefile >> +++ b/test/Makefile >> @@ -3,7 +3,7 @@ >> # >> # SPDX-License-Identifier: BSD-3-Clause >> >> -TESTS=$(filter %, $(wildcard */)) >> +TESTS := $(sort $(filter-out Makefile%, $(wildcard *))) >> >> .PHONY: all clean install >> >> -- >> 2.0.0 >> >
On 18 June 2014 11:19, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > On 06/18/2014 12:04 PM, Anders Roxell wrote: > >> On 2014-06-18 10:34, Fathi Boudra wrote: >> >>> patch attached. >>> >>> On 18 June 2014 09:25, Fathi Boudra <fathi.boudra@linaro.org> wrote: >>> >>>> The issue is triggered with make 3.82 (as found on Fedora 20). >>>> If you built on Ubuntu with make 3.81, you won't observe the issue. >>>> >>> Thanks, >> >> That worked on Fedora 20 >> >> Tested-by: Anders Roxell <anders.roxell@linaro.org> >> > Anders if you have Fedora 20 can you check wildcards syntax there? It will > be good not specify all directories. Confused, I thought I said Tested-by... and that it works on Fedora 20 in my previous email. I'm sorry if I wasn't clean on that! Cheers, > > > Maxim. > > > > >> Cheers, >> Anders >> >> On 13 June 2014 19:11, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: >>>> >>>>> CC right ODP list. >>>>> >>>>> >>>>> >>>>> On 06/13/2014 09:10 AM, Ciprian Barbu wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> On Fri, Jun 13, 2014 at 9:06 AM, Maxim Uvarov < >>>>>> maxim.uvarov@linaro.org >>>>>> <mailto:maxim.uvarov@linaro.org>> wrote: >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> On 13 June 2014 09:05, Fathi Boudra <fathi.boudra@linaro.org >>>>>> <mailto:fathi.boudra@linaro.org>> wrote: >>>>>> >>>>>> On 13 June 2014 19:03, Maxim Uvarov <maxim.uvarov@linaro.org >>>>>> <mailto:maxim.uvarov@linaro.org>> wrote: >>>>>> > Hi Koen, >>>>>> > >>>>>> > are you unable to build it on OE? Is OE doesn't works with >>>>>> wildcards? >>>>>> >>>>>> It's a Makefile, using make. Nothing specific to OE. >>>>>> Does it work in a native build? i.e. not in a cross build >>>>>> environment. >>>>>> >>>>>> for me it works for both native and arm. >>>>>> >>>>>> >>>>>> Works for me too, in Ubuntu 13.10 64-bit, native build. >>>>>> >>>>>> >>>>>> >>>>>> Maxim. >>>>>> >>>>>> > Thanks, >>>>>> > Maxim. >>>>>> > >>>>>> > >>>>>> > On 06/13/2014 03:28 AM, Koen Kooi wrote: >>>>>> >> >>>>>> >> >>>>>> >> Hi, >>>>>> >> >>>>>> >> >>>>>> >> ODP failed to build: >>>>>> >> >>>>>> >> >>>>>> >> | make: Entering an unknown directory >>>>>> >> >>>>>> >> | make: *** Makefile/: Not a directory. Stop. >>>>>> >> >>>>>> >> | make: Leaving an unknown directory >>>>>> >> >>>>>> >> >>>>>> >> This fixes it: >>>>>> >> >>>>>> >> >>>>>> >> [koen@thinkpad git]$ git diff >>>>>> >> >>>>>> >> diff --git a/test/Makefile b/test/Makefile >>>>>> >> >>>>>> >> index 500fd13..b46e280 100644 >>>>>> >> >>>>>> >> --- a/test/Makefile >>>>>> >> >>>>>> >> +++ b/test/Makefile >>>>>> >> >>>>>> >> @@ -3,7 +3,7 @@ >>>>>> >> >>>>>> >> # >>>>>> >> >>>>>> >> # SPDX-License-Identifier: BSD-3-Clause >>>>>> >> >>>>>> >> -TESTS=$(filter %, $(wildcard */)) >>>>>> >> >>>>>> >> +TESTS=api_test example generator l2fwd packet >>>>>> packet_netmap timer >>>>>> >> >>>>>> >> .PHONY: all clean install >>>>>> >>>>>> >>>>>> -- You received this message because you are subscribed to >>>>>> the >>>>>> Google >>>>>> Groups "[Frozen] LNG ODP Sub-team - lng-odp@linaro.org >>>>>> <mailto:lng-odp@linaro.org>" group. >>>>>> >>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>> send an email to lng-odp+unsubscribe@linaro.org >>>>>> <mailto:lng-odp+unsubscribe@linaro.org>. >>>>>> >>>>>> Visit this group at >>>>>> http://groups.google.com/a/linaro.org/group/lng-odp/. >>>>>> >>>>>> >>>>>> >>> >>> -- >>> Fathi Boudra >>> Builds and Baselines Manager | Release Manager >>> Linaro.org | Open source software for ARM SoCs >>> From 4f85cf81226c2cbcc6f73199ef7b719dd08b381e Mon Sep 17 00:00:00 2001 >>> From: Fathi Boudra <fathi.boudra@linaro.org> >>> Date: Wed, 18 Jun 2014 10:26:42 +0300 >>> Subject: [PATCH 1/1] Fix tests build failure with make 3.82 >>> >>> to generate the tests list: >>> 1. use wildcard to find list the files and directories >>> 2. filter out the files (only Makefile files) >>> 3. sort the list to always build in the same order >>> >>> Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org> >>> --- >>> test/Makefile | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/test/Makefile b/test/Makefile >>> index 879d775..0b4d3ee 100644 >>> --- a/test/Makefile >>> +++ b/test/Makefile >>> @@ -3,7 +3,7 @@ >>> # >>> # SPDX-License-Identifier: BSD-3-Clause >>> -TESTS=$(filter %, $(wildcard */)) >>> +TESTS := $(sort $(filter-out Makefile%, $(wildcard *))) >>> .PHONY: all clean install >>> >>> -- >>> 2.0.0 >>> >>> >> >
From 4f85cf81226c2cbcc6f73199ef7b719dd08b381e Mon Sep 17 00:00:00 2001 From: Fathi Boudra <fathi.boudra@linaro.org> Date: Wed, 18 Jun 2014 10:26:42 +0300 Subject: [PATCH 1/1] Fix tests build failure with make 3.82 to generate the tests list: 1. use wildcard to find list the files and directories 2. filter out the files (only Makefile files) 3. sort the list to always build in the same order Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org> --- test/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/Makefile b/test/Makefile index 879d775..0b4d3ee 100644 --- a/test/Makefile +++ b/test/Makefile @@ -3,7 +3,7 @@ # # SPDX-License-Identifier: BSD-3-Clause -TESTS=$(filter %, $(wildcard */)) +TESTS := $(sort $(filter-out Makefile%, $(wildcard *))) .PHONY: all clean install -- 2.0.0