| Message ID | 1402997133-13827-3-git-send-email-m.szyprowski@samsung.com |
|---|---|
| State | Superseded |
| Headers | show |
On Tue, Jun 17, 2014 at 10:25 AM, Marek Szyprowski <m.szyprowski@samsung.com> wrote: > This patch adds support for common hardware modules available on all > Exynos4412-based Odroid boards, which already have complete support in > mainline kernel. This includes secure firmware calls, watchdog, g2d and > fimc (mem2mem) multimedia accelerators. For the secure firmware, this is indeed required for U2/U3, otherwise the system crashes in weird ways during early boot. If this entry also makes sense for ODROID-X, I'm surprised it was not there already, does it boot without it? As for the watchdog, g2d and fimc, is there really any Exynos4412 configuration where such components are not available? Sorry if that is a silly question - just wondering why we wouldn't enable these in exynos4412.dtsi. Thanks Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 19.06.2014 14:21, Daniel Drake wrote: > On Tue, Jun 17, 2014 at 10:25 AM, Marek Szyprowski > <m.szyprowski@samsung.com> wrote: >> This patch adds support for common hardware modules available on all >> Exynos4412-based Odroid boards, which already have complete support in >> mainline kernel. This includes secure firmware calls, watchdog, g2d and >> fimc (mem2mem) multimedia accelerators. > > For the secure firmware, this is indeed required for U2/U3, otherwise > the system crashes in weird ways during early boot. If this entry also > makes sense for ODROID-X, I'm surprised it was not there already, does > it boot without it? It probably does, but certain things fail, such as secondary CPU bring-up. > > As for the watchdog, g2d and fimc, is there really any Exynos4412 > configuration where such components are not available? > Sorry if that is a silly question - just wondering why we wouldn't > enable these in exynos4412.dtsi. I believe they should all be enabled at highest possible level, as they don't have any board-specific hardware dependencies. Probably even in exynos4.dtsi for some of them (watchdog likely). Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/exynos4412-odroidx.dts b/arch/arm/boot/dts/exynos4412-odroidx.dts index 31db28a4bb33..fda9ac23dd55 100644 --- a/arch/arm/boot/dts/exynos4412-odroidx.dts +++ b/arch/arm/boot/dts/exynos4412-odroidx.dts @@ -22,6 +22,11 @@ reg = <0x40000000 0x40000000>; }; + firmware@0204F000 { + compatible = "samsung,secure-firmware"; + reg = <0x0204F000 0x1000>; + }; + leds { compatible = "gpio-leds"; led1 { @@ -68,10 +73,40 @@ regulator-boot-on; }; + watchdog@10060000 { + status = "okay"; + }; + rtc@10070000 { status = "okay"; }; + g2d@10800000 { + status = "okay"; + }; + + camera { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <>; + + fimc_0: fimc@11800000 { + status = "okay"; + }; + + fimc_1: fimc@11810000 { + status = "okay"; + }; + + fimc_2: fimc@11820000 { + status = "okay"; + }; + + fimc_3: fimc@11830000 { + status = "okay"; + }; + }; + sdhci@12530000 { bus-width = <4>; pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus4>;
This patch adds support for common hardware modules available on all Exynos4412-based Odroid boards, which already have complete support in mainline kernel. This includes secure firmware calls, watchdog, g2d and fimc (mem2mem) multimedia accelerators. Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> --- arch/arm/boot/dts/exynos4412-odroidx.dts | 35 ++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+)