| Message ID | 1343892310-21018-3-git-send-email-rajeshwari.s@samsung.com |
|---|---|
| State | New |
| Headers | show |
On Thursday 02 August 2012 03:25:05 Rajeshwari Shinde wrote: > SMDK EVT1 has a different Winbond part, added its part details > to the SPI flash table thanks, merged in my sf branch -mike
On Thursday 02 August 2012 11:19:16 Mike Frysinger wrote: > On Thursday 02 August 2012 03:25:05 Rajeshwari Shinde wrote: > > SMDK EVT1 has a different Winbond part, added its part details > > to the SPI flash table > > thanks, merged in my sf branch actually, you didn't rebase it. half the fields in there no longer exist in master which is why i asked you to rebase it in the first place. at any rate, i fixed it for you now. please at least *compile* test your patches in the future. -mike
Hi Rajeshwari. 2012/8/2 Rajeshwari Shinde <rajeshwari.s@samsung.com>: > SMDK EVT1 has a different Winbond part, added its part details > to the SPI flash table > > Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com> > Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com> > --- > Changes in V2: > - Corrected the commit message. > Changes in V3: > - None. > Changes in V4: > - Rebased on Mainline u-boot.git. > drivers/mtd/spi/winbond.c | 8 ++++++++ > 1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/drivers/mtd/spi/winbond.c b/drivers/mtd/spi/winbond.c > index 427b71f..ae4e48a 100644 > --- a/drivers/mtd/spi/winbond.c > +++ b/drivers/mtd/spi/winbond.c > @@ -62,6 +62,14 @@ static const struct winbond_spi_flash_params winbond_spi_flash_table[] = { > .nr_blocks = 256, > .name = "W25Q128", > }, > + { > + .id = 0x5014, > + .l2_page_size = 8, > + .pages_per_sector = 16, > + .sectors_per_block = 16, Above three fields is removed from commit a4ed3b653163367628d4ad173dfe3faf388da0ac, but in spi_flash_probe_winbond() flash->page_size = 4096; original codes are /* Assuming power-of-two page size initially. */ page_size = 1 << params->l2_page_size; ... flash->page_size = page_size; so i think flash->page_size is 256 or (1 << 8). When flash->page_size is 4096, is your spi_flash device working well? > + .nr_blocks = 128, > + .name = "W25Q80", > + }, > }; > > struct spi_flash *spi_flash_probe_winbond(struct spi_slave *spi, u8 *idcode) > -- > 1.7.4.4 > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot Thanks.
On Friday 17 August 2012 04:28:02 Joonyoung Shim wrote: > 2012/8/2 Rajeshwari Shinde <rajeshwari.s@samsung.com>: > > + { > > + .id = 0x5014, > > + .l2_page_size = 8, > > + .pages_per_sector = 16, > > + .sectors_per_block = 16, > > Above three fields is removed from commit > a4ed3b653163367628d4ad173dfe3faf388da0ac, that was mentioned & fixed already > but in spi_flash_probe_winbond() > > flash->page_size = 4096; this was also reported & fixed independently -mike
diff --git a/drivers/mtd/spi/winbond.c b/drivers/mtd/spi/winbond.c index 427b71f..ae4e48a 100644 --- a/drivers/mtd/spi/winbond.c +++ b/drivers/mtd/spi/winbond.c @@ -62,6 +62,14 @@ static const struct winbond_spi_flash_params winbond_spi_flash_table[] = { .nr_blocks = 256, .name = "W25Q128", }, + { + .id = 0x5014, + .l2_page_size = 8, + .pages_per_sector = 16, + .sectors_per_block = 16, + .nr_blocks = 128, + .name = "W25Q80", + }, }; struct spi_flash *spi_flash_probe_winbond(struct spi_slave *spi, u8 *idcode)