| Message ID | 1409152378-19706-9-git-send-email-ard.biesheuvel@linaro.org |
|---|---|
| State | New |
| Headers | show |
On 08/27/14 17:12, Ard Biesheuvel wrote: > This separates PlatformPei and PlatformPeiLib so the latter can be > overridden by a specific platform. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > --- > ArmPlatformPkg/PlatformPei/PlatformPeim.inf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ArmPlatformPkg/PlatformPei/PlatformPeim.inf b/ArmPlatformPkg/PlatformPei/PlatformPeim.inf > index 8ed44e7e395f..3822b093503b 100755 > --- a/ArmPlatformPkg/PlatformPei/PlatformPeim.inf > +++ b/ArmPlatformPkg/PlatformPei/PlatformPeim.inf > @@ -29,7 +29,6 @@ > > [Sources] > PlatformPeim.c > - PlatformPeiLib.c > > [Packages] > MdePkg/MdePkg.dec > @@ -43,6 +42,7 @@ > DebugLib > HobLib > ArmPlatformLib > + PlatformPeiLib > > [Ppis] > gEfiPeiMasterBootModePpiGuid # PPI ALWAYS_PRODUCED > I verified this patch as follows: I checked all library class to instance resolutions for PlatformPeiLib. Namely, with this patch, we delegate PlatformPeim's dependency on PlatformPeiLib.c from its own specific INF file to a library resolution. All the resolutions currently say PlatformPeiLib|ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf which in turn lists only one source file, PlatformPeiLib.c (in that directory). So no regressions here. Hence, Reviewed-by: Laszlo Ersek <lersek@redhat.com> --o-- While grepping, I did find what looks like a bug in an *independent* part of the source. In "ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.inf", it reads: BASE_NAME = ArmMemoryInitPeiLib [...] LIBRARY_CLASS = PlatformPeiLib Both of these seem to be wrong (although apparently they don't cause issues in practice): both Defines should say "MemoryInitPeiLib". Olivier, what's your take on this? I don't suggest to fix this up in this series, it's just confusing when someone greps for PlatformPeiLib. Thanks, Laszlo ------------------------------------------------------------------------------ Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/
diff --git a/ArmPlatformPkg/PlatformPei/PlatformPeim.inf b/ArmPlatformPkg/PlatformPei/PlatformPeim.inf index 8ed44e7e395f..3822b093503b 100755 --- a/ArmPlatformPkg/PlatformPei/PlatformPeim.inf +++ b/ArmPlatformPkg/PlatformPei/PlatformPeim.inf @@ -29,7 +29,6 @@ [Sources] PlatformPeim.c - PlatformPeiLib.c [Packages] MdePkg/MdePkg.dec @@ -43,6 +42,7 @@ DebugLib HobLib ArmPlatformLib + PlatformPeiLib [Ppis] gEfiPeiMasterBootModePpiGuid # PPI ALWAYS_PRODUCED
This separates PlatformPei and PlatformPeiLib so the latter can be overridden by a specific platform. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> --- ArmPlatformPkg/PlatformPei/PlatformPeim.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)