| Message ID | 1356689908-6866-2-git-send-email-sachin.kamat@linaro.org |
|---|---|
| State | Accepted |
| Headers | show |
Hi Sachin, Thank you for your patch. Best wishes,
Thanks Kamil. I assume you have 'Acked' this patch as well :) On 2 January 2013 23:59, Kamil Debski <k.debski@samsung.com> wrote: > Hi Sachin, > > Thank you for your patch. > > Best wishes, > -- > Kamil Debski > Linux Platform Group > Samsung Poland R&D Center > >> -----Original Message----- >> From: linux-media-owner@vger.kernel.org [mailto:linux-media- >> owner@vger.kernel.org] On Behalf Of Sachin Kamat >> Sent: Friday, December 28, 2012 11:18 AM >> To: linux-media@vger.kernel.org >> Cc: k.debski@samsung.com; s.nawrocki@samsung.com; >> sylvester.nawrocki@gmail.com; sachin.kamat@linaro.org; >> patches@linaro.org >> Subject: [PATCH 2/3] [media] s5p-mfc: Remove redundant 'break' >> >> The code returns before this statement. Hence not required. >> Silences the following smatch message: >> drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c:525 >> s5p_mfc_set_dec_frame_buffer_v5() info: ignoring unreachable code. >> >> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> >> --- >> drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c | 1 - >> 1 files changed, 0 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c >> b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c >> index bb99d3d..b0f277e 100644 >> --- a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c >> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c >> @@ -522,7 +522,6 @@ int s5p_mfc_set_dec_frame_buffer_v5(struct >> s5p_mfc_ctx *ctx) >> mfc_err("Unknown codec for decoding (%x)\n", >> ctx->codec_mode); >> return -EINVAL; >> - break; >> } >> frame_size = ctx->luma_size; >> frame_size_ch = ctx->chroma_size; >> -- >> 1.7.4.1 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-media" >> in the body of a message to majordomo@vger.kernel.org More majordomo >> info at http://vger.kernel.org/majordomo-info.html > >
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c index bb99d3d..b0f277e 100644 --- a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c @@ -522,7 +522,6 @@ int s5p_mfc_set_dec_frame_buffer_v5(struct s5p_mfc_ctx *ctx) mfc_err("Unknown codec for decoding (%x)\n", ctx->codec_mode); return -EINVAL; - break; } frame_size = ctx->luma_size; frame_size_ch = ctx->chroma_size;
The code returns before this statement. Hence not required. Silences the following smatch message: drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c:525 s5p_mfc_set_dec_frame_buffer_v5() info: ignoring unreachable code. Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> --- drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)