| Message ID | 1412111759-22198-1-git-send-email-gary.robertson@linaro.org |
|---|---|
| State | Accepted |
| Commit | 76bf459b324b5d5a765a0942cdfe97f5428825c2 |
| Headers | show |
LTP developers, Just wondered if this patch slipped through the cracks as I have heard no comments for almost a month. After floundering about for a long while trying to decipher the macros-within-macros mysteries of autoconf in an OpenEmbedded build environment I finally arrived at a proper solution for successfully building the mutex tests for priority inheritance and robust mutexes. This patch and its counterpart for robust mutex conditionals are the LTP part of that solution, and address build-time issues which are not confined to the OE build environment. Apologies for all the previous noise and thanks for your forbearance while I groped for understanding. Gary Robertson On Tue, Sep 30, 2014 at 4:15 PM, Gary S. Robertson < gary.robertson@linaro.org> wrote: > From: "Gary S. Robertson" <gary.robertson@linaro.org> > > testcases/realtime/lib/librttest.c and > testcases/realtime/stress/pi-tests/testpi-3.c > both referenced a non-existent autoconf configuration setting variable. > Replaced the invalid variable name with the variable actually created > by autoconf. > > Signed-off-by: Gary S. Robertson <gary.robertson@linaro.org> > --- > testcases/realtime/lib/librttest.c | 2 +- > testcases/realtime/stress/pi-tests/testpi-3.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/testcases/realtime/lib/librttest.c > b/testcases/realtime/lib/librttest.c > index c175148..3679058 100644 > --- a/testcases/realtime/lib/librttest.c > +++ b/testcases/realtime/lib/librttest.c > @@ -586,7 +586,7 @@ void *busy_work_us(int us) > > void init_pi_mutex(pthread_mutex_t * m) > { > -#if HAVE_DECL_PTHREAD_PRIO_INHERIT > +#if HAS_PRIORITY_INHERIT > pthread_mutexattr_t attr; > int ret; > int protocol; > diff --git a/testcases/realtime/stress/pi-tests/testpi-3.c > b/testcases/realtime/stress/pi-tests/testpi-3.c > index 30f38f6..e483945 100644 > --- a/testcases/realtime/stress/pi-tests/testpi-3.c > +++ b/testcases/realtime/stress/pi-tests/testpi-3.c > @@ -365,7 +365,7 @@ int main(int argc, char *argv[]) > > printf("Start %s\n", argv[0]); > > -#if HAVE_DECL_PTHREAD_PRIO_INHERIT > +#if HAS_PRIORITY_INHERIT > if (!nopi) { > pthread_mutexattr_t mutexattr; > int protocol; > -- > 1.7.9.5 > > ------------------------------------------------------------------------------ Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push notifications. Take corrective actions from your mobile device. http://p.sf.net/sfu/Zoho
----- Original Message ----- > From: "Gary S. Robertson" <gary.robertson@linaro.org> > To: ltp-list@lists.sourceforge.net > Cc: "mike holmes" <mike.holmes@linaro.org> > Sent: Tuesday, 30 September, 2014 11:15:59 PM > Subject: [LTP] [PATCH] Realtime tests: Fix bad priority inheritance conditionals > > From: "Gary S. Robertson" <gary.robertson@linaro.org> > > testcases/realtime/lib/librttest.c and > testcases/realtime/stress/pi-tests/testpi-3.c > both referenced a non-existent autoconf configuration setting variable. > Replaced the invalid variable name with the variable actually created > by autoconf. > > Signed-off-by: Gary S. Robertson <gary.robertson@linaro.org> Pushed. Thank you, Jan > --- > testcases/realtime/lib/librttest.c | 2 +- > testcases/realtime/stress/pi-tests/testpi-3.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/testcases/realtime/lib/librttest.c > b/testcases/realtime/lib/librttest.c > index c175148..3679058 100644 > --- a/testcases/realtime/lib/librttest.c > +++ b/testcases/realtime/lib/librttest.c > @@ -586,7 +586,7 @@ void *busy_work_us(int us) > > void init_pi_mutex(pthread_mutex_t * m) > { > -#if HAVE_DECL_PTHREAD_PRIO_INHERIT > +#if HAS_PRIORITY_INHERIT > pthread_mutexattr_t attr; > int ret; > int protocol; > diff --git a/testcases/realtime/stress/pi-tests/testpi-3.c > b/testcases/realtime/stress/pi-tests/testpi-3.c > index 30f38f6..e483945 100644 > --- a/testcases/realtime/stress/pi-tests/testpi-3.c > +++ b/testcases/realtime/stress/pi-tests/testpi-3.c > @@ -365,7 +365,7 @@ int main(int argc, char *argv[]) > > printf("Start %s\n", argv[0]); > > -#if HAVE_DECL_PTHREAD_PRIO_INHERIT > +#if HAS_PRIORITY_INHERIT > if (!nopi) { > pthread_mutexattr_t mutexattr; > int protocol; > -- > 1.7.9.5 > > > ------------------------------------------------------------------------------ > Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer > Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports > Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper > Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer > http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk > _______________________________________________ > Ltp-list mailing list > Ltp-list@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/ltp-list > ------------------------------------------------------------------------------
diff --git a/testcases/realtime/lib/librttest.c b/testcases/realtime/lib/librttest.c index c175148..3679058 100644 --- a/testcases/realtime/lib/librttest.c +++ b/testcases/realtime/lib/librttest.c @@ -586,7 +586,7 @@ void *busy_work_us(int us) void init_pi_mutex(pthread_mutex_t * m) { -#if HAVE_DECL_PTHREAD_PRIO_INHERIT +#if HAS_PRIORITY_INHERIT pthread_mutexattr_t attr; int ret; int protocol; diff --git a/testcases/realtime/stress/pi-tests/testpi-3.c b/testcases/realtime/stress/pi-tests/testpi-3.c index 30f38f6..e483945 100644 --- a/testcases/realtime/stress/pi-tests/testpi-3.c +++ b/testcases/realtime/stress/pi-tests/testpi-3.c @@ -365,7 +365,7 @@ int main(int argc, char *argv[]) printf("Start %s\n", argv[0]); -#if HAVE_DECL_PTHREAD_PRIO_INHERIT +#if HAS_PRIORITY_INHERIT if (!nopi) { pthread_mutexattr_t mutexattr; int protocol;