| Message ID | CAKohpo=3D9V9cMF2O-4jqZZ9knrUR9n+wehB_LK-rr25+Pte-g@mail.gmail.com |
|---|---|
| State | New |
| Headers | show |
On Mon, Sep 2, 2013 at 12:13 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote: > But in RT kernel we have few usages of "raw"... > viresh@blr-linut-001:$ ggrep raw include/linux/skbuff.h > include/linux/skbuff.h: raw_spinlock_t raw_lock; > include/linux/skbuff.h:static inline void > skb_queue_head_init_raw(struct sk_buff_head *list) > include/linux/skbuff.h: raw_spin_lock_init(&list->raw_lock); > > And this causes confusion to our script.. And so I am trying to > search for "*raw;" to make the search more accurate :) Thanks, that's what I was looking for. Would you mind submitting the patch formally then? (I don't think you need to escape the semicolon though.)
On 3 September 2013 22:53, Jesse Gross <jesse@nicira.com> wrote: > Thanks, that's what I was looking for. Would you mind submitting the > patch formally then? (I don't think you need to escape the semicolon > though.) Sorry was away on vacations.. Yeah, I will resubmit it then.. I kept semicolon as well to make it a bit more robust for changes in future... So, that something like: *raw_<***> doesn't get caught by my search pattern :) -- viresh
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 230dd43..c45ad12 100644 --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h @@ -69,8 +69,8 @@ [snip] @@ -236,18 +236,9 @@ struct sk_buff { int iif; /* 4 byte hole on 64 bit*/ - union { - unsigned char *raw; - } h; - - union { - unsigned char *raw; - } nh; - - union { - unsigned char *raw; - } mac; - + unsigned char *transport_header;
On 31 August 2013 05:45, Jesse Gross <jesse@nicira.com> wrote: > Out of curiosity, what is the actual symbol that we're finding in the RT kernel? Its not about RT kernel really.. Following patch did this: b0e380b [SK_BUFF]: unions of just one member don't get anything done, kill them + unsigned char *network_header; + unsigned char *mac_header; struct dst_entry *dst; struct sec_path *sp; -------x--------------------x---------------- This is why we have code in OVS repo which searches just for "raw" keyword and things used to work well... But in RT kernel we have few usages of "raw"... viresh@blr-linut-001:$ ggrep raw include/linux/skbuff.h include/linux/skbuff.h: raw_spinlock_t raw_lock; include/linux/skbuff.h:static inline void skb_queue_head_init_raw(struct sk_buff_head *list) include/linux/skbuff.h: raw_spin_lock_init(&list->raw_lock); And this causes confusion to our script.. And so I am trying to search for "*raw;" to make the search more accurate :)