diff mbox

thermal: use %d to print S32 parameters

Message ID 1452674036-14907-1-git-send-email-leo.yan@linaro.org
State Superseded
Headers show

Commit Message

Leo Yan Jan. 13, 2016, 8:33 a.m. UTC
Power allocator's parameters are S32 type, so use %d to print them.

Signed-off-by: Leo Yan <leo.yan@linaro.org>

---
 drivers/thermal/thermal_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Leo Yan Feb. 18, 2016, 9:42 a.m. UTC | #1
On Wed, Jan 13, 2016 at 09:22:16AM +0000, Javi Merino wrote:
> On Wed, Jan 13, 2016 at 04:33:56PM +0800, Leo Yan wrote:

> > Power allocator's parameters are S32 type, so use %d to print them.

> 

> Indeed.  The name of the macro is create_s32_tzp_attr(), it's

> explicitly saying that the parameter is signed!

> 

> > Signed-off-by: Leo Yan <leo.yan@linaro.org>

> 

> Acked-by: Javi Merino <javi.merino@arm.com>


Rui, Eduardo,

Could you help merge this patch as well?

Thanks,
Leo Yan

> 

> Cheers,

> Javi

> 

> > ---

> >  drivers/thermal/thermal_core.c | 2 +-

> >  1 file changed, 1 insertion(+), 1 deletion(-)

> > 

> > diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c

> > index d9e525c..1335df2 100644

> > --- a/drivers/thermal/thermal_core.c

> > +++ b/drivers/thermal/thermal_core.c

> > @@ -931,7 +931,7 @@ static DEVICE_ATTR(sustainable_power, S_IWUSR | S_IRUGO, sustainable_power_show,

> >  	struct thermal_zone_device *tz = to_thermal_zone(dev);		\

> >  									\

> >  	if (tz->tzp)							\

> > -		return sprintf(buf, "%u\n", tz->tzp->name);		\

> > +		return sprintf(buf, "%d\n", tz->tzp->name);		\

> >  	else								\

> >  		return -EIO;						\

> >  	}								\

> > -- 

> > 1.9.1

> > 

--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
index d9e525c..1335df2 100644
--- a/drivers/thermal/thermal_core.c
+++ b/drivers/thermal/thermal_core.c
@@ -931,7 +931,7 @@  static DEVICE_ATTR(sustainable_power, S_IWUSR | S_IRUGO, sustainable_power_show,
 	struct thermal_zone_device *tz = to_thermal_zone(dev);		\
 									\
 	if (tz->tzp)							\
-		return sprintf(buf, "%u\n", tz->tzp->name);		\
+		return sprintf(buf, "%d\n", tz->tzp->name);		\
 	else								\
 		return -EIO;						\
 	}								\