| Message ID | 1458590657-30777-1-git-send-email-anders.roxell@linaro.org |
|---|---|
| State | New |
| Headers | show |
On Mon, Mar 21, 2016 at 5:04 PM, Anders Roxell <anders.roxell@linaro.org> wrote: > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> > --- > pkg/debian/control | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/pkg/debian/control b/pkg/debian/control > index 1345770..e521929 100644 > --- a/pkg/debian/control > +++ b/pkg/debian/control > @@ -32,7 +32,7 @@ Package: libodp-linux-dev > Section: libdevel > Architecture: any > Multi-Arch: same > -Depends: libodp-linux (= ${binary:Version}), ${misc:Depends}, libssl-dev > +Depends: ${misc:Depends}, ${shlibs:Depends}, libssl-dev Why did you remove the dependency here? As a consequence, the -dev package will not depend on the library one: $ dpkg -I libodp-linux-dev_1.8.0.0.git30.g65740e7-1_amd64.deb new debian package, version 2.0. size 170778 bytes: control archive=3574 bytes. 413 bytes, 13 lines control 8068 bytes, 116 lines md5sums Package: libodp-linux-dev ... Depends: libssl-dev And I noticed the same is happening with libodphelper-linux-dev. Thanks,
On 22 March 2016 at 22:49, Ricardo Salveti <ricardo.salveti@linaro.org> wrote: > On Mon, Mar 21, 2016 at 5:04 PM, Anders Roxell <anders.roxell@linaro.org> wrote: >> Signed-off-by: Anders Roxell <anders.roxell@linaro.org> >> --- >> pkg/debian/control | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/pkg/debian/control b/pkg/debian/control >> index 1345770..e521929 100644 >> --- a/pkg/debian/control >> +++ b/pkg/debian/control >> @@ -32,7 +32,7 @@ Package: libodp-linux-dev >> Section: libdevel >> Architecture: any >> Multi-Arch: same >> -Depends: libodp-linux (= ${binary:Version}), ${misc:Depends}, libssl-dev >> +Depends: ${misc:Depends}, ${shlibs:Depends}, libssl-dev > > Why did you remove the dependency here? Good question. This should be dropped. > > As a consequence, the -dev package will not depend on the library one: > > $ dpkg -I libodp-linux-dev_1.8.0.0.git30.g65740e7-1_amd64.deb > new debian package, version 2.0. > size 170778 bytes: control archive=3574 bytes. > 413 bytes, 13 lines control > 8068 bytes, 116 lines md5sums > Package: libodp-linux-dev > ... > Depends: libssl-dev > > And I noticed the same is happening with libodphelper-linux-dev. I fixed the dependency for libodphelper-linux-dev in "[PATCHv2 04/11] rename libodphelper to libodphelper-linux" Cheers, Anders
On Wed, Mar 23, 2016 at 1:47 PM, Anders Roxell <anders.roxell@linaro.org> wrote: > On 22 March 2016 at 22:49, Ricardo Salveti <ricardo.salveti@linaro.org> wrote: >> On Mon, Mar 21, 2016 at 5:04 PM, Anders Roxell <anders.roxell@linaro.org> wrote: >>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org> >>> --- >>> pkg/debian/control | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/pkg/debian/control b/pkg/debian/control >>> index 1345770..e521929 100644 >>> --- a/pkg/debian/control >>> +++ b/pkg/debian/control >>> @@ -32,7 +32,7 @@ Package: libodp-linux-dev >>> Section: libdevel >>> Architecture: any >>> Multi-Arch: same >>> -Depends: libodp-linux (= ${binary:Version}), ${misc:Depends}, libssl-dev >>> +Depends: ${misc:Depends}, ${shlibs:Depends}, libssl-dev >> >> Why did you remove the dependency here? > > Good question. > This should be dropped. > >> >> As a consequence, the -dev package will not depend on the library one: >> >> $ dpkg -I libodp-linux-dev_1.8.0.0.git30.g65740e7-1_amd64.deb >> new debian package, version 2.0. >> size 170778 bytes: control archive=3574 bytes. >> 413 bytes, 13 lines control >> 8068 bytes, 116 lines md5sums >> Package: libodp-linux-dev >> ... >> Depends: libssl-dev >> >> And I noticed the same is happening with libodphelper-linux-dev. > > I fixed the dependency for libodphelper-linux-dev in > "[PATCHv2 04/11] rename libodphelper to libodphelper-linux" Thanks, so we should drop this patch from the series.
On 23 March 2016 at 20:53, Ricardo Salveti <ricardo.salveti@linaro.org> wrote: > On Wed, Mar 23, 2016 at 1:47 PM, Anders Roxell <anders.roxell@linaro.org> wrote: >> On 22 March 2016 at 22:49, Ricardo Salveti <ricardo.salveti@linaro.org> wrote: >>> On Mon, Mar 21, 2016 at 5:04 PM, Anders Roxell <anders.roxell@linaro.org> wrote: >>>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org> >>>> --- >>>> pkg/debian/control | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/pkg/debian/control b/pkg/debian/control >>>> index 1345770..e521929 100644 >>>> --- a/pkg/debian/control >>>> +++ b/pkg/debian/control >>>> @@ -32,7 +32,7 @@ Package: libodp-linux-dev >>>> Section: libdevel >>>> Architecture: any >>>> Multi-Arch: same >>>> -Depends: libodp-linux (= ${binary:Version}), ${misc:Depends}, libssl-dev >>>> +Depends: ${misc:Depends}, ${shlibs:Depends}, libssl-dev >>> >>> Why did you remove the dependency here? >> >> Good question. >> This should be dropped. >> >>> >>> As a consequence, the -dev package will not depend on the library one: >>> >>> $ dpkg -I libodp-linux-dev_1.8.0.0.git30.g65740e7-1_amd64.deb >>> new debian package, version 2.0. >>> size 170778 bytes: control archive=3574 bytes. >>> 413 bytes, 13 lines control >>> 8068 bytes, 116 lines md5sums >>> Package: libodp-linux-dev >>> ... >>> Depends: libssl-dev >>> >>> And I noticed the same is happening with libodphelper-linux-dev. >> >> I fixed the dependency for libodphelper-linux-dev in >> "[PATCHv2 04/11] rename libodphelper to libodphelper-linux" > > Thanks, so we should drop this patch from the series. Yes. Cheers, Anders > > -- > Ricardo Salveti
diff --git a/pkg/debian/control b/pkg/debian/control index 1345770..e521929 100644 --- a/pkg/debian/control +++ b/pkg/debian/control @@ -32,7 +32,7 @@ Package: libodp-linux-dev Section: libdevel Architecture: any Multi-Arch: same -Depends: libodp-linux (= ${binary:Version}), ${misc:Depends}, libssl-dev +Depends: ${misc:Depends}, ${shlibs:Depends}, libssl-dev Description: Development files for OpenDataPlane These are the source file for the OpenDataPlane reference implementation.
Signed-off-by: Anders Roxell <anders.roxell@linaro.org> --- pkg/debian/control | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)