| Message ID | 1467115556-8187-1-git-send-email-bala.manoharan@linaro.org |
|---|---|
| State | New |
| Headers | show |
Hi, This series is split into three patch set for ease of review and needs to be merged into single patch set before upstream. Regards, Bala On 28 June 2016 at 17:35, Balasubramanian Manoharan <bala.manoharan@linaro.org> wrote: > Replaces pktio interface as input to TM system instead of > odp_pktout_queue_t.This creates an 1 to 1 mapping between a TM system > and pktio interface. > > Signed-off-by: Balasubramanian Manoharan <bala.manoharan@linaro.org> > --- > v2: Incorporates review comments from Petri > include/odp/api/spec/traffic_mngr.h | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/include/odp/api/spec/traffic_mngr.h b/include/odp/api/spec/traffic_mngr.h > index 83b89e7..c9e6f8f 100644 > --- a/include/odp/api/spec/traffic_mngr.h > +++ b/include/odp/api/spec/traffic_mngr.h > @@ -270,6 +270,12 @@ typedef struct { > * have their fan_in only from tm_queues. */ > uint8_t max_levels; > > + /** egress_fcn_supported indicates whether the tm system supports > + * egress function. It is an optional feature used to receive the > + * packet from the tm system and its performance might be limited. > + */ > + odp_bool_t egress_fcn_supported; > + > /** tm_queue_shaper_supported indicates that the tm_queues support > * proper TM shaping. Note that TM Shaping is NOT the same thing as > * Ingress Metering/Policing as specified by RFC 2697 (A Single Rate > @@ -467,7 +473,7 @@ typedef struct { > odp_tm_egress_kind_t egress_kind; /**< Union discriminator */ > > union { > - odp_pktout_queue_t pktout; > + odp_pktio_t pktio; > odp_tm_egress_fcn_t egress_fcn; > }; > } odp_tm_egress_t; > -- > 1.9.1 >
Petri, your review for api change is needed. Maxim. On 06/28/16 15:05, Balasubramanian Manoharan wrote: > Replaces pktio interface as input to TM system instead of > odp_pktout_queue_t.This creates an 1 to 1 mapping between a TM system > and pktio interface. > > Signed-off-by: Balasubramanian Manoharan <bala.manoharan@linaro.org> > --- > v2: Incorporates review comments from Petri > include/odp/api/spec/traffic_mngr.h | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/include/odp/api/spec/traffic_mngr.h b/include/odp/api/spec/traffic_mngr.h > index 83b89e7..c9e6f8f 100644 > --- a/include/odp/api/spec/traffic_mngr.h > +++ b/include/odp/api/spec/traffic_mngr.h > @@ -270,6 +270,12 @@ typedef struct { > * have their fan_in only from tm_queues. */ > uint8_t max_levels; > > + /** egress_fcn_supported indicates whether the tm system supports > + * egress function. It is an optional feature used to receive the > + * packet from the tm system and its performance might be limited. > + */ > + odp_bool_t egress_fcn_supported; > + > /** tm_queue_shaper_supported indicates that the tm_queues support > * proper TM shaping. Note that TM Shaping is NOT the same thing as > * Ingress Metering/Policing as specified by RFC 2697 (A Single Rate > @@ -467,7 +473,7 @@ typedef struct { > odp_tm_egress_kind_t egress_kind; /**< Union discriminator */ > > union { > - odp_pktout_queue_t pktout; > + odp_pktio_t pktio; > odp_tm_egress_fcn_t egress_fcn; > }; > } odp_tm_egress_t;
merged as one patch. Maxim. On 06/30/16 10:09, Savolainen, Petri (Nokia - FI/Espoo) wrote: > This patch: > Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com> > > > Remind that series need to be squashed into a single commit since the type change under will break the build otherwise. > > >> -----Original Message----- >> From: lng-odp [mailto:lng-odp-bounces@lists.linaro.org] On Behalf Of >> Balasubramanian Manoharan >> Sent: Tuesday, June 28, 2016 3:06 PM >> To: lng-odp@lists.linaro.org >> Subject: [lng-odp] [PATCH/API-NEXTv2 1/3] api: traffic_mngr: Add pktio >> interface to odp_tm_egress_t struct >> >> Replaces pktio interface as input to TM system instead of >> odp_pktout_queue_t.This creates an 1 to 1 mapping between a TM system >> and pktio interface. >> >> Signed-off-by: Balasubramanian Manoharan <bala.manoharan@linaro.org> >> --- >> v2: Incorporates review comments from Petri >> include/odp/api/spec/traffic_mngr.h | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/include/odp/api/spec/traffic_mngr.h >> b/include/odp/api/spec/traffic_mngr.h >> index 83b89e7..c9e6f8f 100644 >> --- a/include/odp/api/spec/traffic_mngr.h >> +++ b/include/odp/api/spec/traffic_mngr.h >> @@ -270,6 +270,12 @@ typedef struct { >> * have their fan_in only from tm_queues. */ >> uint8_t max_levels; >> >> + /** egress_fcn_supported indicates whether the tm system supports >> + * egress function. It is an optional feature used to receive the >> + * packet from the tm system and its performance might be limited. >> + */ >> + odp_bool_t egress_fcn_supported; >> + >> /** tm_queue_shaper_supported indicates that the tm_queues support >> * proper TM shaping. Note that TM Shaping is NOT the same thing as >> * Ingress Metering/Policing as specified by RFC 2697 (A Single Rate >> @@ -467,7 +473,7 @@ typedef struct { >> odp_tm_egress_kind_t egress_kind; /**< Union discriminator */ >> >> union { >> - odp_pktout_queue_t pktout; >> + odp_pktio_t pktio; >> odp_tm_egress_fcn_t egress_fcn; >> }; >> } odp_tm_egress_t; >> -- >> 1.9.1 >> >> _______________________________________________ >> lng-odp mailing list >> lng-odp@lists.linaro.org >> https://lists.linaro.org/mailman/listinfo/lng-odp > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp
diff --git a/include/odp/api/spec/traffic_mngr.h b/include/odp/api/spec/traffic_mngr.h index 83b89e7..c9e6f8f 100644 --- a/include/odp/api/spec/traffic_mngr.h +++ b/include/odp/api/spec/traffic_mngr.h @@ -270,6 +270,12 @@ typedef struct { * have their fan_in only from tm_queues. */ uint8_t max_levels; + /** egress_fcn_supported indicates whether the tm system supports + * egress function. It is an optional feature used to receive the + * packet from the tm system and its performance might be limited. + */ + odp_bool_t egress_fcn_supported; + /** tm_queue_shaper_supported indicates that the tm_queues support * proper TM shaping. Note that TM Shaping is NOT the same thing as * Ingress Metering/Policing as specified by RFC 2697 (A Single Rate @@ -467,7 +473,7 @@ typedef struct { odp_tm_egress_kind_t egress_kind; /**< Union discriminator */ union { - odp_pktout_queue_t pktout; + odp_pktio_t pktio; odp_tm_egress_fcn_t egress_fcn; }; } odp_tm_egress_t;
Replaces pktio interface as input to TM system instead of odp_pktout_queue_t.This creates an 1 to 1 mapping between a TM system and pktio interface. Signed-off-by: Balasubramanian Manoharan <bala.manoharan@linaro.org> --- v2: Incorporates review comments from Petri include/odp/api/spec/traffic_mngr.h | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)