| Message ID | 1476324020-57155-10-git-send-email-heyi.guo@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
On Thu, Oct 13, 2016 at 10:00:19AM +0800, Heyi Guo wrote: > The dependency should be added to FdtUpdateLib, but it could not be > added to UpdateFdtDxe when FdtUpdateLib becomes binary. > > So this is a WA and can be removed after FdtUpdateLib open source. Why is it not open source? In fact, why do we even have Fdt part of the default build for d05? Can it be left out for now? Regards, Leif > Change-Id: If91a831110858d364857d9f0a901284ac868bfa5 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Heyi Guo <guoheyi@huawei.com> > --- > Chips/Hisilicon/Drivers/UpdateFdtDxe/UpdateFdtDxe.inf | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Chips/Hisilicon/Drivers/UpdateFdtDxe/UpdateFdtDxe.inf b/Chips/Hisilicon/Drivers/UpdateFdtDxe/UpdateFdtDxe.inf > index a0f0a9d..ccdcae7 100644 > --- a/Chips/Hisilicon/Drivers/UpdateFdtDxe/UpdateFdtDxe.inf > +++ b/Chips/Hisilicon/Drivers/UpdateFdtDxe/UpdateFdtDxe.inf > @@ -29,6 +29,7 @@ > [Packages] > ArmPlatformPkg/ArmPlatformPkg.dec > MdePkg/MdePkg.dec > + MdeModulePkg/MdeModulePkg.dec > ArmPkg/ArmPkg.dec > OpenPlatformPkg/Chips/Hisilicon/HisiPkg.dec > EmbeddedPkg/EmbeddedPkg.dec > @@ -58,5 +59,4 @@ > > > [Depex] > -TRUE > - > + gEfiGenericMemTestProtocolGuid > -- > 1.9.1 >
在 10/13/2016 10:22 PM, Leif Lindholm 写道: > On Thu, Oct 13, 2016 at 10:00:19AM +0800, Heyi Guo wrote: >> The dependency should be added to FdtUpdateLib, but it could not be >> added to UpdateFdtDxe when FdtUpdateLib becomes binary. >> >> So this is a WA and can be removed after FdtUpdateLib open source. > Why is it not open source? > > In fact, why do we even have Fdt part of the default build for d05? > Can it be left out for now? I remember some ARM Linux ACPI document recommends ARM Linux drivers both support device tree and ACPI, and Hisilicon drivers also provide device tree support along with ACPI. If we remove device tree support from UEFI, Linux drivers will have no platform to test the device tree mode. So can we just add a flag to enable device tree support, just as D02 and D03? Thanks. Heyi > > Regards, > > Leif > >> Change-Id: If91a831110858d364857d9f0a901284ac868bfa5 >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Heyi Guo <guoheyi@huawei.com> >> --- >> Chips/Hisilicon/Drivers/UpdateFdtDxe/UpdateFdtDxe.inf | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/Chips/Hisilicon/Drivers/UpdateFdtDxe/UpdateFdtDxe.inf b/Chips/Hisilicon/Drivers/UpdateFdtDxe/UpdateFdtDxe.inf >> index a0f0a9d..ccdcae7 100644 >> --- a/Chips/Hisilicon/Drivers/UpdateFdtDxe/UpdateFdtDxe.inf >> +++ b/Chips/Hisilicon/Drivers/UpdateFdtDxe/UpdateFdtDxe.inf >> @@ -29,6 +29,7 @@ >> [Packages] >> ArmPlatformPkg/ArmPlatformPkg.dec >> MdePkg/MdePkg.dec >> + MdeModulePkg/MdeModulePkg.dec >> ArmPkg/ArmPkg.dec >> OpenPlatformPkg/Chips/Hisilicon/HisiPkg.dec >> EmbeddedPkg/EmbeddedPkg.dec >> @@ -58,5 +59,4 @@ >> >> >> [Depex] >> -TRUE >> - >> + gEfiGenericMemTestProtocolGuid >> -- >> 1.9.1 >>
On Fri, Oct 14, 2016 at 11:22:48AM +0800, Heyi Guo wrote: > > > 在 10/13/2016 10:22 PM, Leif Lindholm 写道: > >On Thu, Oct 13, 2016 at 10:00:19AM +0800, Heyi Guo wrote: > >>The dependency should be added to FdtUpdateLib, but it could not be > >>added to UpdateFdtDxe when FdtUpdateLib becomes binary. > >> > >>So this is a WA and can be removed after FdtUpdateLib open source. > >Why is it not open source? > > > >In fact, why do we even have Fdt part of the default build for d05? > >Can it be left out for now? > I remember some ARM Linux ACPI document recommends ARM Linux drivers both > support device tree and ACPI, and Hisilicon drivers also provide device tree > support along with ACPI. If we remove device tree support from UEFI, Linux > drivers will have no platform to test the device tree mode. > > So can we just add a flag to enable device tree support, just as D02 and > D03? Yes, that works for me. Regards, Leif > Thanks. > > Heyi > > > > >Regards, > > > >Leif > > > >>Change-Id: If91a831110858d364857d9f0a901284ac868bfa5 > >>Contributed-under: TianoCore Contribution Agreement 1.0 > >>Signed-off-by: Heyi Guo <guoheyi@huawei.com> > >>--- > >> Chips/Hisilicon/Drivers/UpdateFdtDxe/UpdateFdtDxe.inf | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >>diff --git a/Chips/Hisilicon/Drivers/UpdateFdtDxe/UpdateFdtDxe.inf b/Chips/Hisilicon/Drivers/UpdateFdtDxe/UpdateFdtDxe.inf > >>index a0f0a9d..ccdcae7 100644 > >>--- a/Chips/Hisilicon/Drivers/UpdateFdtDxe/UpdateFdtDxe.inf > >>+++ b/Chips/Hisilicon/Drivers/UpdateFdtDxe/UpdateFdtDxe.inf > >>@@ -29,6 +29,7 @@ > >> [Packages] > >> ArmPlatformPkg/ArmPlatformPkg.dec > >> MdePkg/MdePkg.dec > >>+ MdeModulePkg/MdeModulePkg.dec > >> ArmPkg/ArmPkg.dec > >> OpenPlatformPkg/Chips/Hisilicon/HisiPkg.dec > >> EmbeddedPkg/EmbeddedPkg.dec > >>@@ -58,5 +59,4 @@ > >> [Depex] > >>-TRUE > >>- > >>+ gEfiGenericMemTestProtocolGuid > >>-- > >>1.9.1 > >> >
diff --git a/Chips/Hisilicon/Drivers/UpdateFdtDxe/UpdateFdtDxe.inf b/Chips/Hisilicon/Drivers/UpdateFdtDxe/UpdateFdtDxe.inf index a0f0a9d..ccdcae7 100644 --- a/Chips/Hisilicon/Drivers/UpdateFdtDxe/UpdateFdtDxe.inf +++ b/Chips/Hisilicon/Drivers/UpdateFdtDxe/UpdateFdtDxe.inf @@ -29,6 +29,7 @@ [Packages] ArmPlatformPkg/ArmPlatformPkg.dec MdePkg/MdePkg.dec + MdeModulePkg/MdeModulePkg.dec ArmPkg/ArmPkg.dec OpenPlatformPkg/Chips/Hisilicon/HisiPkg.dec EmbeddedPkg/EmbeddedPkg.dec @@ -58,5 +59,4 @@ [Depex] -TRUE - + gEfiGenericMemTestProtocolGuid
The dependency should be added to FdtUpdateLib, but it could not be added to UpdateFdtDxe when FdtUpdateLib becomes binary. So this is a WA and can be removed after FdtUpdateLib open source. Change-Id: If91a831110858d364857d9f0a901284ac868bfa5 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo <guoheyi@huawei.com> --- Chips/Hisilicon/Drivers/UpdateFdtDxe/UpdateFdtDxe.inf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)