Message ID | 1478570147-30873-1-git-send-email-yamada.masahiro@socionext.com |
---|---|
State | Accepted |
Commit | 847e0700121bdd7109f21a74992f0bdc3712b872 |
Headers | show |
On Tue, Nov 08, 2016 at 10:55:47AM +0900, Masahiro Yamada wrote: > The dependency between the object and the source is handled by > scripts/Makefile.host, so only "hostprogs-y += gen_facilities" > is fine. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > arch/s390/tools/Makefile | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/s390/tools/Makefile b/arch/s390/tools/Makefile > index 6d9814c..4b5e1e4 100644 > --- a/arch/s390/tools/Makefile > +++ b/arch/s390/tools/Makefile > @@ -9,7 +9,5 @@ define filechk_facilities.h > $(obj)/gen_facilities > endef > > -$(obj)/gen_facilities.o: $(srctree)/arch/s390/tools/gen_facilities.c > - > include/generated/facilities.h: $(obj)/gen_facilities FORCE > $(call filechk,facilities.h) Acked-by: Heiko Carstens <heiko.carstens@de.ibm.com> Martin, can you pick this one up too, please?
On Tue, 8 Nov 2016 08:45:28 +0100 Heiko Carstens <heiko.carstens@de.ibm.com> wrote: > On Tue, Nov 08, 2016 at 10:55:47AM +0900, Masahiro Yamada wrote: > > The dependency between the object and the source is handled by > > scripts/Makefile.host, so only "hostprogs-y += gen_facilities" > > is fine. > > > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > --- > > > > arch/s390/tools/Makefile | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/arch/s390/tools/Makefile b/arch/s390/tools/Makefile > > index 6d9814c..4b5e1e4 100644 > > --- a/arch/s390/tools/Makefile > > +++ b/arch/s390/tools/Makefile > > @@ -9,7 +9,5 @@ define filechk_facilities.h > > $(obj)/gen_facilities > > endef > > > > -$(obj)/gen_facilities.o: $(srctree)/arch/s390/tools/gen_facilities.c > > - > > include/generated/facilities.h: $(obj)/gen_facilities FORCE > > $(call filechk,facilities.h) > > Acked-by: Heiko Carstens <heiko.carstens@de.ibm.com> > > Martin, can you pick this one up too, please? Done. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.
diff --git a/arch/s390/tools/Makefile b/arch/s390/tools/Makefile index 6d9814c..4b5e1e4 100644 --- a/arch/s390/tools/Makefile +++ b/arch/s390/tools/Makefile @@ -9,7 +9,5 @@ define filechk_facilities.h $(obj)/gen_facilities endef -$(obj)/gen_facilities.o: $(srctree)/arch/s390/tools/gen_facilities.c - include/generated/facilities.h: $(obj)/gen_facilities FORCE $(call filechk,facilities.h)
The dependency between the object and the source is handled by scripts/Makefile.host, so only "hostprogs-y += gen_facilities" is fine. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- arch/s390/tools/Makefile | 2 -- 1 file changed, 2 deletions(-) -- 1.9.1