| Message ID | 1481129438-28306-1-git-send-email-ross.burton@intel.com |
|---|---|
| State | Accepted |
| Commit | ba330051570a4c991885ee726cb187e0c911bd4f |
| Headers | show |
On 07/12/16 10:50, Ross Burton wrote: > Add a new variable CVE_PRODUCT for the product name to look up in the NVD > database. Default this to BPN, but allow recipes such as tiff (which is libtiff > in NVD) to override it. > > Signed-off-by: Ross Burton <ross.burton@intel.com> > I like the idea to be able to override the name that cve-check-tool checks. The only drawback would be the burden of adding these to needed recipes. This is still better to have to guess the correct name, or to check PROVIDES or RPROVIDES, there are just too much corner cases. So this solution has my approval. -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
diff --git a/meta/classes/cve-check.bbclass b/meta/classes/cve-check.bbclass index b0febfb..75b8fa9 100644 --- a/meta/classes/cve-check.bbclass +++ b/meta/classes/cve-check.bbclass @@ -20,6 +20,10 @@ # the only method to check against CVEs. Running this tool # doesn't guarantee your packages are free of CVEs. +# The product name that the CVE database uses. Defaults to BPN, but may need to +# be overriden per recipe (for example tiff.bb sets CVE_PRODUCT=libtiff). +CVE_PRODUCT ?= "${BPN}" + CVE_CHECK_DB_DIR ?= "${DL_DIR}/CVE_CHECK" CVE_CHECK_DB_FILE ?= "${CVE_CHECK_DB_DIR}/nvd.db" @@ -144,7 +148,7 @@ def check_cves(d, patched_cves): cves_patched = [] cves_unpatched = [] - bpn = d.getVar("BPN", True) + bpn = d.getVar("CVE_PRODUCT") pv = d.getVar("PV", True).split("git+")[0] cves = " ".join(patched_cves) cve_db_dir = d.getVar("CVE_CHECK_DB_DIR", True)
Add a new variable CVE_PRODUCT for the product name to look up in the NVD database. Default this to BPN, but allow recipes such as tiff (which is libtiff in NVD) to override it. Signed-off-by: Ross Burton <ross.burton@intel.com> --- meta/classes/cve-check.bbclass | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) -- 2.8.1 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core