diff mbox

exynos: Enable XHCI on exynos5250 boards

Message ID 20170110133617.1193-1-sjoerd.simons@collabora.co.uk
State Accepted
Commit d64c31dd93e75c3940730d603c428d869a629168
Headers show

Commit Message

Sjoerd Simons Jan. 10, 2017, 1:36 p.m. UTC 
Once upon a time u-boot didn't support building with two usb host
controller types, these days it does. Enable XHCI in addition to the
existing EHCI support so user can plug usb devices in all available
ports regardless of the controller type.

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>


---

 configs/arndale_defconfig           | 2 ++
 configs/smdk5250_defconfig          | 2 ++
 configs/snow_defconfig              | 2 ++
 configs/spring_defconfig            | 2 ++
 include/configs/exynos5250-common.h | 2 ++
 5 files changed, 10 insertions(+)

-- 
2.11.0

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Comments

Javier Martinez Canillas Jan. 10, 2017, 1:50 p.m. UTC | #1 
Hello Sjoerd,

On 01/10/2017 10:36 AM, Sjoerd Simons wrote:
> Once upon a time u-boot didn't support building with two usb host

> controller types, these days it does. Enable XHCI in addition to the

> existing EHCI support so user can plug usb devices in all available

> ports regardless of the controller type.

> 

> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>

> 


Great, I didn't know u-boot now supported this!

It was particularly confusing in Snow IIRC because the ChromiumOS vendor
u-boot was built with XHCI support while mainline with EHCI by default.

Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Jaehoon Chung Jan. 11, 2017, 12:46 p.m. UTC | #2 
On 01/10/2017 10:36 PM, Sjoerd Simons wrote:
> Once upon a time u-boot didn't support building with two usb host

> controller types, these days it does. Enable XHCI in addition to the

> existing EHCI support so user can plug usb devices in all available

> ports regardless of the controller type.

> 

> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>


Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>


Best Regards,
Jaehoon Chung

> 

> ---

> 

>  configs/arndale_defconfig           | 2 ++

>  configs/smdk5250_defconfig          | 2 ++

>  configs/snow_defconfig              | 2 ++

>  configs/spring_defconfig            | 2 ++

>  include/configs/exynos5250-common.h | 2 ++

>  5 files changed, 10 insertions(+)

> 

> diff --git a/configs/arndale_defconfig b/configs/arndale_defconfig

> index cdfb73996f..821e1c7dd7 100644

> --- a/configs/arndale_defconfig

> +++ b/configs/arndale_defconfig

> @@ -31,4 +31,6 @@ CONFIG_SOUND_MAX98095=y

>  CONFIG_SOUND_WM8994=y

>  CONFIG_USB=y

>  CONFIG_DM_USB=y

> +CONFIG_USB_XHCI_HCD=y

> +CONFIG_USB_XHCI_DWC3=y

>  CONFIG_USB_STORAGE=y

> diff --git a/configs/smdk5250_defconfig b/configs/smdk5250_defconfig

> index b785efe306..95c379b580 100644

> --- a/configs/smdk5250_defconfig

> +++ b/configs/smdk5250_defconfig

> @@ -43,6 +43,8 @@ CONFIG_SOUND_WM8994=y

>  CONFIG_EXYNOS_SPI=y

>  CONFIG_USB=y

>  CONFIG_DM_USB=y

> +CONFIG_USB_XHCI_HCD=y

> +CONFIG_USB_XHCI_DWC3=y

>  CONFIG_USB_STORAGE=y

>  CONFIG_VIDEO_BRIDGE=y

>  CONFIG_ERRNO_STR=y

> diff --git a/configs/snow_defconfig b/configs/snow_defconfig

> index 47b498b6b2..967927f48a 100644

> --- a/configs/snow_defconfig

> +++ b/configs/snow_defconfig

> @@ -61,6 +61,8 @@ CONFIG_EXYNOS_SPI=y

>  CONFIG_TPM_TIS_INFINEON=y

>  CONFIG_USB=y

>  CONFIG_DM_USB=y

> +CONFIG_USB_XHCI_HCD=y

> +CONFIG_USB_XHCI_DWC3=y

>  CONFIG_USB_STORAGE=y

>  CONFIG_DM_VIDEO=y

>  CONFIG_DISPLAY=y

> diff --git a/configs/spring_defconfig b/configs/spring_defconfig

> index 4a782c80da..1898b95690 100644

> --- a/configs/spring_defconfig

> +++ b/configs/spring_defconfig

> @@ -61,6 +61,8 @@ CONFIG_EXYNOS_SPI=y

>  CONFIG_TPM_TIS_INFINEON=y

>  CONFIG_USB=y

>  CONFIG_DM_USB=y

> +CONFIG_USB_XHCI_HCD=y

> +CONFIG_USB_XHCI_DWC3=y

>  CONFIG_USB_STORAGE=y

>  CONFIG_DM_VIDEO=y

>  CONFIG_DISPLAY=y

> diff --git a/include/configs/exynos5250-common.h b/include/configs/exynos5250-common.h

> index 7d8921f24e..846739a6c5 100644

> --- a/include/configs/exynos5250-common.h

> +++ b/include/configs/exynos5250-common.h

> @@ -31,6 +31,8 @@

>  #define CONFIG_USB_EHCI

>  #define CONFIG_USB_EHCI_EXYNOS

>  

> +#define CONFIG_USB_XHCI_EXYNOS

> +

>  #define CONFIG_USB_HOST_ETHER

>  #define CONFIG_USB_ETHER_ASIX

>  #define CONFIG_USB_ETHER_ASIX88179

> 


_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Minkyu Kang Jan. 18, 2017, 5:21 a.m. UTC | #3 
On Wednesday, 11 January 2017, Jaehoon Chung <jh80.chung@samsung.com> wrote:

> On 01/10/2017 10:36 PM, Sjoerd Simons wrote:

> > Once upon a time u-boot didn't support building with two usb host

> > controller types, these days it does. Enable XHCI in addition to the

> > existing EHCI support so user can plug usb devices in all available

> > ports regardless of the controller type.

> >

> > Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk

> <javascript:;>>

>

> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com <javascript:;>>

>

> Best Regards,

> Jaehoon Chung

>

> >

> > ---

> >

> >  configs/arndale_defconfig           | 2 ++

> >  configs/smdk5250_defconfig          | 2 ++

> >  configs/snow_defconfig              | 2 ++

> >  configs/spring_defconfig            | 2 ++

> >  include/configs/exynos5250-common.h | 2 ++

> >  5 files changed, 10 insertions(+)

> >

> > diff --git a/configs/arndale_defconfig b/configs/arndale_defconfig

> > index cdfb73996f..821e1c7dd7 100644

> > --- a/configs/arndale_defconfig

> > +++ b/configs/arndale_defconfig

> > @@ -31,4 +31,6 @@ CONFIG_SOUND_MAX98095=y

> >  CONFIG_SOUND_WM8994=y

> >  CONFIG_USB=y

> >  CONFIG_DM_USB=y

> > +CONFIG_USB_XHCI_HCD=y

> > +CONFIG_USB_XHCI_DWC3=y

> >  CONFIG_USB_STORAGE=y

> > diff --git a/configs/smdk5250_defconfig b/configs/smdk5250_defconfig

> > index b785efe306..95c379b580 100644

> > --- a/configs/smdk5250_defconfig

> > +++ b/configs/smdk5250_defconfig

> > @@ -43,6 +43,8 @@ CONFIG_SOUND_WM8994=y

> >  CONFIG_EXYNOS_SPI=y

> >  CONFIG_USB=y

> >  CONFIG_DM_USB=y

> > +CONFIG_USB_XHCI_HCD=y

> > +CONFIG_USB_XHCI_DWC3=y

> >  CONFIG_USB_STORAGE=y

> >  CONFIG_VIDEO_BRIDGE=y

> >  CONFIG_ERRNO_STR=y

> > diff --git a/configs/snow_defconfig b/configs/snow_defconfig

> > index 47b498b6b2..967927f48a 100644

> > --- a/configs/snow_defconfig

> > +++ b/configs/snow_defconfig

> > @@ -61,6 +61,8 @@ CONFIG_EXYNOS_SPI=y

> >  CONFIG_TPM_TIS_INFINEON=y

> >  CONFIG_USB=y

> >  CONFIG_DM_USB=y

> > +CONFIG_USB_XHCI_HCD=y

> > +CONFIG_USB_XHCI_DWC3=y

> >  CONFIG_USB_STORAGE=y

> >  CONFIG_DM_VIDEO=y

> >  CONFIG_DISPLAY=y

> > diff --git a/configs/spring_defconfig b/configs/spring_defconfig

> > index 4a782c80da..1898b95690 100644

> > --- a/configs/spring_defconfig

> > +++ b/configs/spring_defconfig

> > @@ -61,6 +61,8 @@ CONFIG_EXYNOS_SPI=y

> >  CONFIG_TPM_TIS_INFINEON=y

> >  CONFIG_USB=y

> >  CONFIG_DM_USB=y

> > +CONFIG_USB_XHCI_HCD=y

> > +CONFIG_USB_XHCI_DWC3=y

> >  CONFIG_USB_STORAGE=y

> >  CONFIG_DM_VIDEO=y

> >  CONFIG_DISPLAY=y

> > diff --git a/include/configs/exynos5250-common.h

> b/include/configs/exynos5250-common.h

> > index 7d8921f24e..846739a6c5 100644

> > --- a/include/configs/exynos5250-common.h

> > +++ b/include/configs/exynos5250-common.h

> > @@ -31,6 +31,8 @@

> >  #define CONFIG_USB_EHCI

> >  #define CONFIG_USB_EHCI_EXYNOS

> >

> > +#define CONFIG_USB_XHCI_EXYNOS

> > +

> >  #define CONFIG_USB_HOST_ETHER

> >  #define CONFIG_USB_ETHER_ASIX

> >  #define CONFIG_USB_ETHER_ASIX88179

> >

>

> _______________________________________________

> U-Boot mailing list

> U-Boot@lists.denx.de <javascript:;>

> http://lists.denx.de/mailman/listinfo/u-boot

>


 applied to u-boot-samsung

Thanks


-- 
Thanks.
Minkyu Kang.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
diff mbox

Patch

diff --git a/configs/arndale_defconfig b/configs/arndale_defconfig
index cdfb73996f..821e1c7dd7 100644
--- a/configs/arndale_defconfig
+++ b/configs/arndale_defconfig
@@ -31,4 +31,6 @@  CONFIG_SOUND_MAX98095=y
 CONFIG_SOUND_WM8994=y
 CONFIG_USB=y
 CONFIG_DM_USB=y
+CONFIG_USB_XHCI_HCD=y
+CONFIG_USB_XHCI_DWC3=y
 CONFIG_USB_STORAGE=y
diff --git a/configs/smdk5250_defconfig b/configs/smdk5250_defconfig
index b785efe306..95c379b580 100644
--- a/configs/smdk5250_defconfig
+++ b/configs/smdk5250_defconfig
@@ -43,6 +43,8 @@  CONFIG_SOUND_WM8994=y
 CONFIG_EXYNOS_SPI=y
 CONFIG_USB=y
 CONFIG_DM_USB=y
+CONFIG_USB_XHCI_HCD=y
+CONFIG_USB_XHCI_DWC3=y
 CONFIG_USB_STORAGE=y
 CONFIG_VIDEO_BRIDGE=y
 CONFIG_ERRNO_STR=y
diff --git a/configs/snow_defconfig b/configs/snow_defconfig
index 47b498b6b2..967927f48a 100644
--- a/configs/snow_defconfig
+++ b/configs/snow_defconfig
@@ -61,6 +61,8 @@  CONFIG_EXYNOS_SPI=y
 CONFIG_TPM_TIS_INFINEON=y
 CONFIG_USB=y
 CONFIG_DM_USB=y
+CONFIG_USB_XHCI_HCD=y
+CONFIG_USB_XHCI_DWC3=y
 CONFIG_USB_STORAGE=y
 CONFIG_DM_VIDEO=y
 CONFIG_DISPLAY=y
diff --git a/configs/spring_defconfig b/configs/spring_defconfig
index 4a782c80da..1898b95690 100644
--- a/configs/spring_defconfig
+++ b/configs/spring_defconfig
@@ -61,6 +61,8 @@  CONFIG_EXYNOS_SPI=y
 CONFIG_TPM_TIS_INFINEON=y
 CONFIG_USB=y
 CONFIG_DM_USB=y
+CONFIG_USB_XHCI_HCD=y
+CONFIG_USB_XHCI_DWC3=y
 CONFIG_USB_STORAGE=y
 CONFIG_DM_VIDEO=y
 CONFIG_DISPLAY=y
diff --git a/include/configs/exynos5250-common.h b/include/configs/exynos5250-common.h
index 7d8921f24e..846739a6c5 100644
--- a/include/configs/exynos5250-common.h
+++ b/include/configs/exynos5250-common.h
@@ -31,6 +31,8 @@ 
 #define CONFIG_USB_EHCI
 #define CONFIG_USB_EHCI_EXYNOS
 
+#define CONFIG_USB_XHCI_EXYNOS
+
 #define CONFIG_USB_HOST_ETHER
 #define CONFIG_USB_ETHER_ASIX
 #define CONFIG_USB_ETHER_ASIX88179