| Message ID | 1495727836-30094-1-git-send-email-leo.yan@linaro.org |
|---|---|
| Headers | show |
| Series | coresight: enable debug module | expand |
On Mon, May 29, 2017 at 10:41:17AM -0600, Mathieu Poirier wrote: > On 25 May 2017 at 09:57, Leo Yan <leo.yan@linaro.org> wrote: > > ARMv8 architecture reference manual (ARM DDI 0487A.k) Chapter H7 "The > > Sample-based Profiling Extension" has description for sampling > > registers, we can utilize these registers to check program counter > > value with combined CPU exception level, secure state, etc. So this is > > helpful for CPU lockup bugs, e.g. if one CPU has run into infinite loop > > with IRQ disabled; the 'hang' CPU cannot switch context and handle any > > interrupt, so it cannot handle SMP call for stack dump, etc. > > > > This patch series is to enable coresight debug module with sample-based > > registers and register call back notifier for PCSR register dumping > > when panic happens, so we can see below dumping info for panic; and > > this patch series has considered the conditions for access permission > > for debug registers self, so this can avoid access debug registers when > > CPU power domain is off; the driver also try to figure out the CPU is > > in secure or non-secure state. > > I have queued patches 1 to 7 to my tree. I can't do anything about > patches 8 and 9 because they haven't been ack'ed. From here you can > either chase them to get an ACK or send a separate patch to them > directly. Thanks a lot, Mathieu. I will ping Wei and Andy/David saperately. > Thanks, > Mathieu -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Wei, On Thu, May 25, 2017 at 11:57:15PM +0800, Leo Yan wrote: > Bind debug module driver for Hi6220. Could you ACK this patch? From Mathieu's previous suggestion, after your confirmation he could pick up this patch. If you want me to send a separate patch to you directly, also is okay. Please let me know which is preferring. Thanks, Leo Yan > Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org> > Signed-off-by: Leo Yan <leo.yan@linaro.org> > --- > arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 64 +++++++++++++++++++++++++++++++ > 1 file changed, 64 insertions(+) > > diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > index 1e5129b..21805b9 100644 > --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > @@ -916,5 +916,69 @@ > }; > }; > }; > + > + debug@f6590000 { > + compatible = "arm,coresight-cpu-debug","arm,primecell"; > + reg = <0 0xf6590000 0 0x1000>; > + clocks = <&sys_ctrl HI6220_DAPB_CLK>; > + clock-names = "apb_pclk"; > + cpu = <&cpu0>; > + }; > + > + debug@f6592000 { > + compatible = "arm,coresight-cpu-debug","arm,primecell"; > + reg = <0 0xf6592000 0 0x1000>; > + clocks = <&sys_ctrl HI6220_DAPB_CLK>; > + clock-names = "apb_pclk"; > + cpu = <&cpu1>; > + }; > + > + debug@f6594000 { > + compatible = "arm,coresight-cpu-debug","arm,primecell"; > + reg = <0 0xf6594000 0 0x1000>; > + clocks = <&sys_ctrl HI6220_DAPB_CLK>; > + clock-names = "apb_pclk"; > + cpu = <&cpu2>; > + }; > + > + debug@f6596000 { > + compatible = "arm,coresight-cpu-debug","arm,primecell"; > + reg = <0 0xf6596000 0 0x1000>; > + clocks = <&sys_ctrl HI6220_DAPB_CLK>; > + clock-names = "apb_pclk"; > + cpu = <&cpu3>; > + }; > + > + debug@f65d0000 { > + compatible = "arm,coresight-cpu-debug","arm,primecell"; > + reg = <0 0xf65d0000 0 0x1000>; > + clocks = <&sys_ctrl HI6220_DAPB_CLK>; > + clock-names = "apb_pclk"; > + cpu = <&cpu4>; > + }; > + > + debug@f65d2000 { > + compatible = "arm,coresight-cpu-debug","arm,primecell"; > + reg = <0 0xf65d2000 0 0x1000>; > + clocks = <&sys_ctrl HI6220_DAPB_CLK>; > + clock-names = "apb_pclk"; > + cpu = <&cpu5>; > + }; > + > + debug@f65d4000 { > + compatible = "arm,coresight-cpu-debug","arm,primecell"; > + reg = <0 0xf65d4000 0 0x1000>; > + clocks = <&sys_ctrl HI6220_DAPB_CLK>; > + clock-names = "apb_pclk"; > + cpu = <&cpu6>; > + }; > + > + debug@f65d6000 { > + compatible = "arm,coresight-cpu-debug","arm,primecell"; > + reg = <0 0xf65d6000 0 0x1000>; > + clocks = <&sys_ctrl HI6220_DAPB_CLK>; > + clock-names = "apb_pclk"; > + cpu = <&cpu7>; > + }; > }; > }; > -- > 2.7.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Leo, On 2017/5/25 16:57, Leo Yan wrote: > Bind debug module driver for Hi6220. > > Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org> > Signed-off-by: Leo Yan <leo.yan@linaro.org> Thanks! Fine to me. Acked-by: Wei Xu <xuwei5@hisilicon.com> Hi Mathieu, Can you help to pick up this patch as well? Thanks! Best Regards, Wei > --- > arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 64 +++++++++++++++++++++++++++++++ > 1 file changed, 64 insertions(+) > > diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > index 1e5129b..21805b9 100644 > --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > @@ -916,5 +916,69 @@ > }; > }; > }; > + > + debug@f6590000 { > + compatible = "arm,coresight-cpu-debug","arm,primecell"; > + reg = <0 0xf6590000 0 0x1000>; > + clocks = <&sys_ctrl HI6220_DAPB_CLK>; > + clock-names = "apb_pclk"; > + cpu = <&cpu0>; > + }; > + > + debug@f6592000 { > + compatible = "arm,coresight-cpu-debug","arm,primecell"; > + reg = <0 0xf6592000 0 0x1000>; > + clocks = <&sys_ctrl HI6220_DAPB_CLK>; > + clock-names = "apb_pclk"; > + cpu = <&cpu1>; > + }; > + > + debug@f6594000 { > + compatible = "arm,coresight-cpu-debug","arm,primecell"; > + reg = <0 0xf6594000 0 0x1000>; > + clocks = <&sys_ctrl HI6220_DAPB_CLK>; > + clock-names = "apb_pclk"; > + cpu = <&cpu2>; > + }; > + > + debug@f6596000 { > + compatible = "arm,coresight-cpu-debug","arm,primecell"; > + reg = <0 0xf6596000 0 0x1000>; > + clocks = <&sys_ctrl HI6220_DAPB_CLK>; > + clock-names = "apb_pclk"; > + cpu = <&cpu3>; > + }; > + > + debug@f65d0000 { > + compatible = "arm,coresight-cpu-debug","arm,primecell"; > + reg = <0 0xf65d0000 0 0x1000>; > + clocks = <&sys_ctrl HI6220_DAPB_CLK>; > + clock-names = "apb_pclk"; > + cpu = <&cpu4>; > + }; > + > + debug@f65d2000 { > + compatible = "arm,coresight-cpu-debug","arm,primecell"; > + reg = <0 0xf65d2000 0 0x1000>; > + clocks = <&sys_ctrl HI6220_DAPB_CLK>; > + clock-names = "apb_pclk"; > + cpu = <&cpu5>; > + }; > + > + debug@f65d4000 { > + compatible = "arm,coresight-cpu-debug","arm,primecell"; > + reg = <0 0xf65d4000 0 0x1000>; > + clocks = <&sys_ctrl HI6220_DAPB_CLK>; > + clock-names = "apb_pclk"; > + cpu = <&cpu6>; > + }; > + > + debug@f65d6000 { > + compatible = "arm,coresight-cpu-debug","arm,primecell"; > + reg = <0 0xf65d6000 0 0x1000>; > + clocks = <&sys_ctrl HI6220_DAPB_CLK>; > + clock-names = "apb_pclk"; > + cpu = <&cpu7>; > + }; > }; > }; > -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Mathieu, On 2017/6/5 15:17, Mathieu Poirier wrote: > On 5 June 2017 at 02:33, Wei Xu <xuwei5@hisilicon.com> wrote: >> Hi Leo, >> >> On 2017/5/25 16:57, Leo Yan wrote: >>> Bind debug module driver for Hi6220. >>> >>> Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org> >>> Signed-off-by: Leo Yan <leo.yan@linaro.org> >> >> Thanks! >> Fine to me. >> Acked-by: Wei Xu <xuwei5@hisilicon.com> >> >> Hi Mathieu, >> >> Can you help to pick up this patch as well? >> Thanks! > > Sure - I'll add this to my tree. Thanks! BR, Wei > >> >> Best Regards, >> Wei >> >>> --- >>> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 64 +++++++++++++++++++++++++++++++ >>> 1 file changed, 64 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi >>> index 1e5129b..21805b9 100644 >>> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi >>> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi >>> @@ -916,5 +916,69 @@ >>> }; >>> }; >>> }; >>> + >>> + debug@f6590000 { >>> + compatible = "arm,coresight-cpu-debug","arm,primecell"; >>> + reg = <0 0xf6590000 0 0x1000>; >>> + clocks = <&sys_ctrl HI6220_DAPB_CLK>; >>> + clock-names = "apb_pclk"; >>> + cpu = <&cpu0>; >>> + }; >>> + >>> + debug@f6592000 { >>> + compatible = "arm,coresight-cpu-debug","arm,primecell"; >>> + reg = <0 0xf6592000 0 0x1000>; >>> + clocks = <&sys_ctrl HI6220_DAPB_CLK>; >>> + clock-names = "apb_pclk"; >>> + cpu = <&cpu1>; >>> + }; >>> + >>> + debug@f6594000 { >>> + compatible = "arm,coresight-cpu-debug","arm,primecell"; >>> + reg = <0 0xf6594000 0 0x1000>; >>> + clocks = <&sys_ctrl HI6220_DAPB_CLK>; >>> + clock-names = "apb_pclk"; >>> + cpu = <&cpu2>; >>> + }; >>> + >>> + debug@f6596000 { >>> + compatible = "arm,coresight-cpu-debug","arm,primecell"; >>> + reg = <0 0xf6596000 0 0x1000>; >>> + clocks = <&sys_ctrl HI6220_DAPB_CLK>; >>> + clock-names = "apb_pclk"; >>> + cpu = <&cpu3>; >>> + }; >>> + >>> + debug@f65d0000 { >>> + compatible = "arm,coresight-cpu-debug","arm,primecell"; >>> + reg = <0 0xf65d0000 0 0x1000>; >>> + clocks = <&sys_ctrl HI6220_DAPB_CLK>; >>> + clock-names = "apb_pclk"; >>> + cpu = <&cpu4>; >>> + }; >>> + >>> + debug@f65d2000 { >>> + compatible = "arm,coresight-cpu-debug","arm,primecell"; >>> + reg = <0 0xf65d2000 0 0x1000>; >>> + clocks = <&sys_ctrl HI6220_DAPB_CLK>; >>> + clock-names = "apb_pclk"; >>> + cpu = <&cpu5>; >>> + }; >>> + >>> + debug@f65d4000 { >>> + compatible = "arm,coresight-cpu-debug","arm,primecell"; >>> + reg = <0 0xf65d4000 0 0x1000>; >>> + clocks = <&sys_ctrl HI6220_DAPB_CLK>; >>> + clock-names = "apb_pclk"; >>> + cpu = <&cpu6>; >>> + }; >>> + >>> + debug@f65d6000 { >>> + compatible = "arm,coresight-cpu-debug","arm,primecell"; >>> + reg = <0 0xf65d6000 0 0x1000>; >>> + clocks = <&sys_ctrl HI6220_DAPB_CLK>; >>> + clock-names = "apb_pclk"; >>> + cpu = <&cpu7>; >>> + }; >>> }; >>> }; >>> >> > > . > -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html