| Message ID | 20170718214339.7774-17-robh@kernel.org |
|---|---|
| State | Accepted |
| Commit | e8305d408f7873f5a640c74f09d5665771acc369 |
| Headers | show |
Hi, On 2017년 07월 19일 06:42, Rob Herring wrote: > Now that we have a custom printf format specifier, convert users of > full_name to use %pOF instead. This is preparation to remove storing > of the full path string for each node. > > Signed-off-by: Rob Herring <robh@kernel.org> > Cc: Chanwoo Choi <cw00.choi@samsung.com> > Cc: MyungJoo Ham <myungjoo.ham@samsung.com> > Cc: Kyungmin Park <kyungmin.park@samsung.com> > Cc: linux-pm@vger.kernel.org > --- > drivers/devfreq/devfreq-event.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/devfreq/devfreq-event.c b/drivers/devfreq/devfreq-event.c > index 8648b32ebc89..d67242d87744 100644 > --- a/drivers/devfreq/devfreq-event.c > +++ b/drivers/devfreq/devfreq-event.c > @@ -277,8 +277,8 @@ int devfreq_event_get_edev_count(struct device *dev) > sizeof(u32)); > if (count < 0) { > dev_err(dev, > - "failed to get the count of devfreq-event in %s node\n", > - dev->of_node->full_name); > + "failed to get the count of devfreq-event in %pOF node\n", > + dev->of_node); > return count; > } > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> -- Best Regards, Chanwoo Choi Samsung Electronics
Hi Rob, On 2017년 08월 24일 03:09, Rob Herring wrote: > On Thu, Jul 20, 2017 at 12:25 AM, MyungJoo Ham <myungjoo.ham@samsung.com> wrote: >>> On 2017년 07월 19일 06:42, Rob Herring wrote: >>>> Now that we have a custom printf format specifier, convert users of >>>> full_name to use %pOF instead. This is preparation to remove storing >>>> of the full path string for each node. >>>> >>>> Signed-off-by: Rob Herring <robh@kernel.org> >>>> Cc: Chanwoo Choi <cw00.choi@samsung.com> >>>> Cc: MyungJoo Ham <myungjoo.ham@samsung.com> >>>> Cc: Kyungmin Park <kyungmin.park@samsung.com> >>>> Cc: linux-pm@vger.kernel.org >>>> --- >>>> drivers/devfreq/devfreq-event.c | 4 ++-- >>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/drivers/devfreq/devfreq-event.c b/drivers/devfreq/devfreq-event.c >>>> index 8648b32ebc89..d67242d87744 100644 >>>> --- a/drivers/devfreq/devfreq-event.c >>>> +++ b/drivers/devfreq/devfreq-event.c >>>> @@ -277,8 +277,8 @@ int devfreq_event_get_edev_count(struct device *dev) >>>> sizeof(u32)); >>>> if (count < 0) { >>>> dev_err(dev, >>>> - "failed to get the count of devfreq-event in %s node\n", >>>> - dev->of_node->full_name); >>>> + "failed to get the count of devfreq-event in %pOF node\n", >>>> + dev->of_node); >>>> return count; >>>> } >>>> >>> >>> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> >>> >> >> Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com> > > Please take this thru the devfreq tree. This patch was merged on devfreq tree. https://git.kernel.org/pub/scm/linux/kernel/git/mzx/devfreq.git/commit/?h=for-next&id=7f46535e8a2e3c3e415e55eaadcb9d9a153a5300 -- Best Regards, Chanwoo Choi Samsung Electronics
On Wed, Aug 23, 2017 at 6:18 PM, Chanwoo Choi <cw00.choi@samsung.com> wrote: > Hi Rob, > > On 2017년 08월 24일 03:09, Rob Herring wrote: >> On Thu, Jul 20, 2017 at 12:25 AM, MyungJoo Ham <myungjoo.ham@samsung.com> wrote: >>>> On 2017년 07월 19일 06:42, Rob Herring wrote: >>>>> Now that we have a custom printf format specifier, convert users of >>>>> full_name to use %pOF instead. This is preparation to remove storing >>>>> of the full path string for each node. >>>>> >>>>> Signed-off-by: Rob Herring <robh@kernel.org> >>>>> Cc: Chanwoo Choi <cw00.choi@samsung.com> >>>>> Cc: MyungJoo Ham <myungjoo.ham@samsung.com> >>>>> Cc: Kyungmin Park <kyungmin.park@samsung.com> >>>>> Cc: linux-pm@vger.kernel.org >>>>> --- >>>>> drivers/devfreq/devfreq-event.c | 4 ++-- >>>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>>> >>>>> diff --git a/drivers/devfreq/devfreq-event.c b/drivers/devfreq/devfreq-event.c >>>>> index 8648b32ebc89..d67242d87744 100644 >>>>> --- a/drivers/devfreq/devfreq-event.c >>>>> +++ b/drivers/devfreq/devfreq-event.c >>>>> @@ -277,8 +277,8 @@ int devfreq_event_get_edev_count(struct device *dev) >>>>> sizeof(u32)); >>>>> if (count < 0) { >>>>> dev_err(dev, >>>>> - "failed to get the count of devfreq-event in %s node\n", >>>>> - dev->of_node->full_name); >>>>> + "failed to get the count of devfreq-event in %pOF node\n", >>>>> + dev->of_node); >>>>> return count; >>>>> } >>>>> >>>> >>>> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> >>>> >>> >>> Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com> >> >> Please take this thru the devfreq tree. > > This patch was merged on devfreq tree. > https://git.kernel.org/pub/scm/linux/kernel/git/mzx/devfreq.git/commit/?h=for-next&id=7f46535e8a2e3c3e415e55eaadcb9d9a153a5300 Okay, it's not showing up in linux-next which is why I asked. Rob
diff --git a/drivers/devfreq/devfreq-event.c b/drivers/devfreq/devfreq-event.c index 8648b32ebc89..d67242d87744 100644 --- a/drivers/devfreq/devfreq-event.c +++ b/drivers/devfreq/devfreq-event.c @@ -277,8 +277,8 @@ int devfreq_event_get_edev_count(struct device *dev) sizeof(u32)); if (count < 0) { dev_err(dev, - "failed to get the count of devfreq-event in %s node\n", - dev->of_node->full_name); + "failed to get the count of devfreq-event in %pOF node\n", + dev->of_node); return count; }
Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node. Signed-off-by: Rob Herring <robh@kernel.org> Cc: Chanwoo Choi <cw00.choi@samsung.com> Cc: MyungJoo Ham <myungjoo.ham@samsung.com> Cc: Kyungmin Park <kyungmin.park@samsung.com> Cc: linux-pm@vger.kernel.org --- drivers/devfreq/devfreq-event.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.11.0