mbox series

[v3,00/13] mmc: meson-gx: driver fixups and upgrades

Message ID 20170828142915.27020-1-jbrunet@baylibre.com
Headers show
Series mmc: meson-gx: driver fixups and upgrades | expand

Message

Jerome Brunet Aug. 28, 2017, 2:29 p.m. UTC
The patchset features several bugfixes, rework and upgrade for the
meson-gx MMC driver.

The main goal is to improve readability and enable new high speed
modes, such as eMMC DDR52 and sdcard UHS modes up to SDR50 (100Mhz)

SDR104 is not working with a few cards on the p200 and the
libretech-cc. I suspect that 200Mhz might be a bit too fast for the PCB
of these boards, adding noise to the signal and eventually breaking
the communication with some cards. The same cards are working well on a
laptop or the nanopi-k2 at 200Mhz.

This series has been tested on gxbb-p200, gxbb-nanopi-k2 and
gxl-s905x-libretech-cc

Changes since v2 [1]:
* Drop patches 1 to 3: Applied.
* Drop patch 4: Debug stuff which should not have been sent.
* Added fix to previous patch 3:
  If the clock register is not initialized before registering the clk
  with CCF, the framework will complain about an illegal divider value.
  This had gone unnoticed because it was later fixed by the clock init
  rework.

  Ulf, I know it is getting late but it would be nice if patch #1 of
  this v3 could go with 3 patches you already applied. The rest can
  wait for the following cycle.

Changes since v1 [0]:
* Reorder patches to have fixes first, then rework and finally
  enhancements.
* Use CCF to manage clock phases

[0]: https://lkml.kernel.org/r/20170804174353.16486-1-jbrunet@baylibre.com
[1]: https://lkml.kernel.org/r/20170821160301.21899-1-jbrunet@baylibre.com

Jerome Brunet (13):
  mmc: meson-gx: initialize sane clk default before clock register
  mmc: meson-gx: cfg init overwrite values
  mmc: meson-gx: rework set_ios function
  mmc: meson-gx: rework clk_set function
  mmc: meson-gx: rework clock init function
  mmc: meson-gx: fix dual data rate mode frequencies
  mmc: meson-gx: work around clk-stop issue
  mmc: meson-gx: simplify interrupt handler
  mmc: meson-gx: implement card_busy callback
  mmc: meson-gx: use CCF to handle the clock phases
  mmc: meson-gx: implement voltage switch callback
  mmc: meson-gx: change default tx phase
  mmc: meson-gx: rework tuning function

 drivers/mmc/host/meson-gx-mmc.c | 710 ++++++++++++++++++++++++++++------------
 1 file changed, 493 insertions(+), 217 deletions(-)

-- 
2.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Kevin Hilman Aug. 30, 2017, 7:03 p.m. UTC | #1
Hi Ulf,

Ulf Hansson <ulf.hansson@linaro.org> writes:

> On 28 August 2017 at 16:29, Jerome Brunet <jbrunet@baylibre.com> wrote:

>> The patchset features several bugfixes, rework and upgrade for the

>> meson-gx MMC driver.

>>

>> The main goal is to improve readability and enable new high speed

>> modes, such as eMMC DDR52 and sdcard UHS modes up to SDR50 (100Mhz)

>>

>> SDR104 is not working with a few cards on the p200 and the

>> libretech-cc. I suspect that 200Mhz might be a bit too fast for the PCB

>> of these boards, adding noise to the signal and eventually breaking

>> the communication with some cards. The same cards are working well on a

>> laptop or the nanopi-k2 at 200Mhz.

>>

>> This series has been tested on gxbb-p200, gxbb-nanopi-k2 and

>> gxl-s905x-libretech-cc

>>

>> Changes since v2 [1]:

>> * Drop patches 1 to 3: Applied.

>> * Drop patch 4: Debug stuff which should not have been sent.

>> * Added fix to previous patch 3:

>>   If the clock register is not initialized before registering the clk

>>   with CCF, the framework will complain about an illegal divider value.

>>   This had gone unnoticed because it was later fixed by the clock init

>>   rework.

>>

>>   Ulf, I know it is getting late but it would be nice if patch #1 of

>>   this v3 could go with 3 patches you already applied. The rest can

>>   wait for the following cycle.

>

> I decided to pick them all, so applied for next!

>


Just to double-check, so I can plan for the DT patches
accordingly... you are queuing this for v4.14, right?

Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Ulf Hansson Aug. 31, 2017, 10:46 a.m. UTC | #2
On 30 August 2017 at 21:03, Kevin Hilman <khilman@baylibre.com> wrote:
> Hi Ulf,

>

> Ulf Hansson <ulf.hansson@linaro.org> writes:

>

>> On 28 August 2017 at 16:29, Jerome Brunet <jbrunet@baylibre.com> wrote:

>>> The patchset features several bugfixes, rework and upgrade for the

>>> meson-gx MMC driver.

>>>

>>> The main goal is to improve readability and enable new high speed

>>> modes, such as eMMC DDR52 and sdcard UHS modes up to SDR50 (100Mhz)

>>>

>>> SDR104 is not working with a few cards on the p200 and the

>>> libretech-cc. I suspect that 200Mhz might be a bit too fast for the PCB

>>> of these boards, adding noise to the signal and eventually breaking

>>> the communication with some cards. The same cards are working well on a

>>> laptop or the nanopi-k2 at 200Mhz.

>>>

>>> This series has been tested on gxbb-p200, gxbb-nanopi-k2 and

>>> gxl-s905x-libretech-cc

>>>

>>> Changes since v2 [1]:

>>> * Drop patches 1 to 3: Applied.

>>> * Drop patch 4: Debug stuff which should not have been sent.

>>> * Added fix to previous patch 3:

>>>   If the clock register is not initialized before registering the clk

>>>   with CCF, the framework will complain about an illegal divider value.

>>>   This had gone unnoticed because it was later fixed by the clock init

>>>   rework.

>>>

>>>   Ulf, I know it is getting late but it would be nice if patch #1 of

>>>   this v3 could go with 3 patches you already applied. The rest can

>>>   wait for the following cycle.

>>

>> I decided to pick them all, so applied for next!

>>

>

> Just to double-check, so I can plan for the DT patches

> accordingly... you are queuing this for v4.14, right?


Yes, correct!

Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html