| Message ID | 1504860327-18451-6-git-send-email-hemant.agrawal@nxp.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | NXP DPAA2 PMD updates | expand |
On 9/8/2017 9:45 AM, Hemant Agrawal wrote: > From: Haiying Wang <Haiying.Wang@nxp.com> > > Signed-off-by: Haiying Wang <Haiying.Wang@nxp.com> > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com> > --- > drivers/bus/fslmc/qbman/qbman_sys.h | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/bus/fslmc/qbman/qbman_sys.h b/drivers/bus/fslmc/qbman/qbman_sys.h > index 9ea55de..47da595 100644 > --- a/drivers/bus/fslmc/qbman/qbman_sys.h > +++ b/drivers/bus/fslmc/qbman/qbman_sys.h > @@ -217,7 +217,6 @@ static inline void qbman_cena_write_complete_wo_shadow(struct qbman_swp_sys *s, > #ifdef QBMAN_CENA_TRACE > pr_info("qbman_cena_write_complete(%p:%d:0x%03x)\n", > s->addr_cena, s->idx, offset); > - hexdump(cmd, 64); > #endif > dcbf(s->addr_cena + offset); > } > @@ -251,11 +250,7 @@ static inline void *qbman_cena_read_wo_shadow(struct qbman_swp_sys *s, > { > #ifdef QBMAN_CENA_TRACE > pr_info("qbman_cena_read(%p:%d:0x%03x) %p\n", > - s->addr_cena, s->idx, offset, shadow); > -#endif > - > -#ifdef QBMAN_CENA_TRACE > - hexdump(shadow, 64); > + s->addr_cena, s->idx, offset); Isn't this missing one parameter, previous "shadow" one? > #endif > return s->addr_cena + offset; > } >
On 9/15/2017 5:56 PM, Ferruh Yigit wrote: > On 9/8/2017 9:45 AM, Hemant Agrawal wrote: >> From: Haiying Wang <Haiying.Wang@nxp.com> >> >> Signed-off-by: Haiying Wang <Haiying.Wang@nxp.com> >> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com> >> --- >> drivers/bus/fslmc/qbman/qbman_sys.h | 7 +------ >> 1 file changed, 1 insertion(+), 6 deletions(-) >> >> diff --git a/drivers/bus/fslmc/qbman/qbman_sys.h b/drivers/bus/fslmc/qbman/qbman_sys.h >> index 9ea55de..47da595 100644 >> --- a/drivers/bus/fslmc/qbman/qbman_sys.h >> +++ b/drivers/bus/fslmc/qbman/qbman_sys.h >> @@ -217,7 +217,6 @@ static inline void qbman_cena_write_complete_wo_shadow(struct qbman_swp_sys *s, >> #ifdef QBMAN_CENA_TRACE >> pr_info("qbman_cena_write_complete(%p:%d:0x%03x)\n", >> s->addr_cena, s->idx, offset); >> - hexdump(cmd, 64); >> #endif >> dcbf(s->addr_cena + offset); >> } >> @@ -251,11 +250,7 @@ static inline void *qbman_cena_read_wo_shadow(struct qbman_swp_sys *s, >> { >> #ifdef QBMAN_CENA_TRACE >> pr_info("qbman_cena_read(%p:%d:0x%03x) %p\n", >> - s->addr_cena, s->idx, offset, shadow); >> -#endif >> - >> -#ifdef QBMAN_CENA_TRACE >> - hexdump(shadow, 64); >> + s->addr_cena, s->idx, offset); > > Isn't this missing one parameter, previous "shadow" one? > shadow is not existing any more. We should remove the last %p from pr_info. >> #endif >> return s->addr_cena + offset; >> } >> > >
diff --git a/drivers/bus/fslmc/qbman/qbman_sys.h b/drivers/bus/fslmc/qbman/qbman_sys.h index 9ea55de..47da595 100644 --- a/drivers/bus/fslmc/qbman/qbman_sys.h +++ b/drivers/bus/fslmc/qbman/qbman_sys.h @@ -217,7 +217,6 @@ static inline void qbman_cena_write_complete_wo_shadow(struct qbman_swp_sys *s, #ifdef QBMAN_CENA_TRACE pr_info("qbman_cena_write_complete(%p:%d:0x%03x)\n", s->addr_cena, s->idx, offset); - hexdump(cmd, 64); #endif dcbf(s->addr_cena + offset); } @@ -251,11 +250,7 @@ static inline void *qbman_cena_read_wo_shadow(struct qbman_swp_sys *s, { #ifdef QBMAN_CENA_TRACE pr_info("qbman_cena_read(%p:%d:0x%03x) %p\n", - s->addr_cena, s->idx, offset, shadow); -#endif - -#ifdef QBMAN_CENA_TRACE - hexdump(shadow, 64); + s->addr_cena, s->idx, offset); #endif return s->addr_cena + offset; }