diff mbox series

Enable ifunc attribute by default for ARM GNU/Linux

Message ID 1507575192-12814-1-git-send-email-adhemerval.zanella@linaro.org
State New
Headers show
Series Enable ifunc attribute by default for ARM GNU/Linux | expand

Commit Message

Adhemerval Zanella Oct. 9, 2017, 6:53 p.m. UTC 
Similar to other architectures with IFUNC binutils/glibc support, this
patch enables the ifunc attribute for ARM GNU/Linux.  Although not
required for build master GLIBC, the intention is to allow refactor
its assembly implementation to C [1].

Tested compilation of glibc (in conjunction with a glibc patch to
support using the attribute on ARM) with build-many-glibcs.py (with
a patch to add a armv7 variant which enables multiarch).  I have
not run the GCC tests for ARM.

	Adhemerval Zanella  <adhemerval.zanella@linaro.org>

	* config.gcc (default_gnu_indirect_function): Default to yes for
	arm*-*-linux* with glibc.

[1] https://sourceware.org/ml/libc-alpha/2017-10/msg00334.html
---
 gcc/ChangeLog  | 5 +++++
 gcc/config.gcc | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

-- 
2.7.4

Comments

Joseph Myers Oct. 9, 2017, 10:20 p.m. UTC | #1 
On Mon, 9 Oct 2017, Adhemerval Zanella wrote:

>  *-*-linux*)

>  	case ${target} in

> -	aarch64*-* | i[34567]86-* | powerpc*-* | s390*-* | sparc*-* | x86_64-*)

> +	aarch64*-* | i[34567]86-* | powerpc*-* | s390*-* | sparc*-* | x86_64-* | arm*-*)


I think the cases here are meant to be in alphabetical order.

-- 
Joseph S. Myers
joseph@codesourcery.com
Adhemerval Zanella Oct. 10, 2017, 1:14 p.m. UTC | #2 
On 09/10/2017 19:20, Joseph Myers wrote:
> On Mon, 9 Oct 2017, Adhemerval Zanella wrote:

> 

>>  *-*-linux*)

>>  	case ${target} in

>> -	aarch64*-* | i[34567]86-* | powerpc*-* | s390*-* | sparc*-* | x86_64-*)

>> +	aarch64*-* | i[34567]86-* | powerpc*-* | s390*-* | sparc*-* | x86_64-* | arm*-*)

> 

> I think the cases here are meant to be in alphabetical order.

> 


Ack, I will change.  Is it ok to commit with the change?
Joseph Myers Oct. 10, 2017, 1:52 p.m. UTC | #3 
On Tue, 10 Oct 2017, Adhemerval Zanella wrote:

> On 09/10/2017 19:20, Joseph Myers wrote:

> > On Mon, 9 Oct 2017, Adhemerval Zanella wrote:

> > 

> >>  *-*-linux*)

> >>  	case ${target} in

> >> -	aarch64*-* | i[34567]86-* | powerpc*-* | s390*-* | sparc*-* | x86_64-*)

> >> +	aarch64*-* | i[34567]86-* | powerpc*-* | s390*-* | sparc*-* | x86_64-* | arm*-*)

> > 

> > I think the cases here are meant to be in alphabetical order.

> > 

> 

> Ack, I will change.  Is it ok to commit with the change?


OK with that change in the absence of ARM architecture maintainer 
objections within 24 hours.

-- 
Joseph S. Myers
joseph@codesourcery.com
diff mbox series

Patch

diff --git a/gcc/config.gcc b/gcc/config.gcc
index 91a55e8..26aa8f6 100644
--- a/gcc/config.gcc
+++ b/gcc/config.gcc
@@ -3104,7 +3104,7 @@  case ${target} in
         ;;
 *-*-linux*)
 	case ${target} in
-	aarch64*-* | i[34567]86-* | powerpc*-* | s390*-* | sparc*-* | x86_64-*)
+	aarch64*-* | i[34567]86-* | powerpc*-* | s390*-* | sparc*-* | x86_64-* | arm*-*)
 		default_gnu_indirect_function=yes
 		;;
 	esac