| Message ID | 5301D56F.2050808@linaro.org |
|---|---|
| State | Accepted, archived |
| Headers | show |
Hi, Optimizations should be on by default. When debugging you can swap the lines in Makefile.inc. Example and packet tests are also performance tests. Also -O3 will uncover both compile and run time bugs (seen that happen already in ODP). -Petri On Monday, 17 February 2014 11:25:03 UTC+2, Maxim Uvarov wrote: > > I'm not sure which optimization version we should have now. Because we > do not have performance tests now looks like debug version > is more preferred. > > this patch changes: > --- a/Makefile.inc > +++ b/Makefile.inc > @@ -5,8 +5,8 @@ > > PLATFORM ?= linux-generic > CFLAGS += -DODP_DEBUG=1 > -#CFLAGS += -O3 > -CFLAGS += -O0 -g > +CFLAGS += -O3 > +#CFLAGS += -O0 -g > > > Maxim. >
Optimizations should be on by default. When debugging you can swap the lines in Makefile.inc. You should not need to change the MAkefile.inc (you can of course) but to compile differently, you should just unset the default by setting CFLAGS on the call to make or in your environment, this should fall out of the Makefile so that it is the last set of args seen by gcc, thus overriding the default in Makefile.inc. We need to make that patch to the Make system, but I am waiting for Anders patch to be accepted first. On 17 February 2014 04:39, Petri Savolainen <petri.savolainen@linaro.org>wrote: > Hi, > > Optimizations should be on by default. When debugging you can swap the > lines in Makefile.inc. Example and packet tests are also performance tests. > Also -O3 will uncover both compile and run time bugs (seen that happen > already in ODP). > > -Petri > > > > On Monday, 17 February 2014 11:25:03 UTC+2, Maxim Uvarov wrote: >> >> I'm not sure which optimization version we should have now. Because we >> do not have performance tests now looks like debug version >> is more preferred. >> >> this patch changes: >> --- a/Makefile.inc >> +++ b/Makefile.inc >> @@ -5,8 +5,8 @@ >> >> PLATFORM ?= linux-generic >> CFLAGS += -DODP_DEBUG=1 >> -#CFLAGS += -O3 >> -CFLAGS += -O0 -g >> +CFLAGS += -O3 >> +#CFLAGS += -O0 -g >> >> >> Maxim. >> > -- > You received this message because you are subscribed to the Google Groups > "LNG ODP Sub-team - lng-odp@linaro.org" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to lng-odp+unsubscribe@linaro.org. > To post to this group, send email to lng-odp@linaro.org. > Visit this group at http://groups.google.com/a/linaro.org/group/lng-odp/. > To view this discussion on the web visit > https://groups.google.com/a/linaro.org/d/msgid/lng-odp/419f1a7c-a523-43b9-8785-832c4720ec25%40linaro.org > . > > For more options, visit > https://groups.google.com/a/linaro.org/groups/opt_out. >
Applied, thanks! Maxim. On 02/17/2014 01:39 PM, Petri Savolainen wrote: > Hi, > > Optimizations should be on by default. When debugging you can swap the > lines in Makefile.inc. Example and packet tests are also performance > tests. Also -O3 will uncover both compile and run time bugs (seen that > happen already in ODP). > > -Petri > > > On Monday, 17 February 2014 11:25:03 UTC+2, Maxim Uvarov wrote: > > I'm not sure which optimization version we should have now. > Because we > do not have performance tests now looks like debug version > is more preferred. > > this patch changes: > --- a/Makefile.inc > +++ b/Makefile.inc > @@ -5,8 +5,8 @@ > > PLATFORM ?= linux-generic > CFLAGS += -DODP_DEBUG=1 > -#CFLAGS += -O3 > -CFLAGS += -O0 -g > +CFLAGS += -O3 > +#CFLAGS += -O0 -g > > > Maxim. > > -- > You received this message because you are subscribed to the Google > Groups "LNG ODP Sub-team - lng-odp@linaro.org" group. > To unsubscribe from this group and stop receiving emails from it, send > an email to lng-odp+unsubscribe@linaro.org. > To post to this group, send email to lng-odp@linaro.org. > Visit this group at http://groups.google.com/a/linaro.org/group/lng-odp/. > To view this discussion on the web visit > https://groups.google.com/a/linaro.org/d/msgid/lng-odp/419f1a7c-a523-43b9-8785-832c4720ec25%40linaro.org. > For more options, visit > https://groups.google.com/a/linaro.org/groups/opt_out.
--- a/Makefile.inc +++ b/Makefile.inc @@ -5,8 +5,8 @@ PLATFORM ?= linux-generic CFLAGS += -DODP_DEBUG=1 -#CFLAGS += -O3 -CFLAGS += -O0 -g +CFLAGS += -O3 +#CFLAGS += -O0 -g Maxim.