diff mbox series

[1/2] dt-bindings: fsi: Add optional property no-scan-on-init

Message ID 20180130055116.17411-2-joel@jms.id.au
State New
Headers show
Series [1/2] dt-bindings: fsi: Add optional property no-scan-on-init | expand

Commit Message

Joel Stanley Jan. 30, 2018, 5:51 a.m. UTC
From: Christopher Bostic <cbostic@linux.vnet.ibm.com>


Add an optional FSI master property 'no-scan-on-init.  This
can be specified to indicate that a master should not be
automatically scanned at init time.  This is required in cases
where a scan could interfere with another FSI master on the same
bus.

Signed-off-by: Christopher Bostic <cbostic@linux.vnet.ibm.com>

Acked-by: Jeremy Kerr <jk@ozlabs.org>

Signed-off-by: Joel Stanley <joel@jms.id.au>

---
 Documentation/devicetree/bindings/fsi/fsi.txt | 7 +++++++
 1 file changed, 7 insertions(+)

-- 
2.15.1

Comments

Rob Herring (Arm) Feb. 5, 2018, 6:07 a.m. UTC | #1
On Tue, Jan 30, 2018 at 04:21:15PM +1030, Joel Stanley wrote:
> From: Christopher Bostic <cbostic@linux.vnet.ibm.com>

> 

> Add an optional FSI master property 'no-scan-on-init.  This

> can be specified to indicate that a master should not be

> automatically scanned at init time.  This is required in cases

> where a scan could interfere with another FSI master on the same

> bus.

> 

> Signed-off-by: Christopher Bostic <cbostic@linux.vnet.ibm.com>

> Acked-by: Jeremy Kerr <jk@ozlabs.org>

> Signed-off-by: Joel Stanley <joel@jms.id.au>

> ---

>  Documentation/devicetree/bindings/fsi/fsi.txt | 7 +++++++

>  1 file changed, 7 insertions(+)

> 

> diff --git a/Documentation/devicetree/bindings/fsi/fsi.txt b/Documentation/devicetree/bindings/fsi/fsi.txt

> index 4eaf488d4015..ab516c673a4b 100644

> --- a/Documentation/devicetree/bindings/fsi/fsi.txt

> +++ b/Documentation/devicetree/bindings/fsi/fsi.txt

> @@ -56,6 +56,13 @@ addresses (link index and slave ID), and no size:

>      #address-cells = <2>;

>      #size-cells = <0>;

>  

> +An optional boolean property can be added to indicate that a particular master

> +should not scan for connected devices at initialization time.  This is

> +necessary in cases where a scan could cause arbitration issues with other

> +masters that may be present on the bus.

> +

> +    no-scan-on-init;

> +


The formatting here is a bit strange compared to most bindings, but no 
point in reformatting the document to add one property.

Reviewed-by: Rob Herring <robh@kernel.org>


Rob
Joel Stanley Feb. 5, 2018, 6:08 a.m. UTC | #2
On Mon, Feb 5, 2018 at 4:37 PM, Rob Herring <robh@kernel.org> wrote:
> On Tue, Jan 30, 2018 at 04:21:15PM +1030, Joel Stanley wrote:

>> From: Christopher Bostic <cbostic@linux.vnet.ibm.com>

>>

>> Add an optional FSI master property 'no-scan-on-init.  This

>> can be specified to indicate that a master should not be

>> automatically scanned at init time.  This is required in cases

>> where a scan could interfere with another FSI master on the same

>> bus.

>>

>> Signed-off-by: Christopher Bostic <cbostic@linux.vnet.ibm.com>

>> Acked-by: Jeremy Kerr <jk@ozlabs.org>

>> Signed-off-by: Joel Stanley <joel@jms.id.au>

>> ---

>>  Documentation/devicetree/bindings/fsi/fsi.txt | 7 +++++++

>>  1 file changed, 7 insertions(+)

>>

>> diff --git a/Documentation/devicetree/bindings/fsi/fsi.txt b/Documentation/devicetree/bindings/fsi/fsi.txt

>> index 4eaf488d4015..ab516c673a4b 100644

>> --- a/Documentation/devicetree/bindings/fsi/fsi.txt

>> +++ b/Documentation/devicetree/bindings/fsi/fsi.txt

>> @@ -56,6 +56,13 @@ addresses (link index and slave ID), and no size:

>>      #address-cells = <2>;

>>      #size-cells = <0>;

>>

>> +An optional boolean property can be added to indicate that a particular master

>> +should not scan for connected devices at initialization time.  This is

>> +necessary in cases where a scan could cause arbitration issues with other

>> +masters that may be present on the bus.

>> +

>> +    no-scan-on-init;

>> +

>

> The formatting here is a bit strange compared to most bindings, but no

> point in reformatting the document to add one property.


I'll keep that in mind next time we're working in this area.

Thanks Rob.

>

> Reviewed-by: Rob Herring <robh@kernel.org>

>

> Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/fsi/fsi.txt b/Documentation/devicetree/bindings/fsi/fsi.txt
index 4eaf488d4015..ab516c673a4b 100644
--- a/Documentation/devicetree/bindings/fsi/fsi.txt
+++ b/Documentation/devicetree/bindings/fsi/fsi.txt
@@ -56,6 +56,13 @@  addresses (link index and slave ID), and no size:
     #address-cells = <2>;
     #size-cells = <0>;
 
+An optional boolean property can be added to indicate that a particular master
+should not scan for connected devices at initialization time.  This is
+necessary in cases where a scan could cause arbitration issues with other
+masters that may be present on the bus.
+
+    no-scan-on-init;
+
 FSI slaves
 ----------