| Message ID | 20180208230914.19368-1-ross.burton@intel.com |
|---|---|
| State | Accepted |
| Commit | 4bbb8cd5f3943231ab5be0448d1b0d4a08341249 |
| Headers | show |
| Series | cve-check: put log in T so it doesn't get deleted by rm_work | expand |
On 02/09/2018 01:09 AM, Ross Burton wrote:
> This is where the other task logs go, so it's a sensible place to put it.
There is a bunch of other cve-check related commits in master now that
were never posted here, why is that?
Alex
--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Because I failed to post them to the list and Richard merged a chunk of MUT on my approval, forgetting that I hadn't posted them. My mistake, apologies. Ross On 17 February 2018 at 14:38, Alexander Kanavin < alexander.kanavin@linux.intel.com> wrote: > On 02/09/2018 01:09 AM, Ross Burton wrote: > >> This is where the other task logs go, so it's a sensible place to put it. >> > > There is a bunch of other cve-check related commits in master now that > were never posted here, why is that? > > Alex > <div dir="ltr">Because I failed to post them to the list and Richard merged a chunk of MUT on my approval, forgetting that I hadn't posted them. My mistake, apologies.<div><br></div><div>Ross</div></div><div class="gmail_extra"><br><div class="gmail_quote">On 17 February 2018 at 14:38, Alexander Kanavin <span dir="ltr"><<a href="mailto:alexander.kanavin@linux.intel.com" target="_blank">alexander.kanavin@linux.intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 02/09/2018 01:09 AM, Ross Burton wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> This is where the other task logs go, so it's a sensible place to put it.<br> </blockquote> <br></span> There is a bunch of other cve-check related commits in master now that were never posted here, why is that?<br> <br> Alex<br> </blockquote></div><br></div> -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Cheers, can you nevertheless post the missing patches here please? Alex On 02/18/2018 02:19 AM, Burton, Ross wrote: > Because I failed to post them to the list and Richard merged a chunk of > MUT on my approval, forgetting that I hadn't posted them. My mistake, > apologies. > > Ross > > On 17 February 2018 at 14:38, Alexander Kanavin > <alexander.kanavin@linux.intel.com > <mailto:alexander.kanavin@linux.intel.com>> wrote: > > On 02/09/2018 01:09 AM, Ross Burton wrote: > > This is where the other task logs go, so it's a sensible place > to put it. > > > There is a bunch of other cve-check related commits in master now > that were never posted here, why is that? > > Alex > >
diff --git a/meta/classes/cve-check.bbclass b/meta/classes/cve-check.bbclass index bc2f03f7ddb..62dd6424d5c 100644 --- a/meta/classes/cve-check.bbclass +++ b/meta/classes/cve-check.bbclass @@ -27,8 +27,7 @@ CVE_PRODUCT ??= "${BPN}" CVE_CHECK_DB_DIR ?= "${DL_DIR}/CVE_CHECK" CVE_CHECK_DB_FILE ?= "${CVE_CHECK_DB_DIR}/nvd.db" -CVE_CHECK_LOCAL_DIR ?= "${WORKDIR}/cve" -CVE_CHECK_LOCAL_FILE ?= "${CVE_CHECK_LOCAL_DIR}/cve.log" +CVE_CHECK_LOG ?= "${T}/cve.log" CVE_CHECK_TMP_FILE ?= "${TMPDIR}/cve_check" CVE_CHECK_DIR ??= "${DEPLOY_DIR}/cve" @@ -251,11 +250,11 @@ def cve_write_data(d, patched, unpatched, cve_data): CVE manifest if enabled. """ - cve_file = d.getVar("CVE_CHECK_LOCAL_FILE") + cve_file = d.getVar("CVE_CHECK_LOG") nvd_link = "https://web.nvd.nist.gov/view/vuln/detail?vulnId=" write_string = "" unpatched_cves = [] - bb.utils.mkdirhier(d.getVar("CVE_CHECK_LOCAL_DIR")) + bb.utils.mkdirhier(os.path.dirname(cve_file)) for cve in sorted(cve_data): write_string += "PACKAGE NAME: %s\n" % d.getVar("PN")
This is where the other task logs go, so it's a sensible place to put it. Signed-off-by: Ross Burton <ross.burton@intel.com> --- meta/classes/cve-check.bbclass | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) -- 2.11.0 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core