| Message ID | 20180227182619.6973-1-ard.biesheuvel@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [edk2,edk2-platforms] Platform/96Boards/Secure96Dxe: remove /plugin/ from .dts | expand |
On Tue, Feb 27, 2018 at 06:26:19PM +0000, Ard Biesheuvel wrote: > Even though the Secure96 device tree source is strictly an overlay, we > managed to express it in a way that does not rely on unresolved symbols > and other tricks that are only implemented in fairly recent versions of > the device tree compiler, and so adding the /plugin/ directive is not > only unnecessary, it is harmful because it is only understood by those > same recent compiler versions. So remove it. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> > --- > Platform/96Boards/Secure96Dxe/Secure96.dts | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Platform/96Boards/Secure96Dxe/Secure96.dts b/Platform/96Boards/Secure96Dxe/Secure96.dts > index b56ce59985cc..a221bdf9bbec 100644 > --- a/Platform/96Boards/Secure96Dxe/Secure96.dts > +++ b/Platform/96Boards/Secure96Dxe/Secure96.dts > @@ -22,7 +22,6 @@ > #define GPIO_PARENT_PLACEHOLDER_PHANDLE 0x0 > > /dts-v1/; > -/plugin/; > > / { > fragment@0 { > -- > 2.11.0 > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
On 27 February 2018 at 20:06, Leif Lindholm <leif.lindholm@linaro.org> wrote: > On Tue, Feb 27, 2018 at 06:26:19PM +0000, Ard Biesheuvel wrote: >> Even though the Secure96 device tree source is strictly an overlay, we >> managed to express it in a way that does not rely on unresolved symbols >> and other tricks that are only implemented in fairly recent versions of >> the device tree compiler, and so adding the /plugin/ directive is not >> only unnecessary, it is harmful because it is only understood by those >> same recent compiler versions. So remove it. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> > Thanks Pushed as f90743b8813518fd7111c272ea4a3483a94ed462 >> --- >> Platform/96Boards/Secure96Dxe/Secure96.dts | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/Platform/96Boards/Secure96Dxe/Secure96.dts b/Platform/96Boards/Secure96Dxe/Secure96.dts >> index b56ce59985cc..a221bdf9bbec 100644 >> --- a/Platform/96Boards/Secure96Dxe/Secure96.dts >> +++ b/Platform/96Boards/Secure96Dxe/Secure96.dts >> @@ -22,7 +22,6 @@ >> #define GPIO_PARENT_PLACEHOLDER_PHANDLE 0x0 >> >> /dts-v1/; >> -/plugin/; >> >> / { >> fragment@0 { >> -- >> 2.11.0 >> _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
diff --git a/Platform/96Boards/Secure96Dxe/Secure96.dts b/Platform/96Boards/Secure96Dxe/Secure96.dts index b56ce59985cc..a221bdf9bbec 100644 --- a/Platform/96Boards/Secure96Dxe/Secure96.dts +++ b/Platform/96Boards/Secure96Dxe/Secure96.dts @@ -22,7 +22,6 @@ #define GPIO_PARENT_PLACEHOLDER_PHANDLE 0x0 /dts-v1/; -/plugin/; / { fragment@0 {
Even though the Secure96 device tree source is strictly an overlay, we managed to express it in a way that does not rely on unresolved symbols and other tricks that are only implemented in fairly recent versions of the device tree compiler, and so adding the /plugin/ directive is not only unnecessary, it is harmful because it is only understood by those same recent compiler versions. So remove it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> --- Platform/96Boards/Secure96Dxe/Secure96.dts | 1 - 1 file changed, 1 deletion(-) -- 2.11.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel