| Message ID | 1393206490-25234-1-git-send-email-shawn.guo@linaro.org |
|---|---|
| State | New |
| Headers | show |
On Mon, Feb 24, 2014 at 08:53:37AM +0100, Sascha Hauer wrote: > On Mon, Feb 24, 2014 at 09:48:10AM +0800, Shawn Guo wrote: > > Update fsl-fec.txt to add 'clocks' and 'clock-names' properties. > > > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org> > > --- > > Changes since v1: > > - Leave compatible change out, which should probably be addressed by > > another patch > > - Move clock properties into 'Optional properties:' section > > As mentioned in the reply to v1: Marking the clocks as optional doesn't > make sense when the driver actually requires them (Or be prepared when > somebody sends in a patch 'fixing' the driver according to the binding). > IMO we should just mention the clocks are optional on PowerPC. Okay, the whole thing becomes quite uncertain to me. The reason of this v2 is that I got reminded by Gerhard's comment that we've had a time the driver works with DT without these properties. At that time, the clock driver provides the clock lookups for the device by calling clk_register_clkdev(). But on the other hand, I agree with you that it does not make sense to binding users, because the IP requires these clock inputs when it gets integrated on a SoC, and the driver requires these clocks to work. Shawn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/net/fsl-fec.txt b/Documentation/devicetree/bindings/net/fsl-fec.txt index 845ff84..468736d 100644 --- a/Documentation/devicetree/bindings/net/fsl-fec.txt +++ b/Documentation/devicetree/bindings/net/fsl-fec.txt @@ -16,6 +16,15 @@ Optional properties: will have the duration be 1 millisecond. Numbers greater than 1000 are invalid and 1 millisecond will be used instead. - phy-supply: regulator that powers the Ethernet PHY. +- clocks: the clocks feeding the FEC controller and phy. + - "ipg": the peripheral access clock + - "ahb": the bus clock for MAC + - "ptp": the sampling clock for PTP (IEEE 1588). On SoC like i.MX6Q, + the clock could come from either the internal clock control module + or external oscillator via pad depending on board design. + - "enet_out": the phy reference clock provided by SoC via pad, which + is available on SoC like i.MX28. +- clock-names: Must contain the clock names described just above Example:
Update fsl-fec.txt to add 'clocks' and 'clock-names' properties. Signed-off-by: Shawn Guo <shawn.guo@linaro.org> --- Changes since v1: - Leave compatible change out, which should probably be addressed by another patch - Move clock properties into 'Optional properties:' section Documentation/devicetree/bindings/net/fsl-fec.txt | 9 +++++++++ 1 file changed, 9 insertions(+)