mbox series

[0/2] target/arm: Coverity fixups

Message ID 20180501180455.11214-1-richard.henderson@linaro.org
Headers show
Series target/arm: Coverity fixups | expand

Message

Richard Henderson May 1, 2018, 6:04 p.m. UTC 
The first patch covers four related false positives.  However, 
we check the same condition twice and we certainly don't need
to that.  Plus the assert might just help documentation-wise.

The second patch covers dead code.  I believe that Coverity is
right and that there are no paths that have !is_q at this point.
Add the assert to check that is true.

The RISU tests that I ran over these insns came out clean.


r~


Richard Henderson (2):
  target/arm: Tidy conditions in handle_vec_simd_shri
  target/arm: Tidy condition in disas_simd_two_reg_misc

 target/arm/translate-a64.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

-- 
2.14.3

Comments

Peter Maydell May 3, 2018, 3:05 p.m. UTC | #1 
On 1 May 2018 at 19:04, Richard Henderson <richard.henderson@linaro.org> wrote:
> The first patch covers four related false positives.  However,

> we check the same condition twice and we certainly don't need

> to that.  Plus the assert might just help documentation-wise.

>

> The second patch covers dead code.  I believe that Coverity is

> right and that there are no paths that have !is_q at this point.

> Add the assert to check that is true.

>

> The RISU tests that I ran over these insns came out clean.

>


Applied to target-arm.next, thanks.

-- PMM