mbox series

[for,3.0,00/10] various docker fixes

Message ID 20180709152117.21585-1-alex.bennee@linaro.org
Headers show
Series various docker fixes | expand

Message

Alex Bennée July 9, 2018, 3:21 p.m. UTC 
Hi,

The addition of the cross compilers for check-tcg broke the ability to
run "make docker-test".  In truth this was probably already broken as
it attempts to run every single test with every single docker image
which isn't something that gets done on a regular basis.

Anyway the patches clean up the ability to do that in a sane way
although it still takes a long time to run the full test set.

To help with running a better subset I've expanded the individual
tests so you can now run a line like:

  make docker-test-build TARGET_LIST=aarch64-softmmu J=30

To make sure your favourite architecture still builds everywhere.

There is now also a docker-test-unit which just runs the unit tests
although we have to do a little re-factoring to make sure we don't
attempt to run "make check" steps when the docker image isn't capable
of it. This is also needed to make sure the other test-FOO build tests
don't choke on the check step.

Finally there is a minor tweak for .gitignore and a fix for docker.py
throwing backtraces when we attempt to calculate SID_AGE. A cleaner
re-factoring can be left for a future release.

Alex Bennée (10):
  tests/.gitignore: don't ignore docker tests
  docker: debian-tricore add git tools
  docker: fail more gracefully on docker.py check
  docker: split configure_qemu from build_qemu
  docker: move make check into check_qemu helper
  docker: gracefully skip check_qemu
  docker: Makefile.include don't include partial images
  docker: disable debian-powerpc-user-cross
  docker: add test-unit runner
  docker: add expansion for docker-test-FOO to Makefile.include

 tests/.gitignore                              |  1 +
 tests/docker/Makefile.include                 | 14 +++++++++--
 tests/docker/common.rc                        | 23 ++++++++++++++++++-
 tests/docker/docker.py                        |  7 +++++-
 .../dockerfiles/debian-tricore-cross.docker   |  3 +++
 tests/docker/test-clang                       |  2 +-
 tests/docker/test-debug                       |  2 +-
 tests/docker/test-full                        |  2 +-
 tests/docker/test-quick                       |  2 +-
 tests/docker/test-unit                        | 19 +++++++++++++++
 10 files changed, 67 insertions(+), 8 deletions(-)
 create mode 100755 tests/docker/test-unit

-- 
2.17.1

Comments

Fam Zheng July 10, 2018, 7:06 a.m. UTC | #1 
On Mon, 07/09 16:21, Alex Bennée wrote:
> Hi,

> 

> The addition of the cross compilers for check-tcg broke the ability to

> run "make docker-test".  In truth this was probably already broken as

> it attempts to run every single test with every single docker image

> which isn't something that gets done on a regular basis.

> 

> Anyway the patches clean up the ability to do that in a sane way

> although it still takes a long time to run the full test set.

> 

> To help with running a better subset I've expanded the individual

> tests so you can now run a line like:

> 

>   make docker-test-build TARGET_LIST=aarch64-softmmu J=30

> 

> To make sure your favourite architecture still builds everywhere.

> 

> There is now also a docker-test-unit which just runs the unit tests

> although we have to do a little re-factoring to make sure we don't

> attempt to run "make check" steps when the docker image isn't capable

> of it. This is also needed to make sure the other test-FOO build tests

> don't choke on the check step.

> 

> Finally there is a minor tweak for .gitignore and a fix for docker.py

> throwing backtraces when we attempt to calculate SID_AGE. A cleaner

> re-factoring can be left for a future release.


Thanks for the clean ups!

Looks good in general. The only thing I notice is the test-unit script.

Fam