diff mbox series

ARM: dts: da850: Add power-domains to CPPI 4.1 node

Message ID 20180704094432.5424-1-nsekhar@ti.com
State Accepted
Commit 3117c17301edce7583843bdee513e201bb69c37c
Headers show
Series ARM: dts: da850: Add power-domains to CPPI 4.1 node | expand

Commit Message

Sekhar Nori July 4, 2018, 9:44 a.m. UTC
This adds the power-domains property to CPPI 4.1 node.

The CPPI 4.1 DMA driver uses pm_runtime to manage the clocks,
so it needs this property in order to find and enable the clock
properly.

Signed-off-by: Sekhar Nori <nsekhar@ti.com>

---
Applies for v4.19/dt branch of my tree.

 arch/arm/boot/dts/da850.dtsi | 1 +
 1 file changed, 1 insertion(+)

-- 
2.16.2

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

David Lechner July 6, 2018, 5:02 p.m. UTC | #1
On 07/04/2018 04:44 AM, Sekhar Nori wrote:
> This adds the power-domains property to CPPI 4.1 node.

> 

> The CPPI 4.1 DMA driver uses pm_runtime to manage the clocks,

> so it needs this property in order to find and enable the clock

> properly.

> 

> Signed-off-by: Sekhar Nori <nsekhar@ti.com>

> ---

> Applies for v4.19/dt branch of my tree.

> 

>   arch/arm/boot/dts/da850.dtsi | 1 +

>   1 file changed, 1 insertion(+)

> 

> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi

> index 9e05a5a709c0..07f215e7e5b8 100644

> --- a/arch/arm/boot/dts/da850.dtsi

> +++ b/arch/arm/boot/dts/da850.dtsi

> @@ -637,6 +637,7 @@

>   				interrupts = <58>;

>   				#dma-cells = <2>;

>   				#dma-channels = <4>;

> +				power-domains = <&psc1 1>;

>   				status = "okay";

>   			};

>   		};

> 


Reviewed-by: David Lechner <david@lechnology.com>



Although this has me wondering if we can now remove the clock-ranges
property in the parent node.

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Bartosz Golaszewski July 9, 2018, 6:58 a.m. UTC | #2
2018-07-04 11:44 GMT+02:00 Sekhar Nori <nsekhar@ti.com>:
> This adds the power-domains property to CPPI 4.1 node.

>

> The CPPI 4.1 DMA driver uses pm_runtime to manage the clocks,

> so it needs this property in order to find and enable the clock

> properly.

>

> Signed-off-by: Sekhar Nori <nsekhar@ti.com>

> ---

> Applies for v4.19/dt branch of my tree.

>

>  arch/arm/boot/dts/da850.dtsi | 1 +

>  1 file changed, 1 insertion(+)

>

> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi

> index 9e05a5a709c0..07f215e7e5b8 100644

> --- a/arch/arm/boot/dts/da850.dtsi

> +++ b/arch/arm/boot/dts/da850.dtsi

> @@ -637,6 +637,7 @@

>                                 interrupts = <58>;

>                                 #dma-cells = <2>;

>                                 #dma-channels = <4>;

> +                               power-domains = <&psc1 1>;

>                                 status = "okay";

>                         };

>                 };

> --

> 2.16.2

>


Tested-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sekhar Nori July 10, 2018, 10:05 a.m. UTC | #3
On Friday 06 July 2018 10:32 PM, David Lechner wrote:
> On 07/04/2018 04:44 AM, Sekhar Nori wrote:

>> This adds the power-domains property to CPPI 4.1 node.

>>

>> The CPPI 4.1 DMA driver uses pm_runtime to manage the clocks,

>> so it needs this property in order to find and enable the clock

>> properly.

>>

>> Signed-off-by: Sekhar Nori <nsekhar@ti.com>

>> ---

>> Applies for v4.19/dt branch of my tree.

>>

>>   arch/arm/boot/dts/da850.dtsi | 1 +

>>   1 file changed, 1 insertion(+)

>>

>> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi

>> index 9e05a5a709c0..07f215e7e5b8 100644

>> --- a/arch/arm/boot/dts/da850.dtsi

>> +++ b/arch/arm/boot/dts/da850.dtsi

>> @@ -637,6 +637,7 @@

>>                   interrupts = <58>;

>>                   #dma-cells = <2>;

>>                   #dma-channels = <4>;

>> +                power-domains = <&psc1 1>;

>>                   status = "okay";

>>               };

>>           };

>>

> 

> Reviewed-by: David Lechner <david@lechnology.com>


Thanks, applied with this and Bartosz's Tested-by.

> Although this has me wondering if we can now remove the clock-ranges

> property in the parent node.


Agree its not really used. But probably leave it there since its correct
anyway and we don't want to add it back if the DMA driver needs access
to clock at some point.

Thanks,
Sekhar
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
index 9e05a5a709c0..07f215e7e5b8 100644
--- a/arch/arm/boot/dts/da850.dtsi
+++ b/arch/arm/boot/dts/da850.dtsi
@@ -637,6 +637,7 @@ 
 				interrupts = <58>;
 				#dma-cells = <2>;
 				#dma-channels = <4>;
+				power-domains = <&psc1 1>;
 				status = "okay";
 			};
 		};