mbox series

[0/7] conf: Replace SKIP_OSTYPE with SKIP_VALIDATE

Message ID cover.1532467269.git.crobinso@redhat.com
Headers show
Series conf: Replace SKIP_OSTYPE with SKIP_VALIDATE | expand

Message

Cole Robinson July 24, 2018, 9:23 p.m. UTC 
The SKIP_OSTYPE domain parse flag is largely redundant nowadays
since we have SKIP_VALIDATE. This series smoothes out some of
the SKIP_OSTYPE weirdness so we can drop it

Cole Robinson (7):
  conf: Break out virDomainDefParseCaps
  conf: Clean up virDomainDefParseCaps
  tests: qemuhotplug: Fix segfault when XML loading fails
  conf: Drop unneccessary caps parsing logic
  conf: Sync caps data even when SKIP_OSTYPE_CHECKS
  tests: Remove redundant lxc test
  conf: Replace SKIP_OSTYPE_CHECKS with SKIP_VALIDATE

 src/conf/domain_conf.c                     | 175 +++++++++++----------
 src/conf/domain_conf.h                     |  13 +-
 src/conf/snapshot_conf.c                   |   2 -
 src/conf/virdomainobjlist.c                |   2 -
 tests/lxcxml2xmltest.c                     |   2 -
 tests/qemuhotplugtest.c                    |   2 +
 tests/qemuxml2argvdata/missing-machine.xml |   2 +-
 tests/qemuxml2argvtest.c                   |   5 +-
 tests/qemuxml2xmltest.c                    |   1 -
 tests/testutils.c                          |  13 +-
 tests/testutilsqemu.c                      |  18 +++
 tests/vircapstest.c                        |   2 -
 12 files changed, 132 insertions(+), 105 deletions(-)

-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Comments

Michal Prívozník July 26, 2018, 6:44 a.m. UTC | #1 
On 07/24/2018 11:23 PM, Cole Robinson wrote:
> The SKIP_OSTYPE domain parse flag is largely redundant nowadays

> since we have SKIP_VALIDATE. This series smoothes out some of

> the SKIP_OSTYPE weirdness so we can drop it

> 

> Cole Robinson (7):

>   conf: Break out virDomainDefParseCaps

>   conf: Clean up virDomainDefParseCaps

>   tests: qemuhotplug: Fix segfault when XML loading fails

>   conf: Drop unneccessary caps parsing logic

>   conf: Sync caps data even when SKIP_OSTYPE_CHECKS

>   tests: Remove redundant lxc test

>   conf: Replace SKIP_OSTYPE_CHECKS with SKIP_VALIDATE

> 

>  src/conf/domain_conf.c                     | 175 +++++++++++----------

>  src/conf/domain_conf.h                     |  13 +-

>  src/conf/snapshot_conf.c                   |   2 -

>  src/conf/virdomainobjlist.c                |   2 -

>  tests/lxcxml2xmltest.c                     |   2 -

>  tests/qemuhotplugtest.c                    |   2 +

>  tests/qemuxml2argvdata/missing-machine.xml |   2 +-

>  tests/qemuxml2argvtest.c                   |   5 +-

>  tests/qemuxml2xmltest.c                    |   1 -

>  tests/testutils.c                          |  13 +-

>  tests/testutilsqemu.c                      |  18 +++

>  tests/vircapstest.c                        |   2 -

>  12 files changed, 132 insertions(+), 105 deletions(-)

> 


ACK series.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list