| Message ID | 20180626153035.361-1-anders.roxell@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | mips: configs: remove no longer needed config option | expand |
On Tue, 26 Jun 2018 at 17:30, Anders Roxell <anders.roxell@linaro.org> wrote: > > Since commit eedf265aa003 ("devpts: Make each mount of devpts an > independent filesystem.") CONFIG_DEVPTS_MULTIPLE_INSTANCES isn't needed > in the defconfig anymore. > > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> > --- > arch/mips/configs/ip27_defconfig | 1 - > arch/mips/configs/nlm_xlp_defconfig | 1 - > arch/mips/configs/nlm_xlr_defconfig | 1 - > 3 files changed, 3 deletions(-) > > diff --git a/arch/mips/configs/ip27_defconfig b/arch/mips/configs/ip27_defconfig > index 91a9c13e2c82..fbcbfc365c64 100644 > --- a/arch/mips/configs/ip27_defconfig > +++ b/arch/mips/configs/ip27_defconfig > @@ -262,7 +262,6 @@ CONFIG_SERIAL_8250_CONSOLE=y > CONFIG_SERIAL_8250_EXTENDED=y > CONFIG_SERIAL_8250_MANY_PORTS=y > CONFIG_SERIAL_8250_SHARE_IRQ=y > -CONFIG_DEVPTS_MULTIPLE_INSTANCES=y > CONFIG_HW_RANDOM_TIMERIOMEM=m > CONFIG_I2C_CHARDEV=m > CONFIG_I2C_ALI1535=m > diff --git a/arch/mips/configs/nlm_xlp_defconfig b/arch/mips/configs/nlm_xlp_defconfig > index e8e1dd8e0e99..aec323ed6968 100644 > --- a/arch/mips/configs/nlm_xlp_defconfig > +++ b/arch/mips/configs/nlm_xlp_defconfig > @@ -403,7 +403,6 @@ CONFIG_SERIO_SERPORT=m > CONFIG_SERIO_LIBPS2=y > CONFIG_SERIO_RAW=m > CONFIG_VT_HW_CONSOLE_BINDING=y > -CONFIG_DEVPTS_MULTIPLE_INSTANCES=y > CONFIG_LEGACY_PTY_COUNT=0 > CONFIG_SERIAL_NONSTANDARD=y > CONFIG_N_HDLC=m > diff --git a/arch/mips/configs/nlm_xlr_defconfig b/arch/mips/configs/nlm_xlr_defconfig > index c4477a4d40c1..88c185da23ce 100644 > --- a/arch/mips/configs/nlm_xlr_defconfig > +++ b/arch/mips/configs/nlm_xlr_defconfig > @@ -336,7 +336,6 @@ CONFIG_SERIO_SERPORT=m > CONFIG_SERIO_LIBPS2=y > CONFIG_SERIO_RAW=m > CONFIG_VT_HW_CONSOLE_BINDING=y > -CONFIG_DEVPTS_MULTIPLE_INSTANCES=y > CONFIG_LEGACY_PTY_COUNT=0 > CONFIG_SERIAL_NONSTANDARD=y > CONFIG_N_HDLC=m > -- > 2.18.0 > Ping.
Hi Anders, On Thu, Jul 26, 2018 at 09:04:57AM +0200, Anders Roxell wrote: > > Since commit eedf265aa003 ("devpts: Make each mount of devpts an > > independent filesystem.") CONFIG_DEVPTS_MULTIPLE_INSTANCES isn't needed > > in the defconfig anymore. > > > > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> > > --- > > arch/mips/configs/ip27_defconfig | 1 - > > arch/mips/configs/nlm_xlp_defconfig | 1 - > > arch/mips/configs/nlm_xlr_defconfig | 1 - > > 3 files changed, 3 deletions(-) > > Ping. Apologies - this was forgotten because it stopped showing up as requiring action in patchwork after Ralf marked it as accepted, but it has never been applied to the shared mips-next branch. I do question whether it's worthwhile making these one-line changes to configs, because: 1) The no presence of CONFIG_DEVPTS_MULTIPLE_INSTANCES is harmless anyway, it'll just be ignored. 2) The configs in question will still not be up to date with a lot of other changes since they were added. Together these 2 things lead me to think that we'd be better to either: a) Leave the defconfigs as-is, since the changes won't make them work any better or worse. b) Regenerate them entirely, such that they're up to date with not just this Kconfig change but all of them. Thanks, Paul
diff --git a/arch/mips/configs/ip27_defconfig b/arch/mips/configs/ip27_defconfig index 91a9c13e2c82..fbcbfc365c64 100644 --- a/arch/mips/configs/ip27_defconfig +++ b/arch/mips/configs/ip27_defconfig @@ -262,7 +262,6 @@ CONFIG_SERIAL_8250_CONSOLE=y CONFIG_SERIAL_8250_EXTENDED=y CONFIG_SERIAL_8250_MANY_PORTS=y CONFIG_SERIAL_8250_SHARE_IRQ=y -CONFIG_DEVPTS_MULTIPLE_INSTANCES=y CONFIG_HW_RANDOM_TIMERIOMEM=m CONFIG_I2C_CHARDEV=m CONFIG_I2C_ALI1535=m diff --git a/arch/mips/configs/nlm_xlp_defconfig b/arch/mips/configs/nlm_xlp_defconfig index e8e1dd8e0e99..aec323ed6968 100644 --- a/arch/mips/configs/nlm_xlp_defconfig +++ b/arch/mips/configs/nlm_xlp_defconfig @@ -403,7 +403,6 @@ CONFIG_SERIO_SERPORT=m CONFIG_SERIO_LIBPS2=y CONFIG_SERIO_RAW=m CONFIG_VT_HW_CONSOLE_BINDING=y -CONFIG_DEVPTS_MULTIPLE_INSTANCES=y CONFIG_LEGACY_PTY_COUNT=0 CONFIG_SERIAL_NONSTANDARD=y CONFIG_N_HDLC=m diff --git a/arch/mips/configs/nlm_xlr_defconfig b/arch/mips/configs/nlm_xlr_defconfig index c4477a4d40c1..88c185da23ce 100644 --- a/arch/mips/configs/nlm_xlr_defconfig +++ b/arch/mips/configs/nlm_xlr_defconfig @@ -336,7 +336,6 @@ CONFIG_SERIO_SERPORT=m CONFIG_SERIO_LIBPS2=y CONFIG_SERIO_RAW=m CONFIG_VT_HW_CONSOLE_BINDING=y -CONFIG_DEVPTS_MULTIPLE_INSTANCES=y CONFIG_LEGACY_PTY_COUNT=0 CONFIG_SERIAL_NONSTANDARD=y CONFIG_N_HDLC=m
Since commit eedf265aa003 ("devpts: Make each mount of devpts an independent filesystem.") CONFIG_DEVPTS_MULTIPLE_INSTANCES isn't needed in the defconfig anymore. Signed-off-by: Anders Roxell <anders.roxell@linaro.org> --- arch/mips/configs/ip27_defconfig | 1 - arch/mips/configs/nlm_xlp_defconfig | 1 - arch/mips/configs/nlm_xlr_defconfig | 1 - 3 files changed, 3 deletions(-) -- 2.18.0