mbox series

[RFC,v2,0/9] TI LMU and Dedicated Drivers

Message ID 20180928182954.25446-1-dmurphy@ti.com
Headers show
Series TI LMU and Dedicated Drivers | expand

Message

Dan Murphy Sept. 28, 2018, 6:29 p.m. UTC 
All

The following v2 patchset has been debugged and updated to support the
LM3697, LM3632 and LM3633.  The TI LMU common code has been used and can
be extended where need be.  If this approach is acceptable I will make code
changes based on review and submit v3 with additional bindings updates for
full review and merge.

These 3 LED drivers should be functional to provide basic lighting experiences.
Other features like PWM support will be included later and maybe part of the
common code.

I usually list all the deltas in my patch sets but due to the major rip in the
drivers I would repeat myself just saying that there are too many changes to
list.

Dan

Dan Murphy (8):
  dt-bindings: ti-lmu: Remove LM3697
  mfd: ti-lmu: Remove support for LM3697
  dt-bindings: leds: Add bindings for lm3697 driver
  leds: lm3697: Introduce the lm3697 driver
  dt-bindings: leds: Add support for the LM3633
  leds: lm3633: Introduce the lm3633 driver
  dt-bindings: leds: Add the LM3632 LED dt binding
  leds: lm3632: Introduce the TI LM3632 driver

Pavel Machek (1):
  leds: add TI LMU backlight driver

 .../devicetree/bindings/leds/leds-lm3632.txt  |  53 ++
 .../devicetree/bindings/leds/leds-lm3633.txt  | 102 +++
 .../devicetree/bindings/leds/leds-lm3697.txt  |  98 +++
 .../devicetree/bindings/mfd/ti-lmu.txt        |  26 +-
 drivers/leds/Kconfig                          |  30 +
 drivers/leds/Makefile                         |   4 +
 drivers/leds/leds-lm3632.c                    | 646 ++++++++++++++++++
 drivers/leds/leds-lm3633.c                    | 557 +++++++++++++++
 drivers/leds/leds-lm3697.c                    | 382 +++++++++++
 drivers/leds/ti-lmu-led-common.c              | 138 ++++
 drivers/leds/ti-lmu-led-common.h              |  54 ++
 drivers/mfd/Kconfig                           |   2 +-
 drivers/mfd/ti-lmu.c                          |  17 -
 include/linux/mfd/ti-lmu-register.h           |  44 --
 include/linux/mfd/ti-lmu.h                    |   1 -
 15 files changed, 2066 insertions(+), 88 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3632.txt
 create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3633.txt
 create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3697.txt
 create mode 100644 drivers/leds/leds-lm3632.c
 create mode 100644 drivers/leds/leds-lm3633.c
 create mode 100644 drivers/leds/leds-lm3697.c
 create mode 100644 drivers/leds/ti-lmu-led-common.c
 create mode 100644 drivers/leds/ti-lmu-led-common.h

-- 
2.19.0

Comments

Pavel Machek Oct. 2, 2018, 7:28 a.m. UTC | #1 
On Fri 2018-09-28 13:29:47, Dan Murphy wrote:
> Remove support for the LM3697 LED device

> from the ti-lmu.  The LM3697 will be supported

> via a stand alone LED driver.

> 

> Signed-off-by: Dan Murphy <dmurphy@ti.com>


NAK, for reasons I explained before. Please add it to the patch so
that it does not get applied by mistake. Ouch and AFAICT Rob was not
happy with this either.

Yes, you are creating new drivers, ok; but that does _not_ mean you
should create new binding.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Pavel Machek Oct. 3, 2018, 1:01 p.m. UTC | #2 
On Wed 2018-10-03 07:24:23, Dan Murphy wrote:
> Hello

> 

> On 10/02/2018 02:28 AM, Pavel Machek wrote:

> > On Fri 2018-09-28 13:29:47, Dan Murphy wrote:

> >> Remove support for the LM3697 LED device

> >> from the ti-lmu.  The LM3697 will be supported

> >> via a stand alone LED driver.

> >>

> >> Signed-off-by: Dan Murphy <dmurphy@ti.com>

> > 

> > NAK, for reasons I explained before. Please add it to the patch so

> > that it does not get applied by mistake. Ouch and AFAICT Rob was not

> > happy with this either.

> > 

> > Yes, you are creating new drivers, ok; but that does _not_ mean you

> > should create new binding.

> 

> I am copying my comment here on the review of this original binding for

> records

> 

> I found the review or at least the reference for the ti-lmu.txt binding.

> 

> https://lore.kernel.org/patchwork/patch/764180/

> 

> Does not appear that the binding was sent to the device tree mail list.

> (Maybe that email list did not exist in Feb 2017).


Quick google shows:

https://lwn.net/Articles/666023/

Now can we stop this nonsense? If there is a problem with the binding,
submit patches to fix the problem.

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html