| Message ID | 20181110121711.15257-1-richard.henderson@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [for-3.1] target/arm: Fix typo in tlbi_aa64_vmalle1_write | expand |
On 11/10/18 1:17 PM, Richard Henderson wrote: > This would cause an infinite recursion or loop. Hehe :) > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > target/arm/helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/arm/helper.c b/target/arm/helper.c > index 96301930cc..a327988c66 100644 > --- a/target/arm/helper.c > +++ b/target/arm/helper.c > @@ -3155,7 +3155,7 @@ static void tlbi_aa64_vmalle1_write(CPUARMState *env, const ARMCPRegInfo *ri, > CPUState *cs = ENV_GET_CPU(env); > > if (tlb_force_broadcast(env)) { > - tlbi_aa64_vmalle1_write(env, NULL, value); > + tlbi_aa64_vmalle1is_write(env, NULL, value); > return; > } > >
Richard Henderson <richard.henderson@linaro.org> writes: > This would cause an infinite recursion or loop. > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> I feel the title undersells the importance of the fix ;-) Reviewed-by: Alex Bennée <alex.bennee@linaro.org> > --- > target/arm/helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/arm/helper.c b/target/arm/helper.c > index 96301930cc..a327988c66 100644 > --- a/target/arm/helper.c > +++ b/target/arm/helper.c > @@ -3155,7 +3155,7 @@ static void tlbi_aa64_vmalle1_write(CPUARMState *env, const ARMCPRegInfo *ri, > CPUState *cs = ENV_GET_CPU(env); > > if (tlb_force_broadcast(env)) { > - tlbi_aa64_vmalle1_write(env, NULL, value); > + tlbi_aa64_vmalle1is_write(env, NULL, value); > return; > } -- Alex Bennée
On 10 November 2018 at 12:17, Richard Henderson <richard.henderson@linaro.org> wrote: > This would cause an infinite recursion or loop. > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > target/arm/helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/arm/helper.c b/target/arm/helper.c > index 96301930cc..a327988c66 100644 > --- a/target/arm/helper.c > +++ b/target/arm/helper.c > @@ -3155,7 +3155,7 @@ static void tlbi_aa64_vmalle1_write(CPUARMState *env, const ARMCPRegInfo *ri, > CPUState *cs = ENV_GET_CPU(env); > > if (tlb_force_broadcast(env)) { > - tlbi_aa64_vmalle1_write(env, NULL, value); > + tlbi_aa64_vmalle1is_write(env, NULL, value); > return; > } > Applied to target-arm.next, thanks. -- PMM
diff --git a/target/arm/helper.c b/target/arm/helper.c index 96301930cc..a327988c66 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -3155,7 +3155,7 @@ static void tlbi_aa64_vmalle1_write(CPUARMState *env, const ARMCPRegInfo *ri, CPUState *cs = ENV_GET_CPU(env); if (tlb_force_broadcast(env)) { - tlbi_aa64_vmalle1_write(env, NULL, value); + tlbi_aa64_vmalle1is_write(env, NULL, value); return; }
This would cause an infinite recursion or loop. Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- target/arm/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.2