| Message ID | 20181119160338.5774-1-ard.biesheuvel@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [edk2] Silicon/SynQuacer: remove bogus PL011 _HID from DSDT ACPI table | expand |
On Mon, Nov 19, 2018 at 08:03:38AM -0800, Ard Biesheuvel wrote: > PL011 is not a valid ACPI identifier so don't expose it as a _CID. > Since _CID (Comptable ID) is optional, let's just drop it. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> > --- > Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl b/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl > index 3f73c191d4d6..7c7677f1fea0 100644 > --- a/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl > +++ b/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl > @@ -135,7 +135,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 1, "SNI", "SYNQUACR", > // UART PL011 > Device (COM0) { > Name (_HID, "ARMH0011") > - Name (_CID, "PL011") > Name (_UID, Zero) > Name (_CRS, ResourceTemplate () { > Memory32Fixed (ReadWrite, FixedPcdGet32 (PcdSerialRegisterBase), 0x1000) > -- > 2.17.1 > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
On Mon, 19 Nov 2018 at 09:48, Leif Lindholm <leif.lindholm@linaro.org> wrote: > > On Mon, Nov 19, 2018 at 08:03:38AM -0800, Ard Biesheuvel wrote: > > PL011 is not a valid ACPI identifier so don't expose it as a _CID. > > Since _CID (Comptable ID) is optional, let's just drop it. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> > Thanks. Pushed as 46d3a977b931156a7155a879cdd2b0c95bb1aae0 > > --- > > Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl b/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl > > index 3f73c191d4d6..7c7677f1fea0 100644 > > --- a/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl > > +++ b/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl > > @@ -135,7 +135,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 1, "SNI", "SYNQUACR", > > // UART PL011 > > Device (COM0) { > > Name (_HID, "ARMH0011") > > - Name (_CID, "PL011") > > Name (_UID, Zero) > > Name (_CRS, ResourceTemplate () { > > Memory32Fixed (ReadWrite, FixedPcdGet32 (PcdSerialRegisterBase), 0x1000) > > -- > > 2.17.1 > > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
> From: Ard Biesheuvel <ard.biesheuvel@linaro.org> > Date: Mon, 19 Nov 2018 08:03:38 -0800 > > PL011 is not a valid ACPI identifier so don't expose it as a _CID. > Since _CID (Comptable ID) is optional, let's just drop it. Heh, I Noticed that one when adding ACPI support for OpenBSD/arm64. Reviewed-by: Mark Kettenis <kettenis@openbsd.org> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > --- > Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl b/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl > index 3f73c191d4d6..7c7677f1fea0 100644 > --- a/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl > +++ b/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl > @@ -135,7 +135,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 1, "SNI", "SYNQUACR", > // UART PL011 > Device (COM0) { > Name (_HID, "ARMH0011") > - Name (_CID, "PL011") > Name (_UID, Zero) > Name (_CRS, ResourceTemplate () { > Memory32Fixed (ReadWrite, FixedPcdGet32 (PcdSerialRegisterBase), 0x1000) > -- > 2.17.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
diff --git a/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl b/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl index 3f73c191d4d6..7c7677f1fea0 100644 --- a/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl +++ b/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl @@ -135,7 +135,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 1, "SNI", "SYNQUACR", // UART PL011 Device (COM0) { Name (_HID, "ARMH0011") - Name (_CID, "PL011") Name (_UID, Zero) Name (_CRS, ResourceTemplate () { Memory32Fixed (ReadWrite, FixedPcdGet32 (PcdSerialRegisterBase), 0x1000)
PL011 is not a valid ACPI identifier so don't expose it as a _CID. Since _CID (Comptable ID) is optional, let's just drop it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> --- Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl | 1 - 1 file changed, 1 deletion(-) -- 2.17.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel