mbox series

[0/5] tcg: Make bswap support in qemu_ld/st optional

Message ID 20181120121558.7660-1-richard.henderson@linaro.org
Headers show
Series tcg: Make bswap support in qemu_ld/st optional | expand

Message

Richard Henderson Nov. 20, 2018, 12:15 p.m. UTC 
Having to support bswap in the guest memory operations at times
requires an irritating number of temporaries.  Better to allow
the bswap operations to be expanded outside of the memory ops
and let register allocation do its thing.

This is something that I've been planning to do for some time,
to aid i386 and arm32 especially.  But I've been prompted again
by the nacent risc-v backend, for which this would be especially
irritating to have to open-code.

Alistair, for convenience I've pushed this to 

  https://github.com/rth7680/qemu.git tcg-next-for-4.0


r~


Richard Henderson (5):
  tcg: Add TCG_TARGET_HAS_MEMORY_BSWAP
  tcg/optimize: Optimize bswap
  tcg/i386: Set TCG_TARGET_HAS_MEMORY_BSWAP with have_movbe
  tcg/aarch64: Set TCG_TARGET_HAS_MEMORY_BSWAP to false
  tcg/arm: Set TCG_TARGET_HAS_MEMORY_BSWAP to false

 tcg/aarch64/tcg-target.h     |   1 +
 tcg/arm/tcg-target.h         |   1 +
 tcg/i386/tcg-target.h        |   3 +
 tcg/mips/tcg-target.h        |   1 +
 tcg/ppc/tcg-target.h         |   1 +
 tcg/s390/tcg-target.h        |   1 +
 tcg/sparc/tcg-target.h       |   1 +
 tcg/tci/tcg-target.h         |   2 +
 tcg/aarch64/tcg-target.inc.c |  63 +++--------
 tcg/arm/tcg-target.inc.c     | 198 +++++++++--------------------------
 tcg/i386/tcg-target.inc.c    | 112 +++++++-------------
 tcg/optimize.c               |  12 +++
 tcg/tcg-op.c                 | 118 ++++++++++++++++++++-
 13 files changed, 234 insertions(+), 280 deletions(-)

-- 
2.17.2

Comments

no-reply@patchew.org Nov. 22, 2018, 1:11 a.m. UTC | #1 
Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20181120121558.7660-1-richard.henderson@linaro.org
Type: series
Subject: [Qemu-devel] [PATCH 0/5] tcg: Make bswap support in qemu_ld/st optional

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
6336156 tcg/arm: Set TCG_TARGET_HAS_MEMORY_BSWAP to false
8b6c77b tcg/aarch64: Set TCG_TARGET_HAS_MEMORY_BSWAP to false
97936ce tcg/i386: Set TCG_TARGET_HAS_MEMORY_BSWAP with have_movbe
b6d6faf tcg/optimize: Optimize bswap
6a671c7 tcg: Add TCG_TARGET_HAS_MEMORY_BSWAP

=== OUTPUT BEGIN ===
Checking PATCH 1/5: tcg: Add TCG_TARGET_HAS_MEMORY_BSWAP...
Checking PATCH 2/5: tcg/optimize: Optimize bswap...
ERROR: spaces required around that ':' (ctx:VxE)
#21: FILE: tcg/optimize.c:356:
+    CASE_OP_32_64(bswap16):
                           ^

ERROR: spaces required around that ':' (ctx:VxE)
#24: FILE: tcg/optimize.c:359:
+    CASE_OP_32_64(bswap32):
                           ^

ERROR: spaces required around that ':' (ctx:VxE)
#37: FILE: tcg/optimize.c:1117:
+        CASE_OP_32_64(bswap16):
                               ^

ERROR: spaces required around that ':' (ctx:VxE)
#38: FILE: tcg/optimize.c:1118:
+        CASE_OP_32_64(bswap32):
                               ^

total: 4 errors, 0 warnings, 24 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/5: tcg/i386: Set TCG_TARGET_HAS_MEMORY_BSWAP with have_movbe...
Checking PATCH 4/5: tcg/aarch64: Set TCG_TARGET_HAS_MEMORY_BSWAP to false...
Checking PATCH 5/5: tcg/arm: Set TCG_TARGET_HAS_MEMORY_BSWAP to false...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com