| Message ID | 1543237854-32562-1-git-send-email-nariman.poushin@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [edk2,1/2] Readme.md: Update instructions to fetch source | expand |
Could you add [edk2-platform] in the title? So, I know this change is for edk2-platform repo. And, please add Contributed-under: TianoCore Contribution Agreement 1.1 before Signed-off-by. > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Nariman Poushin > Sent: Monday, November 26, 2018 9:11 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH 1/2] Readme.md: Update instructions to fetch source > > Openssl is fetched as a git submodule, so make sure git clone --recursive > is specified in the instructions to fetch a full source tree. > > Signed-off-by: Nariman Poushin <nariman.poushin@linaro.org> > --- > Readme.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Readme.md b/Readme.md > index 6ad5953..bb53c6f 100644 > --- a/Readme.md > +++ b/Readme.md > @@ -78,7 +78,7 @@ target-specific binutils. These are included with any prepackaged GCC toolchain > 1. [edk2-non-osi](https://github.com/tianocore/edk2-non-osi) (if building > platforms that need it) > ``` > - $ git clone https://github.com/tianocore/edk2.git > + $ git clone https://github.com/tianocore/edk2.git --recursive > ... > $ git clone https://github.com/tianocore/edk2-platforms.git > ... > -- > 2.7.4 > > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Hi, Of course, I will resend both patches with the appropriate Contribution agreement. Thanks Nariman On Mon, 26 Nov 2018 at 14:11, Gao, Liming <liming.gao@intel.com> wrote: > Could you add [edk2-platform] in the title? So, I know this change is for > edk2-platform repo. > > And, please add Contributed-under: TianoCore Contribution Agreement 1.1 > before Signed-off-by. > > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Nariman Poushin > > Sent: Monday, November 26, 2018 9:11 PM > > To: edk2-devel@lists.01.org > > Subject: [edk2] [PATCH 1/2] Readme.md: Update instructions to fetch > source > > > > Openssl is fetched as a git submodule, so make sure git clone --recursive > > is specified in the instructions to fetch a full source tree. > > > > Signed-off-by: Nariman Poushin <nariman.poushin@linaro.org> > > --- > > Readme.md | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Readme.md b/Readme.md > > index 6ad5953..bb53c6f 100644 > > --- a/Readme.md > > +++ b/Readme.md > > @@ -78,7 +78,7 @@ target-specific binutils. These are included with any > prepackaged GCC toolchain > > 1. [edk2-non-osi](https://github.com/tianocore/edk2-non-osi) (if > building > > platforms that need it) > > ``` > > - $ git clone https://github.com/tianocore/edk2.git > > + $ git clone https://github.com/tianocore/edk2.git --recursive > > ... > > $ git clone https://github.com/tianocore/edk2-platforms.git > > ... > > -- > > 2.7.4 > > > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
On Mon, Nov 26, 2018 at 01:10:53PM +0000, Nariman Poushin wrote: > Openssl is fetched as a git submodule, so make sure git clone --recursive > is specified in the instructions to fetch a full source tree. Can you add a Contributed-under: TianoCore Contribution Agreement 1.1 tag for all patches contributed to TianoCore? Preferably before the Signed-off-by. Other than that, this patch is good, thanks! > Signed-off-by: Nariman Poushin <nariman.poushin@linaro.org> > > --- > Readme.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Readme.md b/Readme.md > index 6ad5953..bb53c6f 100644 > --- a/Readme.md > +++ b/Readme.md > @@ -78,7 +78,7 @@ target-specific binutils. These are included with any prepackaged GCC toolchain > 1. [edk2-non-osi](https://github.com/tianocore/edk2-non-osi) (if building > platforms that need it) > ``` > - $ git clone https://github.com/tianocore/edk2.git > + $ git clone https://github.com/tianocore/edk2.git --recursive > ... > $ git clone https://github.com/tianocore/edk2-platforms.git > ... > -- > 2.7.4 > > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
diff --git a/Readme.md b/Readme.md index 6ad5953..bb53c6f 100644 --- a/Readme.md +++ b/Readme.md @@ -78,7 +78,7 @@ target-specific binutils. These are included with any prepackaged GCC toolchain 1. [edk2-non-osi](https://github.com/tianocore/edk2-non-osi) (if building platforms that need it) ``` - $ git clone https://github.com/tianocore/edk2.git + $ git clone https://github.com/tianocore/edk2.git --recursive ... $ git clone https://github.com/tianocore/edk2-platforms.git ...
Openssl is fetched as a git submodule, so make sure git clone --recursive is specified in the instructions to fetch a full source tree. Signed-off-by: Nariman Poushin <nariman.poushin@linaro.org> --- Readme.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel