mbox series

[v3,0/5] ASoC: qdsp6: add compress offload support

Message ID 20181115181324.26784-1-srinivas.kandagatla@linaro.org
Headers show
Series ASoC: qdsp6: add compress offload support | expand

Message

Srinivas Kandagatla Nov. 15, 2018, 6:13 p.m. UTC 
This patchset adds support to very basic MP3 playback compress offload
support via QDSP ASM module.

Tested this patchset on DB410c with APQ8016 and DB820c with APQ8096 using
tinycompress library.

Adding other codec support should be trivial w.r.t qdsp6 side, however
there are other dependencies like compress UAPI header changes and
FastRPC which are being worked in parallel. Once ready will post them!

thanks,
srini

Changes since v2 (//lkml.org/lkml/2018/9/26/461):
- Removed some unnecessary empty line adds.
- Added more info to snd_compr_set_runtime_buffer() commit message

Srinivas Kandagatla (5):
  ALSA: soc-compress: add support to snd_compr_set_runtime_buffer()
  ALSA: compress: make use of runtime buffer for copy
  ASoC: q6asm-dai: dt-bindings: Add support to compress dais
  ASoC: qdsp6: q6asm: add support to MP3 format
  ASoC: qdsp6: q6asm-dai: Add support to compress offload

 .../devicetree/bindings/sound/qcom,q6asm.txt  |  27 ++
 include/sound/compress_driver.h               |  19 +
 sound/core/compress_offload.c                 |  18 +-
 sound/soc/qcom/Kconfig                        |   1 +
 sound/soc/qcom/qdsp6/q6asm-dai.c              | 372 +++++++++++++++++-
 sound/soc/qcom/qdsp6/q6asm.c                  |   5 +
 6 files changed, 438 insertions(+), 4 deletions(-)

-- 
2.19.1

Comments

Srinivas Kandagatla Nov. 16, 2018, 9:21 a.m. UTC | #1 
Thanks for your comments!

On 16/11/18 07:18, Daniel Baluta wrote:
> One minor comment:

> 

> <snip>

> 

>>          struct snd_compr_ops *ops;

>> +       struct snd_dma_buffer *dma_buffer_p;

> I don't think it is necessary to encode the type inside the name variable

> So, dma_buffer would sounds better to me then dma_buffer_p;

> 

>>          void *buffer;

> It is also consistent with this ^

> 

> <snip>

>> +static inline void snd_compr_set_runtime_buffer(

>> +                                       struct snd_compr_stream *substream,

>> +                                       struct snd_dma_buffer *bufp)

> Also buf instead of bufp here.


TBH, I followed what ./include/sound/pcm.h does!

--srini
Vinod Koul Nov. 30, 2018, 12:22 p.m. UTC | #2 
On 15-11-18, 18:13, Srinivas Kandagatla wrote:
> This patchset adds support to very basic MP3 playback compress offload

> support via QDSP ASM module.

> 

> Tested this patchset on DB410c with APQ8016 and DB820c with APQ8096 using

> tinycompress library.

> 

> Adding other codec support should be trivial w.r.t qdsp6 side, however

> there are other dependencies like compress UAPI header changes and

> FastRPC which are being worked in parallel. Once ready will post them!


Thanks Srini, with this we will have compress support upstream for a
public board.

Acked-by: Vinod Koul <vkoul@kernel.org>


-- 
~Vinod