| Message ID | 1541990120-9643-3-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| State | Accepted |
| Commit | 63fea0af43af5beb3779fd2cae078d5d77b4bb11 |
| Headers | show |
| Series | Remove -fno-unit-at-a-time and -funit-at-a-time compiler flags entirely | expand |
* Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > GCC 4.6 manual says: > > -funit-at-a-time > This option is left for compatibility reasons. -funit-at-a-time has > no effect, while -fno-unit-at-a-time implies -fno-toplevel-reorder > and -fno-section-anchors. > Enabled by default. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > arch/powerpc/Makefile | 4 ---- > arch/x86/Makefile | 4 ---- > arch/x86/Makefile.um | 5 ----- > 3 files changed, 13 deletions(-) > > diff --git a/arch/x86/Makefile b/arch/x86/Makefile > index 88398fd..3508049 100644 > --- a/arch/x86/Makefile > +++ b/arch/x86/Makefile > @@ -130,10 +130,6 @@ else > > KBUILD_CFLAGS += -mno-red-zone > KBUILD_CFLAGS += -mcmodel=kernel > - > - # -funit-at-a-time shrinks the kernel .text considerably > - # unfortunately it makes reading oopses harder. > - KBUILD_CFLAGS += $(call cc-option,-funit-at-a-time) > endif > > ifdef CONFIG_X86_X32 > diff --git a/arch/x86/Makefile.um b/arch/x86/Makefile.um > index 577976b..1db7913 100644 > --- a/arch/x86/Makefile.um > +++ b/arch/x86/Makefile.um > @@ -26,9 +26,6 @@ cflags-y += $(call cc-option,-mpreferred-stack-boundary=2) > # an unresolved reference. > cflags-y += -ffreestanding > > -# gcc 4.3.0 needs -funit-at-a-time for extern inline functions. > -KBUILD_CFLAGS += $(call cc-option,-funit-at-a-time) > - > KBUILD_CFLAGS += $(cflags-y) > > else > @@ -50,6 +47,4 @@ ELF_FORMAT := elf64-x86-64 > LINK-$(CONFIG_LD_SCRIPT_DYN) += -Wl,-rpath,/lib64 > LINK-y += -m64 > > -# Do unit-at-a-time unconditionally on x86_64, following the host > -KBUILD_CFLAGS += $(call cc-option,-funit-at-a-time) > endif Acked-by: Ingo Molnar <mingo@kernel.org> Thanks, Ingo
Masahiro Yamada <yamada.masahiro@socionext.com> writes: > GCC 4.6 manual says: > > -funit-at-a-time > This option is left for compatibility reasons. -funit-at-a-time has > no effect, while -fno-unit-at-a-time implies -fno-toplevel-reorder > and -fno-section-anchors. > Enabled by default. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > arch/powerpc/Makefile | 4 ---- > arch/x86/Makefile | 4 ---- > arch/x86/Makefile.um | 5 ----- > 3 files changed, 13 deletions(-) > > diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile > index 8a2ce14..854199c 100644 > --- a/arch/powerpc/Makefile > +++ b/arch/powerpc/Makefile > @@ -228,10 +228,6 @@ KBUILD_CFLAGS += $(call cc-option,-mno-vsx) > KBUILD_CFLAGS += $(call cc-option,-mno-spe) > KBUILD_CFLAGS += $(call cc-option,-mspe=no) > > -# Enable unit-at-a-time mode when possible. It shrinks the > -# kernel considerably. > -KBUILD_CFLAGS += $(call cc-option,-funit-at-a-time) > - Thanks for cleaning it up. Acked-by: Michael Ellerman <mpe@ellerman.id.au> cheers
x86 maintainers, Ping. On Mon, Nov 12, 2018 at 8:23 PM Michael Ellerman <mpe@ellerman.id.au> wrote: > > Masahiro Yamada <yamada.masahiro@socionext.com> writes: > > > GCC 4.6 manual says: > > > > -funit-at-a-time > > This option is left for compatibility reasons. -funit-at-a-time has > > no effect, while -fno-unit-at-a-time implies -fno-toplevel-reorder > > and -fno-section-anchors. > > Enabled by default. > > > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > --- > > > > arch/powerpc/Makefile | 4 ---- > > arch/x86/Makefile | 4 ---- > > arch/x86/Makefile.um | 5 ----- > > 3 files changed, 13 deletions(-) > > > > diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile > > index 8a2ce14..854199c 100644 > > --- a/arch/powerpc/Makefile > > +++ b/arch/powerpc/Makefile > > @@ -228,10 +228,6 @@ KBUILD_CFLAGS += $(call cc-option,-mno-vsx) > > KBUILD_CFLAGS += $(call cc-option,-mno-spe) > > KBUILD_CFLAGS += $(call cc-option,-mspe=no) > > > > -# Enable unit-at-a-time mode when possible. It shrinks the > > -# kernel considerably. > > -KBUILD_CFLAGS += $(call cc-option,-funit-at-a-time) > > - > > Thanks for cleaning it up. > > Acked-by: Michael Ellerman <mpe@ellerman.id.au> > > cheers -- Best Regards Masahiro Yamada
On Sat, Dec 08, 2018 at 03:36:52PM +0900, Masahiro Yamada wrote: > x86 maintainers, > > Ping. You got the required ACKs. If you want me to carry this one and the UML one through the tip tree, lemme know. Or you can do what Richard suggested. Your call. Thx. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.
Hi Borislav, On Sat, Dec 8, 2018 at 8:34 PM Borislav Petkov <bp@alien8.de> wrote: > > On Sat, Dec 08, 2018 at 03:36:52PM +0900, Masahiro Yamada wrote: > > x86 maintainers, > > > > Ping. > > You got the required ACKs. If you want me to carry this one and the > UML one through the tip tree, lemme know. Or you can do what Richard > suggested. Your call. Thank you for your help. I expect both applied through the tip bot. Thanks. > Thx. > > -- > Regards/Gruss, > Boris. > > Good mailing practices for 400: avoid top-posting and trim the reply. -- Best Regards Masahiro Yamada
diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile index 8a2ce14..854199c 100644 --- a/arch/powerpc/Makefile +++ b/arch/powerpc/Makefile @@ -228,10 +228,6 @@ KBUILD_CFLAGS += $(call cc-option,-mno-vsx) KBUILD_CFLAGS += $(call cc-option,-mno-spe) KBUILD_CFLAGS += $(call cc-option,-mspe=no) -# Enable unit-at-a-time mode when possible. It shrinks the -# kernel considerably. -KBUILD_CFLAGS += $(call cc-option,-funit-at-a-time) - # FIXME: the module load should be taught about the additional relocs # generated by this. # revert to pre-gcc-4.4 behaviour of .eh_frame diff --git a/arch/x86/Makefile b/arch/x86/Makefile index 88398fd..3508049 100644 --- a/arch/x86/Makefile +++ b/arch/x86/Makefile @@ -130,10 +130,6 @@ else KBUILD_CFLAGS += -mno-red-zone KBUILD_CFLAGS += -mcmodel=kernel - - # -funit-at-a-time shrinks the kernel .text considerably - # unfortunately it makes reading oopses harder. - KBUILD_CFLAGS += $(call cc-option,-funit-at-a-time) endif ifdef CONFIG_X86_X32 diff --git a/arch/x86/Makefile.um b/arch/x86/Makefile.um index 577976b..1db7913 100644 --- a/arch/x86/Makefile.um +++ b/arch/x86/Makefile.um @@ -26,9 +26,6 @@ cflags-y += $(call cc-option,-mpreferred-stack-boundary=2) # an unresolved reference. cflags-y += -ffreestanding -# gcc 4.3.0 needs -funit-at-a-time for extern inline functions. -KBUILD_CFLAGS += $(call cc-option,-funit-at-a-time) - KBUILD_CFLAGS += $(cflags-y) else @@ -50,6 +47,4 @@ ELF_FORMAT := elf64-x86-64 LINK-$(CONFIG_LD_SCRIPT_DYN) += -Wl,-rpath,/lib64 LINK-y += -m64 -# Do unit-at-a-time unconditionally on x86_64, following the host -KBUILD_CFLAGS += $(call cc-option,-funit-at-a-time) endif
GCC 4.6 manual says: -funit-at-a-time This option is left for compatibility reasons. -funit-at-a-time has no effect, while -fno-unit-at-a-time implies -fno-toplevel-reorder and -fno-section-anchors. Enabled by default. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- arch/powerpc/Makefile | 4 ---- arch/x86/Makefile | 4 ---- arch/x86/Makefile.um | 5 ----- 3 files changed, 13 deletions(-) -- 2.7.4