| Message ID | 1541990120-9643-2-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| State | Accepted |
| Commit | 829889ac4a7d26858860c297e64051bd27ce8fbe |
| Headers | show |
| Series | Remove -fno-unit-at-a-time and -funit-at-a-time compiler flags entirely | expand |
Am Montag, 12. November 2018, 03:35:19 CET schrieb Masahiro Yamada: > Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") > bumped the minimum GCC version to 4.6 for all architectures. > > '$(call cc-option,-fno-unit-at-a-time)' is now dead code since > '$(cc-version) -lt 0400' is always false. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > arch/x86/Makefile.um | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/arch/x86/Makefile.um b/arch/x86/Makefile.um > index 91085a0..577976b 100644 > --- a/arch/x86/Makefile.um > +++ b/arch/x86/Makefile.um > @@ -26,12 +26,8 @@ cflags-y += $(call cc-option,-mpreferred-stack-boundary=2) > # an unresolved reference. > cflags-y += -ffreestanding > > -# Disable unit-at-a-time mode on pre-gcc-4.0 compilers, it makes gcc use > -# a lot more stack due to the lack of sharing of stacklots. Also, gcc > -# 4.3.0 needs -funit-at-a-time for extern inline functions. > -KBUILD_CFLAGS += $(shell if [ $(cc-version) -lt 0400 ] ; then \ > - echo $(call cc-option,-fno-unit-at-a-time); \ > - else echo $(call cc-option,-funit-at-a-time); fi ;) > +# gcc 4.3.0 needs -funit-at-a-time for extern inline functions. > +KBUILD_CFLAGS += $(call cc-option,-funit-at-a-time) Acked-by: Richard Weinberger <richard@nod.at> Thanks, //richard
x86 maintainers, Ping. On Tue, Nov 13, 2018 at 6:48 PM Richard Weinberger <richard@nod.at> wrote: > > Am Montag, 12. November 2018, 03:35:19 CET schrieb Masahiro Yamada: > > Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") > > bumped the minimum GCC version to 4.6 for all architectures. > > > > '$(call cc-option,-fno-unit-at-a-time)' is now dead code since > > '$(cc-version) -lt 0400' is always false. > > > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > --- > > > > arch/x86/Makefile.um | 8 ++------ > > 1 file changed, 2 insertions(+), 6 deletions(-) > > > > diff --git a/arch/x86/Makefile.um b/arch/x86/Makefile.um > > index 91085a0..577976b 100644 > > --- a/arch/x86/Makefile.um > > +++ b/arch/x86/Makefile.um > > @@ -26,12 +26,8 @@ cflags-y += $(call cc-option,-mpreferred-stack-boundary=2) > > # an unresolved reference. > > cflags-y += -ffreestanding > > > > -# Disable unit-at-a-time mode on pre-gcc-4.0 compilers, it makes gcc use > > -# a lot more stack due to the lack of sharing of stacklots. Also, gcc > > -# 4.3.0 needs -funit-at-a-time for extern inline functions. > > -KBUILD_CFLAGS += $(shell if [ $(cc-version) -lt 0400 ] ; then \ > > - echo $(call cc-option,-fno-unit-at-a-time); \ > > - else echo $(call cc-option,-funit-at-a-time); fi ;) > > +# gcc 4.3.0 needs -funit-at-a-time for extern inline functions. > > +KBUILD_CFLAGS += $(call cc-option,-funit-at-a-time) > > Acked-by: Richard Weinberger <richard@nod.at> > > Thanks, > //richard > > > -- Best Regards Masahiro Yamada
Am Samstag, 8. Dezember 2018, 07:35:47 CET schrieb Masahiro Yamada: > x86 maintainers, > > > Ping. I thought you carry this via your kbuild tree. That said, I can merge it also via the um tree. x86 is of course also fine. :-) > > > On Tue, Nov 13, 2018 at 6:48 PM Richard Weinberger <richard@nod.at> wrote: > > > > Am Montag, 12. November 2018, 03:35:19 CET schrieb Masahiro Yamada: > > > Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") > > > bumped the minimum GCC version to 4.6 for all architectures. > > > > > > '$(call cc-option,-fno-unit-at-a-time)' is now dead code since > > > '$(cc-version) -lt 0400' is always false. > > > > > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > > --- > > > > > > arch/x86/Makefile.um | 8 ++------ > > > 1 file changed, 2 insertions(+), 6 deletions(-) > > > > > > diff --git a/arch/x86/Makefile.um b/arch/x86/Makefile.um > > > index 91085a0..577976b 100644 > > > --- a/arch/x86/Makefile.um > > > +++ b/arch/x86/Makefile.um > > > @@ -26,12 +26,8 @@ cflags-y += $(call cc-option,-mpreferred-stack-boundary=2) > > > # an unresolved reference. > > > cflags-y += -ffreestanding > > > > > > -# Disable unit-at-a-time mode on pre-gcc-4.0 compilers, it makes gcc use > > > -# a lot more stack due to the lack of sharing of stacklots. Also, gcc > > > -# 4.3.0 needs -funit-at-a-time for extern inline functions. > > > -KBUILD_CFLAGS += $(shell if [ $(cc-version) -lt 0400 ] ; then \ > > > - echo $(call cc-option,-fno-unit-at-a-time); \ > > > - else echo $(call cc-option,-funit-at-a-time); fi ;) > > > +# gcc 4.3.0 needs -funit-at-a-time for extern inline functions. > > > +KBUILD_CFLAGS += $(call cc-option,-funit-at-a-time) > > > > Acked-by: Richard Weinberger <richard@nod.at> Thanks, //richard
Hi Richard, On Sat, Dec 8, 2018 at 5:55 PM Richard Weinberger <richard@nod.at> wrote: > > Am Samstag, 8. Dezember 2018, 07:35:47 CET schrieb Masahiro Yamada: > > x86 maintainers, > > > > > > Ping. > > I thought you carry this via your kbuild tree. > That said, I can merge it also via the um tree. > x86 is of course also fine. :-) The second patch also touches x86 Makefiles. So, I think both should be applied to x86 tree. Thanks. > > > > > > On Tue, Nov 13, 2018 at 6:48 PM Richard Weinberger <richard@nod.at> wrote: > > > > > > Am Montag, 12. November 2018, 03:35:19 CET schrieb Masahiro Yamada: > > > > Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") > > > > bumped the minimum GCC version to 4.6 for all architectures. > > > > > > > > '$(call cc-option,-fno-unit-at-a-time)' is now dead code since > > > > '$(cc-version) -lt 0400' is always false. > > > > > > > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > > > --- > > > > > > > > arch/x86/Makefile.um | 8 ++------ > > > > 1 file changed, 2 insertions(+), 6 deletions(-) > > > > > > > > diff --git a/arch/x86/Makefile.um b/arch/x86/Makefile.um > > > > index 91085a0..577976b 100644 > > > > --- a/arch/x86/Makefile.um > > > > +++ b/arch/x86/Makefile.um > > > > @@ -26,12 +26,8 @@ cflags-y += $(call cc-option,-mpreferred-stack-boundary=2) > > > > # an unresolved reference. > > > > cflags-y += -ffreestanding > > > > > > > > -# Disable unit-at-a-time mode on pre-gcc-4.0 compilers, it makes gcc use > > > > -# a lot more stack due to the lack of sharing of stacklots. Also, gcc > > > > -# 4.3.0 needs -funit-at-a-time for extern inline functions. > > > > -KBUILD_CFLAGS += $(shell if [ $(cc-version) -lt 0400 ] ; then \ > > > > - echo $(call cc-option,-fno-unit-at-a-time); \ > > > > - else echo $(call cc-option,-funit-at-a-time); fi ;) > > > > +# gcc 4.3.0 needs -funit-at-a-time for extern inline functions. > > > > +KBUILD_CFLAGS += $(call cc-option,-funit-at-a-time) > > > > > > Acked-by: Richard Weinberger <richard@nod.at> > > Thanks, > //richard > > -- Best Regards Masahiro Yamada
diff --git a/arch/x86/Makefile.um b/arch/x86/Makefile.um index 91085a0..577976b 100644 --- a/arch/x86/Makefile.um +++ b/arch/x86/Makefile.um @@ -26,12 +26,8 @@ cflags-y += $(call cc-option,-mpreferred-stack-boundary=2) # an unresolved reference. cflags-y += -ffreestanding -# Disable unit-at-a-time mode on pre-gcc-4.0 compilers, it makes gcc use -# a lot more stack due to the lack of sharing of stacklots. Also, gcc -# 4.3.0 needs -funit-at-a-time for extern inline functions. -KBUILD_CFLAGS += $(shell if [ $(cc-version) -lt 0400 ] ; then \ - echo $(call cc-option,-fno-unit-at-a-time); \ - else echo $(call cc-option,-funit-at-a-time); fi ;) +# gcc 4.3.0 needs -funit-at-a-time for extern inline functions. +KBUILD_CFLAGS += $(call cc-option,-funit-at-a-time) KBUILD_CFLAGS += $(cflags-y)
Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") bumped the minimum GCC version to 4.6 for all architectures. '$(call cc-option,-fno-unit-at-a-time)' is now dead code since '$(cc-version) -lt 0400' is always false. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- arch/x86/Makefile.um | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) -- 2.7.4