Message ID | 20190116212221.7460-2-ard.biesheuvel@linaro.org |
---|---|
State | Accepted |
Commit | 2c010aba2252183a410a5087d949e9b4e1724796 |
Headers | show |
Series | Various Packages: add MM_STANDALONE support | expand |
Reviewed-by: Jian J Wang <jian.j.wang@intel.com> > -----Original Message----- > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > Sent: Thursday, January 17, 2019 5:22 AM > To: edk2-devel@lists.01.org > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Kinney, Michael D > <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Ye, Ting > <ting.ye@intel.com>; Wei, Gang <gang.wei@intel.com>; Wang, Jian J > <jian.j.wang@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>; Yao, > Jiewen <jiewen.yao@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Zeng, Star > <star.zeng@intel.com>; Achin Gupta <achin.gupta@arm.com>; Jagadeesh Ujja > <jagadeesh.ujja@arm.com> > Subject: [PATCH 1/4] CryptoPkg/SmmCryptLib: permit use by MM_STANDALONE > modules > > Permit SmmCryptLib to be used by MM_STANDALONE modules > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > --- > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > index c34699cd62bf..a681fe2f36b8 100644 > --- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > +++ b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > @@ -30,7 +30,7 @@ [Defines] > MODULE_TYPE = DXE_SMM_DRIVER > VERSION_STRING = 1.0 > PI_SPECIFICATION_VERSION = 0x0001000A > - LIBRARY_CLASS = BaseCryptLib|DXE_SMM_DRIVER SMM_CORE > + LIBRARY_CLASS = BaseCryptLib|DXE_SMM_DRIVER SMM_CORE > MM_STANDALONE > > # > # The following information is for reference only and not required by the build > tools. > -- > 2.17.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
On Fri, 18 Jan 2019 at 08:08, Wang, Jian J <jian.j.wang@intel.com> wrote: > > > > Reviewed-by: Jian J Wang <jian.j.wang@intel.com> > Ting, do you have any objections to this patch? > > > -----Original Message----- > > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > > Sent: Thursday, January 17, 2019 5:22 AM > > To: edk2-devel@lists.01.org > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Kinney, Michael D > > <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Ye, Ting > > <ting.ye@intel.com>; Wei, Gang <gang.wei@intel.com>; Wang, Jian J > > <jian.j.wang@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>; Yao, > > Jiewen <jiewen.yao@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Zeng, Star > > <star.zeng@intel.com>; Achin Gupta <achin.gupta@arm.com>; Jagadeesh Ujja > > <jagadeesh.ujja@arm.com> > > Subject: [PATCH 1/4] CryptoPkg/SmmCryptLib: permit use by MM_STANDALONE > > modules > > > > Permit SmmCryptLib to be used by MM_STANDALONE modules > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > --- > > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > index c34699cd62bf..a681fe2f36b8 100644 > > --- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > +++ b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > @@ -30,7 +30,7 @@ [Defines] > > MODULE_TYPE = DXE_SMM_DRIVER > > VERSION_STRING = 1.0 > > PI_SPECIFICATION_VERSION = 0x0001000A > > - LIBRARY_CLASS = BaseCryptLib|DXE_SMM_DRIVER SMM_CORE > > + LIBRARY_CLASS = BaseCryptLib|DXE_SMM_DRIVER SMM_CORE > > MM_STANDALONE > > > > # > > # The following information is for reference only and not required by the build > > tools. > > -- > > 2.17.1 > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
On Fri, 18 Jan 2019 at 12:12, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote: > > On Fri, 18 Jan 2019 at 08:08, Wang, Jian J <jian.j.wang@intel.com> wrote: > > > > > > > > Reviewed-by: Jian J Wang <jian.j.wang@intel.com> > > > > Ting, do you have any objections to this patch? > Ping? > > > > > -----Original Message----- > > > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > > > Sent: Thursday, January 17, 2019 5:22 AM > > > To: edk2-devel@lists.01.org > > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Kinney, Michael D > > > <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Ye, Ting > > > <ting.ye@intel.com>; Wei, Gang <gang.wei@intel.com>; Wang, Jian J > > > <jian.j.wang@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>; Yao, > > > Jiewen <jiewen.yao@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Zeng, Star > > > <star.zeng@intel.com>; Achin Gupta <achin.gupta@arm.com>; Jagadeesh Ujja > > > <jagadeesh.ujja@arm.com> > > > Subject: [PATCH 1/4] CryptoPkg/SmmCryptLib: permit use by MM_STANDALONE > > > modules > > > > > > Permit SmmCryptLib to be used by MM_STANDALONE modules > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > > --- > > > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > > b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > > index c34699cd62bf..a681fe2f36b8 100644 > > > --- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > > +++ b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > > @@ -30,7 +30,7 @@ [Defines] > > > MODULE_TYPE = DXE_SMM_DRIVER > > > VERSION_STRING = 1.0 > > > PI_SPECIFICATION_VERSION = 0x0001000A > > > - LIBRARY_CLASS = BaseCryptLib|DXE_SMM_DRIVER SMM_CORE > > > + LIBRARY_CLASS = BaseCryptLib|DXE_SMM_DRIVER SMM_CORE > > > MM_STANDALONE > > > > > > # > > > # The following information is for reference only and not required by the build > > > tools. > > > -- > > > 2.17.1 > > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Ard: Wang, Jian is the reviewer of CryptoPkg. I think that his review-by is enough. Thanks Liming > -----Original Message----- > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > Sent: Monday, January 21, 2019 8:36 PM > To: Wang, Jian J <jian.j.wang@intel.com>; Ye, Ting <ting.ye@intel.com> > Cc: edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Wei, Gang > <gang.wei@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Wu, Hao A > <hao.a.wu@intel.com>; Zeng, Star <star.zeng@intel.com>; Achin Gupta <achin.gupta@arm.com>; Jagadeesh Ujja > <jagadeesh.ujja@arm.com> > Subject: Re: [PATCH 1/4] CryptoPkg/SmmCryptLib: permit use by MM_STANDALONE modules > > On Fri, 18 Jan 2019 at 12:12, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote: > > > > On Fri, 18 Jan 2019 at 08:08, Wang, Jian J <jian.j.wang@intel.com> wrote: > > > > > > > > > > > > Reviewed-by: Jian J Wang <jian.j.wang@intel.com> > > > > > > > Ting, do you have any objections to this patch? > > > > Ping? > > > > > > > > > > -----Original Message----- > > > > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > > > > Sent: Thursday, January 17, 2019 5:22 AM > > > > To: edk2-devel@lists.01.org > > > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Kinney, Michael D > > > > <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Ye, Ting > > > > <ting.ye@intel.com>; Wei, Gang <gang.wei@intel.com>; Wang, Jian J > > > > <jian.j.wang@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>; Yao, > > > > Jiewen <jiewen.yao@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Zeng, Star > > > > <star.zeng@intel.com>; Achin Gupta <achin.gupta@arm.com>; Jagadeesh Ujja > > > > <jagadeesh.ujja@arm.com> > > > > Subject: [PATCH 1/4] CryptoPkg/SmmCryptLib: permit use by MM_STANDALONE > > > > modules > > > > > > > > Permit SmmCryptLib to be used by MM_STANDALONE modules > > > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > > > --- > > > > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > > > b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > > > index c34699cd62bf..a681fe2f36b8 100644 > > > > --- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > > > +++ b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > > > @@ -30,7 +30,7 @@ [Defines] > > > > MODULE_TYPE = DXE_SMM_DRIVER > > > > VERSION_STRING = 1.0 > > > > PI_SPECIFICATION_VERSION = 0x0001000A > > > > - LIBRARY_CLASS = BaseCryptLib|DXE_SMM_DRIVER SMM_CORE > > > > + LIBRARY_CLASS = BaseCryptLib|DXE_SMM_DRIVER SMM_CORE > > > > MM_STANDALONE > > > > > > > > # > > > > # The following information is for reference only and not required by the build > > > > tools. > > > > -- > > > > 2.17.1 > > > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
On Mon, 21 Jan 2019 at 13:40, Gao, Liming <liming.gao@intel.com> wrote: > > Ard: > Wang, Jian is the reviewer of CryptoPkg. I think that his review-by is enough. > OK, thanks! > Thanks > Liming > > -----Original Message----- > > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > > Sent: Monday, January 21, 2019 8:36 PM > > To: Wang, Jian J <jian.j.wang@intel.com>; Ye, Ting <ting.ye@intel.com> > > Cc: edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Wei, Gang > > <gang.wei@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Wu, Hao A > > <hao.a.wu@intel.com>; Zeng, Star <star.zeng@intel.com>; Achin Gupta <achin.gupta@arm.com>; Jagadeesh Ujja > > <jagadeesh.ujja@arm.com> > > Subject: Re: [PATCH 1/4] CryptoPkg/SmmCryptLib: permit use by MM_STANDALONE modules > > > > On Fri, 18 Jan 2019 at 12:12, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote: > > > > > > On Fri, 18 Jan 2019 at 08:08, Wang, Jian J <jian.j.wang@intel.com> wrote: > > > > > > > > > > > > > > > > Reviewed-by: Jian J Wang <jian.j.wang@intel.com> > > > > > > > > > > Ting, do you have any objections to this patch? > > > > > > > Ping? > > > > > > > > > > > > > > > -----Original Message----- > > > > > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > > > > > Sent: Thursday, January 17, 2019 5:22 AM > > > > > To: edk2-devel@lists.01.org > > > > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Kinney, Michael D > > > > > <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Ye, Ting > > > > > <ting.ye@intel.com>; Wei, Gang <gang.wei@intel.com>; Wang, Jian J > > > > > <jian.j.wang@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>; Yao, > > > > > Jiewen <jiewen.yao@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Zeng, Star > > > > > <star.zeng@intel.com>; Achin Gupta <achin.gupta@arm.com>; Jagadeesh Ujja > > > > > <jagadeesh.ujja@arm.com> > > > > > Subject: [PATCH 1/4] CryptoPkg/SmmCryptLib: permit use by MM_STANDALONE > > > > > modules > > > > > > > > > > Permit SmmCryptLib to be used by MM_STANDALONE modules > > > > > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > > > > --- > > > > > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > > > > b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > > > > index c34699cd62bf..a681fe2f36b8 100644 > > > > > --- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > > > > +++ b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > > > > @@ -30,7 +30,7 @@ [Defines] > > > > > MODULE_TYPE = DXE_SMM_DRIVER > > > > > VERSION_STRING = 1.0 > > > > > PI_SPECIFICATION_VERSION = 0x0001000A > > > > > - LIBRARY_CLASS = BaseCryptLib|DXE_SMM_DRIVER SMM_CORE > > > > > + LIBRARY_CLASS = BaseCryptLib|DXE_SMM_DRIVER SMM_CORE > > > > > MM_STANDALONE > > > > > > > > > > # > > > > > # The following information is for reference only and not required by the build > > > > > tools. > > > > > -- > > > > > 2.17.1 > > > > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Yes. No objections from me. Sorry for missed the previous mail. Thanks, Ting -----Original Message----- From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] Sent: Monday, January 21, 2019 8:41 PM To: Gao, Liming <liming.gao@intel.com> Cc: Wang, Jian J <jian.j.wang@intel.com>; Ye, Ting <ting.ye@intel.com>; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kinney@intel.com>; Wei, Gang <gang.wei@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Zeng, Star <star.zeng@intel.com>; Achin Gupta <achin.gupta@arm.com>; Jagadeesh Ujja <jagadeesh.ujja@arm.com> Subject: Re: [PATCH 1/4] CryptoPkg/SmmCryptLib: permit use by MM_STANDALONE modules On Mon, 21 Jan 2019 at 13:40, Gao, Liming <liming.gao@intel.com> wrote: > > Ard: > Wang, Jian is the reviewer of CryptoPkg. I think that his review-by is enough. > OK, thanks! > Thanks > Liming > > -----Original Message----- > > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > > Sent: Monday, January 21, 2019 8:36 PM > > To: Wang, Jian J <jian.j.wang@intel.com>; Ye, Ting > > <ting.ye@intel.com> > > Cc: edk2-devel@lists.01.org; Kinney, Michael D > > <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; > > Wei, Gang <gang.wei@intel.com>; Zhang, Chao B > > <chao.b.zhang@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Wu, > > Hao A <hao.a.wu@intel.com>; Zeng, Star <star.zeng@intel.com>; Achin > > Gupta <achin.gupta@arm.com>; Jagadeesh Ujja <jagadeesh.ujja@arm.com> > > Subject: Re: [PATCH 1/4] CryptoPkg/SmmCryptLib: permit use by > > MM_STANDALONE modules > > > > On Fri, 18 Jan 2019 at 12:12, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote: > > > > > > On Fri, 18 Jan 2019 at 08:08, Wang, Jian J <jian.j.wang@intel.com> wrote: > > > > > > > > > > > > > > > > Reviewed-by: Jian J Wang <jian.j.wang@intel.com> > > > > > > > > > > Ting, do you have any objections to this patch? > > > > > > > Ping? > > > > > > > > > > > > > > > -----Original Message----- > > > > > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > > > > > Sent: Thursday, January 17, 2019 5:22 AM > > > > > To: edk2-devel@lists.01.org > > > > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Kinney, > > > > > Michael D <michael.d.kinney@intel.com>; Gao, Liming > > > > > <liming.gao@intel.com>; Ye, Ting <ting.ye@intel.com>; Wei, > > > > > Gang <gang.wei@intel.com>; Wang, Jian J > > > > > <jian.j.wang@intel.com>; Zhang, Chao B > > > > > <chao.b.zhang@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; > > > > > Wu, Hao A <hao.a.wu@intel.com>; Zeng, Star > > > > > <star.zeng@intel.com>; Achin Gupta <achin.gupta@arm.com>; > > > > > Jagadeesh Ujja <jagadeesh.ujja@arm.com> > > > > > Subject: [PATCH 1/4] CryptoPkg/SmmCryptLib: permit use by > > > > > MM_STANDALONE modules > > > > > > > > > > Permit SmmCryptLib to be used by MM_STANDALONE modules > > > > > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > > > > --- > > > > > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > > > > b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > > > > index c34699cd62bf..a681fe2f36b8 100644 > > > > > --- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > > > > +++ b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > > > > @@ -30,7 +30,7 @@ [Defines] > > > > > MODULE_TYPE = DXE_SMM_DRIVER > > > > > VERSION_STRING = 1.0 > > > > > PI_SPECIFICATION_VERSION = 0x0001000A > > > > > - LIBRARY_CLASS = BaseCryptLib|DXE_SMM_DRIVER SMM_CORE > > > > > + LIBRARY_CLASS = BaseCryptLib|DXE_SMM_DRIVER SMM_CORE > > > > > MM_STANDALONE > > > > > > > > > > # > > > > > # The following information is for reference only and not > > > > > required by the build tools. > > > > > -- > > > > > 2.17.1 > > > > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf index c34699cd62bf..a681fe2f36b8 100644 --- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf +++ b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf @@ -30,7 +30,7 @@ [Defines] MODULE_TYPE = DXE_SMM_DRIVER VERSION_STRING = 1.0 PI_SPECIFICATION_VERSION = 0x0001000A - LIBRARY_CLASS = BaseCryptLib|DXE_SMM_DRIVER SMM_CORE + LIBRARY_CLASS = BaseCryptLib|DXE_SMM_DRIVER SMM_CORE MM_STANDALONE # # The following information is for reference only and not required by the build tools.
Permit SmmCryptLib to be used by MM_STANDALONE modules Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> --- CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel