mbox series

[edk2,0/4] Various Packages: add MM_STANDALONE support

Message ID 20190116212221.7460-1-ard.biesheuvel@linaro.org
Headers show
Series Various Packages: add MM_STANDALONE support | expand

Message

Ard Biesheuvel Jan. 16, 2019, 9:22 p.m. UTC
Add MM_STANDALONE to the list of permitted module types of various
libraries that are required to build the standalone MM authenticated
variable stack.

In some cases, this requires the MODULE_TYPE to be modified to BASE,
given that the constructor prototype is different between DXE/UEFI
and MM_STANDALONE drivers.

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Ting Ye <ting.ye@intel.com>
Cc: Gang Wei <gang.wei@intel.com>
Cc: Jian Wang <jian.j.wang@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Achin Gupta <achin.gupta@arm.com>
Cc: Jagadeesh Ujja <jagadeesh.ujja@arm.com>

Ard Biesheuvel (4):
  CryptoPkg/SmmCryptLib: permit use by MM_STANDALONE modules
  SecurityPkg/PlatformSecureLibNull: permit use by MM_STANDALONE modules
  MdeModulePkg/VarCheckLib: permit use by MM_STANDALONE modules
  MdePkg/UefiDevicePathLib: permit use by MM_STANDALONE modules

 CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf           | 2 +-
 MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf | 4 ++--
 .../Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c   | 9 +++++----
 MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf   | 2 +-
 .../PlatformSecureLibNull/PlatformSecureLibNull.c        | 9 +++++----
 .../PlatformSecureLibNull/PlatformSecureLibNull.inf      | 4 ++--
 6 files changed, 16 insertions(+), 14 deletions(-)

-- 
2.17.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Ard Biesheuvel Jan. 21, 2019, 12:43 p.m. UTC | #1
On Wed, 16 Jan 2019 at 22:22, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>

> Add MM_STANDALONE to the list of permitted module types of various

> libraries that are required to build the standalone MM authenticated

> variable stack.

>

> In some cases, this requires the MODULE_TYPE to be modified to BASE,

> given that the constructor prototype is different between DXE/UEFI

> and MM_STANDALONE drivers.

>

> Cc: Michael D Kinney <michael.d.kinney@intel.com>

> Cc: Liming Gao <liming.gao@intel.com>

> Cc: Ting Ye <ting.ye@intel.com>

> Cc: Gang Wei <gang.wei@intel.com>

> Cc: Jian Wang <jian.j.wang@intel.com>

> Cc: Chao Zhang <chao.b.zhang@intel.com>

> Cc: Jiewen Yao <jiewen.yao@intel.com>

> Cc: Hao Wu <hao.a.wu@intel.com>

> Cc: Star Zeng <star.zeng@intel.com>

> Cc: Achin Gupta <achin.gupta@arm.com>

> Cc: Jagadeesh Ujja <jagadeesh.ujja@arm.com>

>

> Ard Biesheuvel (4):

>   CryptoPkg/SmmCryptLib: permit use by MM_STANDALONE modules

>   SecurityPkg/PlatformSecureLibNull: permit use by MM_STANDALONE modules

>   MdeModulePkg/VarCheckLib: permit use by MM_STANDALONE modules

>   MdePkg/UefiDevicePathLib: permit use by MM_STANDALONE modules

>


Series pushed as 5c5ca9f1fbf8..f634e32db5b6

Thanks all!
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Gao, Liming Jan. 21, 2019, 12:49 p.m. UTC | #2
Ard:
  The patches created by you recently is to support the standalone MM authenticated variable stack. This is likely a new feature. 

  Could you help submit BZ for this new feature or reuse the existing BZ? And, update https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning to include it for edk2-stable201903 tag.

Thanks
Liming
> -----Original Message-----

> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard Biesheuvel

> Sent: Monday, January 21, 2019 8:44 PM

> To: edk2-devel@lists.01.org

> Cc: Ye, Ting <ting.ye@intel.com>; Gao, Liming <liming.gao@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Yao, Jiewen

> <jiewen.yao@intel.com>; Zeng, Star <star.zeng@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Zhang, Chao B

> <chao.b.zhang@intel.com>

> Subject: Re: [edk2] [PATCH 0/4] Various Packages: add MM_STANDALONE support

> 

> On Wed, 16 Jan 2019 at 22:22, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:

> >

> > Add MM_STANDALONE to the list of permitted module types of various

> > libraries that are required to build the standalone MM authenticated

> > variable stack.

> >

> > In some cases, this requires the MODULE_TYPE to be modified to BASE,

> > given that the constructor prototype is different between DXE/UEFI

> > and MM_STANDALONE drivers.

> >

> > Cc: Michael D Kinney <michael.d.kinney@intel.com>

> > Cc: Liming Gao <liming.gao@intel.com>

> > Cc: Ting Ye <ting.ye@intel.com>

> > Cc: Gang Wei <gang.wei@intel.com>

> > Cc: Jian Wang <jian.j.wang@intel.com>

> > Cc: Chao Zhang <chao.b.zhang@intel.com>

> > Cc: Jiewen Yao <jiewen.yao@intel.com>

> > Cc: Hao Wu <hao.a.wu@intel.com>

> > Cc: Star Zeng <star.zeng@intel.com>

> > Cc: Achin Gupta <achin.gupta@arm.com>

> > Cc: Jagadeesh Ujja <jagadeesh.ujja@arm.com>

> >

> > Ard Biesheuvel (4):

> >   CryptoPkg/SmmCryptLib: permit use by MM_STANDALONE modules

> >   SecurityPkg/PlatformSecureLibNull: permit use by MM_STANDALONE modules

> >   MdeModulePkg/VarCheckLib: permit use by MM_STANDALONE modules

> >   MdePkg/UefiDevicePathLib: permit use by MM_STANDALONE modules

> >

> 

> Series pushed as 5c5ca9f1fbf8..f634e32db5b6

> 

> Thanks all!

> _______________________________________________

> edk2-devel mailing list

> edk2-devel@lists.01.org

> https://lists.01.org/mailman/listinfo/edk2-devel

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Ard Biesheuvel Jan. 21, 2019, 2:34 p.m. UTC | #3
On Mon, 21 Jan 2019 at 13:49, Gao, Liming <liming.gao@intel.com> wrote:
>

> Ard:

>   The patches created by you recently is to support the standalone MM authenticated variable stack. This is likely a new feature.

>

>   Could you help submit BZ for this new feature or reuse the existing BZ? And, update https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning to include it for edk2-stable201903 tag.

>


I will add a bugzilla entry for the remaining standalone MM work, but
could someone please add StandaloneMmPkg to the bugzilla packages
list? Thanks.
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Ard Biesheuvel Feb. 28, 2019, 2:53 p.m. UTC | #4
On Mon, 21 Jan 2019 at 15:34, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>

> On Mon, 21 Jan 2019 at 13:49, Gao, Liming <liming.gao@intel.com> wrote:

> >

> > Ard:

> >   The patches created by you recently is to support the standalone MM authenticated variable stack. This is likely a new feature.

> >

> >   Could you help submit BZ for this new feature or reuse the existing BZ? And, update https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning to include it for edk2-stable201903 tag.

> >

>

> I will add a bugzilla entry for the remaining standalone MM work, but

> could someone please add StandaloneMmPkg to the bugzilla packages

> list? Thanks.


Mike,

Could you please make this change to bugzilla? We need it to log work
for StandaloneMmPkg.

Thanks,
Ard.
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel