| Message ID | 20190218102106.32163-1-julien.grall@arm.com |
|---|---|
| State | New |
| Headers | show |
| Series | [Xen-devel,for-4.12,v2] xen/arm: domain_build: Panic message should end with a newline | expand |
On 18/02/2019 10:21, Julien Grall wrote: > Since commit 25eb5eec79 "xen: Fix inconsistent callers of panic()" all > the panic message should end with a newline. Unfortunately, some > commits pushed afterwards does not follow the rule. > > Modify the offending panic messages to avoid more inconsistency. > > Signed-off-by: Julien Grall <julien.grall@arm.com> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
On 18/02/2019 11:21, Julien Grall wrote: > Since commit 25eb5eec79 "xen: Fix inconsistent callers of panic()" all > the panic message should end with a newline. Unfortunately, some > commits pushed afterwards does not follow the rule. > > Modify the offending panic messages to avoid more inconsistency. > > Signed-off-by: Julien Grall <julien.grall@arm.com> Release-acked-by: Juergen Gross <jgross@suse.com> Juergen
On Mon, 18 Feb 2019, Julien Grall wrote: > Since commit 25eb5eec79 "xen: Fix inconsistent callers of panic()" all > the panic message should end with a newline. Unfortunately, some > commits pushed afterwards does not follow the rule. > > Modify the offending panic messages to avoid more inconsistency. > > Signed-off-by: Julien Grall <julien.grall@arm.com> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> > --- > > Cc: andrew.cooper3@citrix.com > --- > xen/arch/arm/domain_build.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index c92f8c6be1..d9836779d1 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -1580,7 +1580,7 @@ static int __init make_gic_domU_node(const struct domain *d, void *fdt) > case GIC_V2: > return make_gicv2_domU_node(d, fdt); > default: > - panic("Unsupported GIC version"); > + panic("Unsupported GIC version\n"); > } > } > > @@ -2086,12 +2086,12 @@ void __init create_domUs(void) > > d = domain_create(++max_init_domid, &d_cfg, false); > if ( IS_ERR(d) ) > - panic("Error creating domain %s", dt_node_name(node)); > + panic("Error creating domain %s\n", dt_node_name(node)); > > d->is_console = true; > > if ( construct_domU(d, node) != 0 ) > - panic("Could not set up domain %s", dt_node_name(node)); > + panic("Could not set up domain %s\n", dt_node_name(node)); > > domain_unpause_by_systemcontroller(d); > } > -- > 2.11.0 >
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index c92f8c6be1..d9836779d1 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -1580,7 +1580,7 @@ static int __init make_gic_domU_node(const struct domain *d, void *fdt) case GIC_V2: return make_gicv2_domU_node(d, fdt); default: - panic("Unsupported GIC version"); + panic("Unsupported GIC version\n"); } } @@ -2086,12 +2086,12 @@ void __init create_domUs(void) d = domain_create(++max_init_domid, &d_cfg, false); if ( IS_ERR(d) ) - panic("Error creating domain %s", dt_node_name(node)); + panic("Error creating domain %s\n", dt_node_name(node)); d->is_console = true; if ( construct_domU(d, node) != 0 ) - panic("Could not set up domain %s", dt_node_name(node)); + panic("Could not set up domain %s\n", dt_node_name(node)); domain_unpause_by_systemcontroller(d); }
Since commit 25eb5eec79 "xen: Fix inconsistent callers of panic()" all the panic message should end with a newline. Unfortunately, some commits pushed afterwards does not follow the rule. Modify the offending panic messages to avoid more inconsistency. Signed-off-by: Julien Grall <julien.grall@arm.com> --- Cc: andrew.cooper3@citrix.com --- xen/arch/arm/domain_build.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)