| Message ID | 20190204170012.13617-2-rui.silva@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | iio: gyro: add fxas2100x driver | expand |
Hi Rui, On Mon, Feb 4, 2019 at 3:25 PM Rui Miguel Silva <rui.silva@linaro.org> wrote: > > Add device tree bindings for the FXAS2100x gyroscope. Please name it after the real part number: FXAS21002. > > Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org> > --- > .../bindings/iio/gyroscope/fxas2100x.txt | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/gyroscope/fxas2100x.txt > > diff --git a/Documentation/devicetree/bindings/iio/gyroscope/fxas2100x.txt b/Documentation/devicetree/bindings/iio/gyroscope/fxas2100x.txt > new file mode 100644 > index 000000000000..2aeef9aafec4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/gyroscope/fxas2100x.txt > @@ -0,0 +1,14 @@ > +* NXP FXAS2100X Gyroscope device tree bindings > + > +http://www.nxp.com/products/sensors/gyroscopes/3-axis-digital-gyroscope:FXAS21002C > + > +Required properties: > + - compatible : should be "nxp,fxas2100x" We usually don't put x in the end. Better put the real part number instead: "nxp,fxas21002" > + - reg : the I2C address of the sensor Please describe the VDD and VDDIO regulators as well in the dt-bindings and also add support for enabling them in the driver.
Oi Fabio, Thanks for the review. On Mon 04 Feb 2019 at 18:16, Fabio Estevam wrote: > Hi Rui, > > On Mon, Feb 4, 2019 at 3:25 PM Rui Miguel Silva > <rui.silva@linaro.org> wrote: >> >> Add device tree bindings for the FXAS2100x gyroscope. > > Please name it after the real part number: FXAS21002. Yeah, right now it supports the FXAS21002 but if someone wants to support for example the FXAS21000 it will be easier and the naming just there, the main differences are ranges. But as we here are starting with the FXAS210002, I tend to agree. > >> >> Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org> >> --- >> .../bindings/iio/gyroscope/fxas2100x.txt | 14 >> ++++++++++++++ >> 1 file changed, 14 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/iio/gyroscope/fxas2100x.txt >> >> diff --git >> a/Documentation/devicetree/bindings/iio/gyroscope/fxas2100x.txt >> b/Documentation/devicetree/bindings/iio/gyroscope/fxas2100x.txt >> new file mode 100644 >> index 000000000000..2aeef9aafec4 >> --- /dev/null >> +++ >> b/Documentation/devicetree/bindings/iio/gyroscope/fxas2100x.txt >> @@ -0,0 +1,14 @@ >> +* NXP FXAS2100X Gyroscope device tree bindings >> + >> +http://www.nxp.com/products/sensors/gyroscopes/3-axis-digital-gyroscope:FXAS21002C >> + >> +Required properties: >> + - compatible : should be "nxp,fxas2100x" > > We usually don't put x in the end. Better put the real part > number > instead: "nxp,fxas21002" Yeah, agree. > > >> + - reg : the I2C address of the sensor > > Please describe the VDD and VDDIO regulators as well in the > dt-bindings and also add support for enabling them in the > driver. Will do. --- Cheers, Rui
On Mon, Feb 04, 2019 at 05:00:08PM +0000, Rui Miguel Silva wrote: > Add device tree bindings for the FXAS2100x gyroscope. > > Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org> > --- > .../bindings/iio/gyroscope/fxas2100x.txt | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/gyroscope/fxas2100x.txt > > diff --git a/Documentation/devicetree/bindings/iio/gyroscope/fxas2100x.txt b/Documentation/devicetree/bindings/iio/gyroscope/fxas2100x.txt > new file mode 100644 > index 000000000000..2aeef9aafec4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/gyroscope/fxas2100x.txt > @@ -0,0 +1,14 @@ > +* NXP FXAS2100X Gyroscope device tree bindings > + > +http://www.nxp.com/products/sensors/gyroscopes/3-axis-digital-gyroscope:FXAS21002C > + > +Required properties: > + - compatible : should be "nxp,fxas2100x" > + - reg : the I2C address of the sensor > + > +Example: > + > +fxas2100x@20 { gyroscope@20 in addition to what's already been mentioned. > + compatible = "nxp,fxas2100x" > + reg = <0x20>; > +}; > -- > 2.20.1 >
diff --git a/Documentation/devicetree/bindings/iio/gyroscope/fxas2100x.txt b/Documentation/devicetree/bindings/iio/gyroscope/fxas2100x.txt new file mode 100644 index 000000000000..2aeef9aafec4 --- /dev/null +++ b/Documentation/devicetree/bindings/iio/gyroscope/fxas2100x.txt @@ -0,0 +1,14 @@ +* NXP FXAS2100X Gyroscope device tree bindings + +http://www.nxp.com/products/sensors/gyroscopes/3-axis-digital-gyroscope:FXAS21002C + +Required properties: + - compatible : should be "nxp,fxas2100x" + - reg : the I2C address of the sensor + +Example: + +fxas2100x@20 { + compatible = "nxp,fxas2100x" + reg = <0x20>; +};
Add device tree bindings for the FXAS2100x gyroscope. Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org> --- .../bindings/iio/gyroscope/fxas2100x.txt | 14 ++++++++++++++ 1 file changed, 14 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/gyroscope/fxas2100x.txt -- 2.20.1