| Message ID | 20190304115835.28288-1-ross.burton@intel.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | libcomps: put PV in filename | expand |
On Mon, 2019-03-04 at 11:58 +0000, Ross Burton wrote: > This isn't a git snapshot recipe but a release that is fetched over > it. For > clarity, put the PV in the filename. > > Signed-off-by: Ross Burton <ross.burton@intel.com> > --- > meta/recipes-devtools/libcomps/{libcomps_git.bb => > libcomps_0.10.0.bb} | 1 - > 1 file changed, 1 deletion(-) > rename meta/recipes-devtools/libcomps/{libcomps_git.bb => > libcomps_0.10.0.bb} (98%) > > diff --git a/meta/recipes-devtools/libcomps/libcomps_git.bb > b/meta/recipes-devtools/libcomps/libcomps_0.10.0.bb > similarity index 98% > rename from meta/recipes-devtools/libcomps/libcomps_git.bb > rename to meta/recipes-devtools/libcomps/libcomps_0.10.0.bb > index ff6820851fe..1c4f3bde65e 100644 > --- a/meta/recipes-devtools/libcomps/libcomps_git.bb > +++ b/meta/recipes-devtools/libcomps/libcomps_0.10.0.bb > @@ -9,7 +9,6 @@ SRC_URI = "git://github.com/rpm-software- > management/libcomps.git \ > file://0001-Add-crc32.c-to-sources-list.patch \ > " > > -PV = "0.1.10" > SRCREV = "86a82fcd155c27092340d15a34f5c75c4da88243" I suspect we have this issue in a few cases and having PV next to the SRCREV may prompt people to keep things more in sync? Cheers, Richard -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
On Mon, 4 Mar 2019 at 15:12, Richard Purdie <richard.purdie@linuxfoundation.org> wrote: > I suspect we have this issue in a few cases and having PV next to the > SRCREV may prompt people to keep things more in sync? I'm sure we do, but I spotted this one. The AUH will do the prompting so I'm not sure what else needs to be kept in sync. Ross -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
diff --git a/meta/recipes-devtools/libcomps/libcomps_git.bb b/meta/recipes-devtools/libcomps/libcomps_0.10.0.bb similarity index 98% rename from meta/recipes-devtools/libcomps/libcomps_git.bb rename to meta/recipes-devtools/libcomps/libcomps_0.10.0.bb index ff6820851fe..1c4f3bde65e 100644 --- a/meta/recipes-devtools/libcomps/libcomps_git.bb +++ b/meta/recipes-devtools/libcomps/libcomps_0.10.0.bb @@ -9,7 +9,6 @@ SRC_URI = "git://github.com/rpm-software-management/libcomps.git \ file://0001-Add-crc32.c-to-sources-list.patch \ " -PV = "0.1.10" SRCREV = "86a82fcd155c27092340d15a34f5c75c4da88243" S = "${WORKDIR}/git"
This isn't a git snapshot recipe but a release that is fetched over it. For clarity, put the PV in the filename. Signed-off-by: Ross Burton <ross.burton@intel.com> --- meta/recipes-devtools/libcomps/{libcomps_git.bb => libcomps_0.10.0.bb} | 1 - 1 file changed, 1 deletion(-) rename meta/recipes-devtools/libcomps/{libcomps_git.bb => libcomps_0.10.0.bb} (98%) -- 2.11.0 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core