| Message ID | 20190319232130.24172-1-julien.grall@arm.com |
|---|---|
| State | New |
| Headers | show |
| Series | [Xen-devel] x86/mm: Fix typo in comment on top of page_lock | expand |
>>> Julien Grall <julien.grall@arm.com> 03/20/19 12:21 AM >>> >Signed-off-by: Julien Grall <julien.grall@arm.com> Acked-by: Jan Beulich <jbeulich@suse.com> >--- a/xen/arch/x86/mm.c >+++ b/xen/arch/x86/mm.c >@@ -2003,7 +2003,7 @@ static int free_l4_table(struct page_info *page) >* 2. We never call _put_page_type() on a page while holding its page lock. >* >* Add a check to debug builds to catch any violations of these >- * assumpitons. >+ * assumptions. Would you mind also doing away with the unnecessary line split at the same time? The sentence fits on a single line without going to or beyond 80 characters. Jan
Hi, On 3/20/19 7:08 AM, Jan Beulich wrote: >>>> Julien Grall <julien.grall@arm.com> 03/20/19 12:21 AM >>> >> Signed-off-by: Julien Grall <julien.grall@arm.com> > > Acked-by: Jan Beulich <jbeulich@suse.com> > >> --- a/xen/arch/x86/mm.c >> +++ b/xen/arch/x86/mm.c >> @@ -2003,7 +2003,7 @@ static int free_l4_table(struct page_info *page) >> * 2. We never call _put_page_type() on a page while holding its page lock. >> * >> * Add a check to debug builds to catch any violations of these >> - * assumpitons. >> + * assumptions. > > Would you mind also doing away with the unnecessary line split at the same time? > The sentence fits on a single line without going to or beyond 80 characters. Sure. I have removed the line split and committed the patch. Cheers,
diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index dbec130da0..94b82e8e5e 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -2003,7 +2003,7 @@ static int free_l4_table(struct page_info *page) * 2. We never call _put_page_type() on a page while holding its page lock. * * Add a check to debug builds to catch any violations of these - * assumpitons. + * assumptions. * * NB that if we find valid, safe reasons to hold two page locks at * once, these checks will need to be adjusted.
Signed-off-by: Julien Grall <julien.grall@arm.com> --- xen/arch/x86/mm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)