mbox series

[0/2] target/ppc: make use of new gvec expanders

Message ID 20190518191430.21686-1-richard.henderson@linaro.org
Headers show
Series target/ppc: make use of new gvec expanders | expand

Message

Richard Henderson May 18, 2019, 7:14 p.m. UTC 
Based-on: <20190518190157.21255-1-richard.henderson@linaro.org>
Aka "tcg: misc gvec improvements".

Since Mark's initial patches, we've added (or are adding)
generic support for variable vector shifts and bitsel.


r~


Richard Henderson (2):
  target/ppc: Use vector variable shifts for VSL, VSR, VSRA
  target/ppc: Use tcg_gen_gvec_bitsel

 target/ppc/helper.h                 | 12 ----------
 target/ppc/int_helper.c             | 37 -----------------------------
 target/ppc/translate/vmx-impl.inc.c | 24 +++++++++----------
 target/ppc/translate/vsx-impl.inc.c | 24 ++-----------------
 4 files changed, 14 insertions(+), 83 deletions(-)

-- 
2.17.1

Comments

David Gibson May 20, 2019, 4:01 a.m. UTC | #1 
On Sat, May 18, 2019 at 12:14:28PM -0700, Richard Henderson wrote:
> Based-on: <20190518190157.21255-1-richard.henderson@linaro.org>

> Aka "tcg: misc gvec improvements".

> 

> Since Mark's initial patches, we've added (or are adding)

> generic support for variable vector shifts and bitsel.


Applied, thanks.

> 

> 

> r~

> 

> 

> Richard Henderson (2):

>   target/ppc: Use vector variable shifts for VSL, VSR, VSRA

>   target/ppc: Use tcg_gen_gvec_bitsel

> 

>  target/ppc/helper.h                 | 12 ----------

>  target/ppc/int_helper.c             | 37 -----------------------------

>  target/ppc/translate/vmx-impl.inc.c | 24 +++++++++----------

>  target/ppc/translate/vsx-impl.inc.c | 24 ++-----------------

>  4 files changed, 14 insertions(+), 83 deletions(-)

> 


-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson
David Gibson May 20, 2019, 5:56 a.m. UTC | #2 
On Mon, May 20, 2019 at 02:01:42PM +1000, David Gibson wrote:
> On Sat, May 18, 2019 at 12:14:28PM -0700, Richard Henderson wrote:

> > Based-on: <20190518190157.21255-1-richard.henderson@linaro.org>

> > Aka "tcg: misc gvec improvements".

> > 

> > Since Mark's initial patches, we've added (or are adding)

> > generic support for variable vector shifts and bitsel.

> 

> Applied, thanks.


Urgh.. actually, I've removed 2/2 again.  I get this error:

In file included from /home/dwg/src/qemu/target/ppc/translate.c:6819:
/home/dwg/src/qemu/target/ppc/translate/vsx-impl.inc.c: In function ‘gen_xxsel’:
/home/dwg/src/qemu/target/ppc/translate/vsx-impl.inc.c:1352:5: error: implicit declaration of function ‘tcg_gen_gvec_bitsel’; did you mean ‘tcg_gen_gvec_2i_ool’? [-Werror=implicit-function-declaration]
 1352 |     tcg_gen_gvec_bitsel(MO_64, vsr_full_offset(rt), vsr_full_offset(rc),
      |     ^~~~~~~~~~~~~~~~~~~
      |     tcg_gen_gvec_2i_ool
/home/dwg/src/qemu/target/ppc/translate/vsx-impl.inc.c:1352:5: error: nested extern declaration of ‘tcg_gen_gvec_bitsel’ [-Werror=nested-externs]
cc1: all warnings being treated as errors


> 

> > 

> > 

> > r~

> > 

> > 

> > Richard Henderson (2):

> >   target/ppc: Use vector variable shifts for VSL, VSR, VSRA

> >   target/ppc: Use tcg_gen_gvec_bitsel

> > 

> >  target/ppc/helper.h                 | 12 ----------

> >  target/ppc/int_helper.c             | 37 -----------------------------

> >  target/ppc/translate/vmx-impl.inc.c | 24 +++++++++----------

> >  target/ppc/translate/vsx-impl.inc.c | 24 ++-----------------

> >  4 files changed, 14 insertions(+), 83 deletions(-)

> > 

> 




-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson