| Message ID | 20190530173824.30699-1-richard.henderson@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | util: Adjust qemu_guest_getrandom_nofail for Coverity | expand |
On Thu, 30 May 2019 at 18:38, Richard Henderson <richard.henderson@linaro.org> wrote: > > Explicitly ignore the return value of qemu_guest_getrandom. > Because we use error_fatal, all errors are already caught. > > Fixes: CID 1401701 > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > util/guest-random.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Peter Maydell <peter.maydell@linaro.org> thanks -- PMM
On 5/30/19 7:38 PM, Richard Henderson wrote: > Explicitly ignore the return value of qemu_guest_getrandom. > Because we use error_fatal, all errors are already caught. > > Fixes: CID 1401701 > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > util/guest-random.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/util/guest-random.c b/util/guest-random.c > index e8124a3cad..00a08fd981 100644 > --- a/util/guest-random.c > +++ b/util/guest-random.c > @@ -56,7 +56,7 @@ int qemu_guest_getrandom(void *buf, size_t len, Error **errp) > > void qemu_guest_getrandom_nofail(void *buf, size_t len) > { > - qemu_guest_getrandom(buf, len, &error_fatal); > + (void)qemu_guest_getrandom(buf, len, &error_fatal); > } > > uint64_t qemu_guest_random_seed_thread_part1(void) > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Le 30/05/2019 à 19:38, Richard Henderson a écrit : > Explicitly ignore the return value of qemu_guest_getrandom. > Because we use error_fatal, all errors are already caught. > > Fixes: CID 1401701 > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > util/guest-random.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/util/guest-random.c b/util/guest-random.c > index e8124a3cad..00a08fd981 100644 > --- a/util/guest-random.c > +++ b/util/guest-random.c > @@ -56,7 +56,7 @@ int qemu_guest_getrandom(void *buf, size_t len, Error **errp) > > void qemu_guest_getrandom_nofail(void *buf, size_t len) > { > - qemu_guest_getrandom(buf, len, &error_fatal); > + (void)qemu_guest_getrandom(buf, len, &error_fatal); > } > > uint64_t qemu_guest_random_seed_thread_part1(void) > Applied to my trivial-patches branch. Thanks, Laurent
diff --git a/util/guest-random.c b/util/guest-random.c index e8124a3cad..00a08fd981 100644 --- a/util/guest-random.c +++ b/util/guest-random.c @@ -56,7 +56,7 @@ int qemu_guest_getrandom(void *buf, size_t len, Error **errp) void qemu_guest_getrandom_nofail(void *buf, size_t len) { - qemu_guest_getrandom(buf, len, &error_fatal); + (void)qemu_guest_getrandom(buf, len, &error_fatal); } uint64_t qemu_guest_random_seed_thread_part1(void)
Explicitly ignore the return value of qemu_guest_getrandom. Because we use error_fatal, all errors are already caught. Fixes: CID 1401701 Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- util/guest-random.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1