| Message ID | CAELXzTOdm2QDA3hFJoSfv771ZY8ZgU9qS=C38gPrDnUOsR3srw@mail.gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [AARCH64] Fix typo in comment | expand |
Hi Kugan, On 6/12/19 4:59 AM, Kugan Vivekanandarajah wrote: > AArch64 comment for ADDSUB iterator is a typo or copy-and-paste error. > Attached patch fixes this. I believe this falls under obvious > category. I will commit it after 48hrs unless comments should be > better worded. > > Thanks, > Kugan > > > gcc/ChangeLog: > > 2019-06-12 Kugan Vivekanandarajah <kugan.vivekanandarajah@linaro.org> > > * config/aarch64/iterators.md (ADDSUB): Fix typo in comment. diff --git a/gcc/config/aarch64/iterators.md b/gcc/config/aarch64/iterators.md index 2179e6f..49c8146 100644 --- a/gcc/config/aarch64/iterators.md +++ b/gcc/config/aarch64/iterators.md @@ -1215,7 +1215,7 @@ ;; Signed and unsigned max operations. (define_code_iterator USMAX [smax umax]) -;; Code iterator for variants of vector max and min. +;; Code iterator for variants of vector plus and minus. I'd remove the "variants" and have it "Code iterator for plus and minus" I do agree such a change is obvious. Thanks, Kyrill (define_code_iterator ADDSUB [plus minus]) ;; Code iterator for variants of vector saturating binary ops.
Hi Kyrill, Thanks for the comments. Committed as you suggested. Thanks, Kugan On Wed, 12 Jun 2019 at 18:07, Kyrill Tkachov <kyrylo.tkachov@foss.arm.com> wrote: > > Hi Kugan, > > On 6/12/19 4:59 AM, Kugan Vivekanandarajah wrote: > > AArch64 comment for ADDSUB iterator is a typo or copy-and-paste error. > > Attached patch fixes this. I believe this falls under obvious > > category. I will commit it after 48hrs unless comments should be > > better worded. > > > > Thanks, > > Kugan > > > > > > gcc/ChangeLog: > > > > 2019-06-12 Kugan Vivekanandarajah <kugan.vivekanandarajah@linaro.org> > > > > * config/aarch64/iterators.md (ADDSUB): Fix typo in comment. > > diff --git a/gcc/config/aarch64/iterators.md > b/gcc/config/aarch64/iterators.md > index 2179e6f..49c8146 100644 > --- a/gcc/config/aarch64/iterators.md > +++ b/gcc/config/aarch64/iterators.md > @@ -1215,7 +1215,7 @@ > ;; Signed and unsigned max operations. > (define_code_iterator USMAX [smax umax]) > > -;; Code iterator for variants of vector max and min. > > +;; Code iterator for variants of vector plus and minus. > > > I'd remove the "variants" and have it "Code iterator for plus and minus" > > I do agree such a change is obvious. > > Thanks, > > Kyrill > > (define_code_iterator ADDSUB [plus minus]) > > ;; Code iterator for variants of vector saturating binary ops. >
diff --git a/gcc/config/aarch64/iterators.md b/gcc/config/aarch64/iterators.md index 2179e6f..49c8146 100644 --- a/gcc/config/aarch64/iterators.md +++ b/gcc/config/aarch64/iterators.md @@ -1215,7 +1215,7 @@ ;; Signed and unsigned max operations. (define_code_iterator USMAX [smax umax]) -;; Code iterator for variants of vector max and min. +;; Code iterator for variants of vector plus and minus. (define_code_iterator ADDSUB [plus minus]) ;; Code iterator for variants of vector saturating binary ops.
AArch64 comment for ADDSUB iterator is a typo or copy-and-paste error. Attached patch fixes this. I believe this falls under obvious category. I will commit it after 48hrs unless comments should be better worded. Thanks, Kugan gcc/ChangeLog: 2019-06-12 Kugan Vivekanandarajah <kugan.vivekanandarajah@linaro.org> * config/aarch64/iterators.md (ADDSUB): Fix typo in comment.