| Message ID | 20190723103612.5600-1-alex.bennee@linaro.org |
|---|---|
| Headers | show |
| Series | testing updates (green CI!) | expand |
On Tue, 23 Jul 2019 at 11:36, Alex Bennée <alex.bennee@linaro.org> wrote: > > The following changes since commit 23da9e297b4120ca9702cabec91599a44255fe96: > > Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20190722' into staging (2019-07-22 15:16:48 +0100) > > are available in the Git repository at: > > https://github.com/stsquad/qemu.git tags/pull-testing-230719-1 > > for you to fetch changes up to 2e3b8743cd66f1d0fbc83051b0b6b072a97460cc: > > gitlab-ci: Remove qcow2 tests that are handled by "make check" already (2019-07-23 11:33:15 +0100) > > ---------------------------------------------------------------- > Final testing updates: > > - docker sphinx updates > - windows build re-enabled in CI > - travis_retry for make check > - quick iotests enabled for make check > - build fixes > > ---------------------------------------------------------------- 'make check-tcg' fails (x86-64 host): make: Entering directory '/home/petmay01/linaro/qemu-for-merges/build/all-linux-static' BUILD debian10 The command '/bin/sh -c DEBIAN_FRONTEND=noninteractive eatmydata apt install -y --no-install-recommends bison build-essential ca-certificates clang flex gettext git pkg-config psmisc python python3-sphinx texinfo $(apt-get -s build-dep qemu | egrep ^Inst | fgrep '[all]' | cut -d\ -f2)' returned a non-zero code: 100 Traceback (most recent call last): File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", line 615, in <module> sys.exit(main()) File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", line 611, in main return args.cmdobj.run(args, argv) File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", line 413, in run extra_files_cksum=cksum) File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", line 280, in build_image quiet=quiet) File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", line 207, in _do_check return subprocess.check_call(self._command + cmd, **kwargs) File "/usr/lib/python2.7/subprocess.py", line 190, in check_call raise CalledProcessError(retcode, cmd) subprocess.CalledProcessError: Command '['docker', 'build', '-t', 'qemu:debian10', '-f', '/tmp/docker_buildBgZdCD/tmp6MJLiZ.docker', '/tmp/docker_buildBgZdCD']' returned non-zero exit status 100 /home/petmay01/linaro/qemu-for-merges/tests/docker/Makefile.include:53: recipe for target 'docker-image-debian10' failed make: *** [docker-image-debian10] Error 1 make: Leaving directory '/home/petmay01/linaro/qemu-for-merges/build/all-linux-static' I also got a failure with openbsd which seems to be when the tests run check-block.sh: /home/qemu/qemu-test.Dy1Aj3/src/tests/check-block.sh TEST iotest-qcow2: 001 TEST iotest-qcow2: 002 TEST iotest-qcow2: 003 TEST iotest-qcow2: 004 TEST iotest-qcow2: 005 [not run] TEST iotest-qcow2: 007 [fail] QEMU -- "/home/qemu/qemu-test.Dy1Aj3/build/tests/qemu-iotests/../../aarch64-softmmu/qemu-system-aarch64" -nodefaults -machine virt,accel=qtest QEMU_IMG -- "/home/qemu/qemu-test.Dy1Aj3/build/tests/qemu-iotests/../../qemu-img" QEMU_IO -- "/home/qemu/qemu-test.Dy1Aj3/build/tests/qemu-iotests/../../qemu-io" --cache writeback -f qcow2 QEMU_NBD -- "/home/qemu/qemu-test.Dy1Aj3/build/tests/qemu-iotests/../../qemu-nbd" IMGFMT -- qcow2 (compat=1.1) IMGPROTO -- file PLATFORM -- OpenBSD/amd64 openbsd 6.5 TEST_DIR -- /home/qemu/qemu-test.Dy1Aj3/build/tests/qemu-iotests/scratch SOCKET_SCM_HELPER -- --- /home/qemu/qemu-test.Dy1Aj3/src/tests/qemu-iotests/007.out Tue Jul 23 10:49:15 2019 +++ /home/qemu/qemu-test.Dy1Aj3/build/tests/qemu-iotests/007.out.bad Tue Jul 23 11:10:21 2019 @@ -2,16 +2,7 @@ creating image Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=1048576 -savevm 1 -savevm 2 -savevm 3 -savevm 4 -savevm 5 -savevm 6 -savevm 7 -savevm 8 -savevm 9 -savevm 10 +./007: line 51: seq: command not found [and some other failures] I see Thomas Huth has a patch on-list for that, but this didn't manifest as a problem before this pullreq. thanks -- PMM
Peter Maydell <peter.maydell@linaro.org> writes: > On Tue, 23 Jul 2019 at 11:36, Alex Bennée <alex.bennee@linaro.org> wrote: >> >> The following changes since commit 23da9e297b4120ca9702cabec91599a44255fe96: >> >> Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20190722' into staging (2019-07-22 15:16:48 +0100) >> >> are available in the Git repository at: >> >> https://github.com/stsquad/qemu.git tags/pull-testing-230719-1 >> >> for you to fetch changes up to 2e3b8743cd66f1d0fbc83051b0b6b072a97460cc: >> >> gitlab-ci: Remove qcow2 tests that are handled by "make check" already (2019-07-23 11:33:15 +0100) >> >> ---------------------------------------------------------------- >> Final testing updates: >> >> - docker sphinx updates >> - windows build re-enabled in CI >> - travis_retry for make check >> - quick iotests enabled for make check >> - build fixes >> >> ---------------------------------------------------------------- > > 'make check-tcg' fails (x86-64 host): > > make: Entering directory > '/home/petmay01/linaro/qemu-for-merges/build/all-linux-static' > BUILD debian10 > The command '/bin/sh -c DEBIAN_FRONTEND=noninteractive eatmydata > apt install -y --no-install-recommends bison > build-essential ca-certificates clang flex > gettext git pkg-config psmisc > python python3-sphinx texinfo $(apt-get -s > build-dep qemu | egrep ^Inst | fgrep '[all]' | cut -d\ -f2)' returned > a non-zero code: 100 > Traceback (most recent call last): > File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", > line 615, in <module> > sys.exit(main()) > File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", > line 611, in main > return args.cmdobj.run(args, argv) > File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", > line 413, in run > extra_files_cksum=cksum) > File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", > line 280, in build_image > quiet=quiet) > File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", > line 207, in _do_check > return subprocess.check_call(self._command + cmd, **kwargs) > File "/usr/lib/python2.7/subprocess.py", line 190, in check_call > raise CalledProcessError(retcode, cmd) > subprocess.CalledProcessError: Command '['docker', 'build', '-t', > 'qemu:debian10', '-f', '/tmp/docker_buildBgZdCD/tmp6MJLiZ.docker', > '/tmp/docker_buildBgZdCD']' returned non-zero exit status 100 > /home/petmay01/linaro/qemu-for-merges/tests/docker/Makefile.include:53: > recipe for target 'docker-image-debian10' failed > make: *** [docker-image-debian10] Error 1 > make: Leaving directory > '/home/petmay01/linaro/qemu-for-merges/build/all-linux-static' Odd. Does: make docker-image-debian10 V=1 fail for you? Can you retry with: make docker-image-debian10 V=1 NOCACHE=1 > > I also got a failure with openbsd which seems to be when > the tests run check-block.sh: > > /home/qemu/qemu-test.Dy1Aj3/src/tests/check-block.sh > TEST iotest-qcow2: 001 > TEST iotest-qcow2: 002 > TEST iotest-qcow2: 003 > TEST iotest-qcow2: 004 > TEST iotest-qcow2: 005 [not run] > TEST iotest-qcow2: 007 [fail] > QEMU -- > "/home/qemu/qemu-test.Dy1Aj3/build/tests/qemu-iotests/../../aarch64-softmmu/qemu-system-aarch64" > -nodefaults -machine virt,accel=qtest > QEMU_IMG -- > "/home/qemu/qemu-test.Dy1Aj3/build/tests/qemu-iotests/../../qemu-img" > QEMU_IO -- > "/home/qemu/qemu-test.Dy1Aj3/build/tests/qemu-iotests/../../qemu-io" > --cache writeback -f qcow2 > QEMU_NBD -- > "/home/qemu/qemu-test.Dy1Aj3/build/tests/qemu-iotests/../../qemu-nbd" > IMGFMT -- qcow2 (compat=1.1) > IMGPROTO -- file > PLATFORM -- OpenBSD/amd64 openbsd 6.5 > TEST_DIR -- /home/qemu/qemu-test.Dy1Aj3/build/tests/qemu-iotests/scratch > SOCKET_SCM_HELPER -- > > --- /home/qemu/qemu-test.Dy1Aj3/src/tests/qemu-iotests/007.out Tue > Jul 23 10:49:15 2019 > +++ /home/qemu/qemu-test.Dy1Aj3/build/tests/qemu-iotests/007.out.bad > Tue Jul 23 11:10:21 2019 > @@ -2,16 +2,7 @@ > > creating image > Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=1048576 > -savevm 1 > -savevm 2 > -savevm 3 > -savevm 4 > -savevm 5 > -savevm 6 > -savevm 7 > -savevm 8 > -savevm 9 > -savevm 10 > +./007: line 51: seq: command not found > > [and some other failures] > > I see Thomas Huth has a patch on-list for that, but this > didn't manifest as a problem before this pullreq. OK, I'll add it and rebuild the PR. Have you noticed any issues with check-acceptance? > > thanks > -- PMM -- Alex Bennée
On 7/23/19 1:46 PM, Alex Bennée wrote: > > Peter Maydell <peter.maydell@linaro.org> writes: > >> On Tue, 23 Jul 2019 at 11:36, Alex Bennée <alex.bennee@linaro.org> wrote: >>> >>> The following changes since commit 23da9e297b4120ca9702cabec91599a44255fe96: >>> >>> Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20190722' into staging (2019-07-22 15:16:48 +0100) >>> >>> are available in the Git repository at: >>> >>> https://github.com/stsquad/qemu.git tags/pull-testing-230719-1 >>> >>> for you to fetch changes up to 2e3b8743cd66f1d0fbc83051b0b6b072a97460cc: >>> >>> gitlab-ci: Remove qcow2 tests that are handled by "make check" already (2019-07-23 11:33:15 +0100) >>> >>> ---------------------------------------------------------------- >>> Final testing updates: >>> >>> - docker sphinx updates >>> - windows build re-enabled in CI >>> - travis_retry for make check >>> - quick iotests enabled for make check >>> - build fixes >>> >>> ---------------------------------------------------------------- >> >> 'make check-tcg' fails (x86-64 host): >> >> make: Entering directory >> '/home/petmay01/linaro/qemu-for-merges/build/all-linux-static' >> BUILD debian10 >> The command '/bin/sh -c DEBIAN_FRONTEND=noninteractive eatmydata >> apt install -y --no-install-recommends bison >> build-essential ca-certificates clang flex >> gettext git pkg-config psmisc >> python python3-sphinx texinfo $(apt-get -s >> build-dep qemu | egrep ^Inst | fgrep '[all]' | cut -d\ -f2)' returned >> a non-zero code: 100 >> Traceback (most recent call last): >> File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", >> line 615, in <module> >> sys.exit(main()) >> File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", >> line 611, in main >> return args.cmdobj.run(args, argv) >> File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", >> line 413, in run >> extra_files_cksum=cksum) >> File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", >> line 280, in build_image >> quiet=quiet) >> File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", >> line 207, in _do_check >> return subprocess.check_call(self._command + cmd, **kwargs) >> File "/usr/lib/python2.7/subprocess.py", line 190, in check_call >> raise CalledProcessError(retcode, cmd) >> subprocess.CalledProcessError: Command '['docker', 'build', '-t', >> 'qemu:debian10', '-f', '/tmp/docker_buildBgZdCD/tmp6MJLiZ.docker', >> '/tmp/docker_buildBgZdCD']' returned non-zero exit status 100 >> /home/petmay01/linaro/qemu-for-merges/tests/docker/Makefile.include:53: >> recipe for target 'docker-image-debian10' failed Yes, we should definitively improve this error report. >> make: *** [docker-image-debian10] Error 1 >> make: Leaving directory >> '/home/petmay01/linaro/qemu-for-merges/build/all-linux-static' > > Odd. Does: > > make docker-image-debian10 V=1 > > fail for you? Can you retry with: > > make docker-image-debian10 V=1 NOCACHE=1 Should we use a stable tag for the stable release? Such: -- >8 -- diff --git a/tests/docker/dockerfiles/debian10.docker b/tests/docker/dockerfiles/debian10.docker index aeeb151b52..0f2800377d 100644 --- a/tests/docker/dockerfiles/debian10.docker +++ b/tests/docker/dockerfiles/debian10.docker @@ -7,7 +7,7 @@ # On its own you can't build much but the docker-foo-cross targets # build on top of the base debian image. # -FROM debian:buster-slim +FROM debian:buster-20190708-slim # Duplicate deb line as deb-src --- >> >> I also got a failure with openbsd which seems to be when >> the tests run check-block.sh: >> >> /home/qemu/qemu-test.Dy1Aj3/src/tests/check-block.sh >> TEST iotest-qcow2: 001 >> TEST iotest-qcow2: 002 >> TEST iotest-qcow2: 003 >> TEST iotest-qcow2: 004 >> TEST iotest-qcow2: 005 [not run] >> TEST iotest-qcow2: 007 [fail] >> QEMU -- >> "/home/qemu/qemu-test.Dy1Aj3/build/tests/qemu-iotests/../../aarch64-softmmu/qemu-system-aarch64" >> -nodefaults -machine virt,accel=qtest >> QEMU_IMG -- >> "/home/qemu/qemu-test.Dy1Aj3/build/tests/qemu-iotests/../../qemu-img" >> QEMU_IO -- >> "/home/qemu/qemu-test.Dy1Aj3/build/tests/qemu-iotests/../../qemu-io" >> --cache writeback -f qcow2 >> QEMU_NBD -- >> "/home/qemu/qemu-test.Dy1Aj3/build/tests/qemu-iotests/../../qemu-nbd" >> IMGFMT -- qcow2 (compat=1.1) >> IMGPROTO -- file >> PLATFORM -- OpenBSD/amd64 openbsd 6.5 >> TEST_DIR -- /home/qemu/qemu-test.Dy1Aj3/build/tests/qemu-iotests/scratch >> SOCKET_SCM_HELPER -- >> >> --- /home/qemu/qemu-test.Dy1Aj3/src/tests/qemu-iotests/007.out Tue >> Jul 23 10:49:15 2019 >> +++ /home/qemu/qemu-test.Dy1Aj3/build/tests/qemu-iotests/007.out.bad >> Tue Jul 23 11:10:21 2019 >> @@ -2,16 +2,7 @@ >> >> creating image >> Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=1048576 >> -savevm 1 >> -savevm 2 >> -savevm 3 >> -savevm 4 >> -savevm 5 >> -savevm 6 >> -savevm 7 >> -savevm 8 >> -savevm 9 >> -savevm 10 >> +./007: line 51: seq: command not found >> >> [and some other failures] >> >> I see Thomas Huth has a patch on-list for that, but this >> didn't manifest as a problem before this pullreq. > > OK, I'll add it and rebuild the PR. But Thomas got another error later... > > Have you noticed any issues with check-acceptance? > >> >> thanks >> -- PMM > > > -- > Alex Bennée >
On Tue, 23 Jul 2019 at 13:16, Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > > On 7/23/19 1:46 PM, Alex Bennée wrote: > >> I see Thomas Huth has a patch on-list for that, but this > >> didn't manifest as a problem before this pullreq. > > > > OK, I'll add it and rebuild the PR. > > But Thomas got another error later... If we're not sure what all the needed fixes are we should probably just drop the change that starts running the iotests under 'make check'. Otherwise this pullreq is going to miss rc2, and it's too big to go into rc3. thanks -- PMM
Philippe Mathieu-Daudé <philmd@redhat.com> writes: > On 7/23/19 1:46 PM, Alex Bennée wrote: >> >> Peter Maydell <peter.maydell@linaro.org> writes: >> >>> On Tue, 23 Jul 2019 at 11:36, Alex Bennée <alex.bennee@linaro.org> wrote: >>>> >>>> The following changes since commit 23da9e297b4120ca9702cabec91599a44255fe96: >>>> >>>> Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20190722' into staging (2019-07-22 15:16:48 +0100) >>>> >>>> are available in the Git repository at: >>>> >>>> https://github.com/stsquad/qemu.git tags/pull-testing-230719-1 >>>> >>>> for you to fetch changes up to 2e3b8743cd66f1d0fbc83051b0b6b072a97460cc: >>>> >>>> gitlab-ci: Remove qcow2 tests that are handled by "make check" already (2019-07-23 11:33:15 +0100) >>>> >>>> ---------------------------------------------------------------- >>>> Final testing updates: >>>> >>>> - docker sphinx updates >>>> - windows build re-enabled in CI >>>> - travis_retry for make check >>>> - quick iotests enabled for make check >>>> - build fixes >>>> >>>> ---------------------------------------------------------------- >>> >>> 'make check-tcg' fails (x86-64 host): >>> >>> make: Entering directory >>> '/home/petmay01/linaro/qemu-for-merges/build/all-linux-static' >>> BUILD debian10 >>> The command '/bin/sh -c DEBIAN_FRONTEND=noninteractive eatmydata >>> apt install -y --no-install-recommends bison >>> build-essential ca-certificates clang flex >>> gettext git pkg-config psmisc >>> python python3-sphinx texinfo $(apt-get -s >>> build-dep qemu | egrep ^Inst | fgrep '[all]' | cut -d\ -f2)' returned >>> a non-zero code: 100 >>> Traceback (most recent call last): >>> File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", >>> line 615, in <module> >>> sys.exit(main()) >>> File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", >>> line 611, in main >>> return args.cmdobj.run(args, argv) >>> File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", >>> line 413, in run >>> extra_files_cksum=cksum) >>> File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", >>> line 280, in build_image >>> quiet=quiet) >>> File "/home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py", >>> line 207, in _do_check >>> return subprocess.check_call(self._command + cmd, **kwargs) >>> File "/usr/lib/python2.7/subprocess.py", line 190, in check_call >>> raise CalledProcessError(retcode, cmd) >>> subprocess.CalledProcessError: Command '['docker', 'build', '-t', >>> 'qemu:debian10', '-f', '/tmp/docker_buildBgZdCD/tmp6MJLiZ.docker', >>> '/tmp/docker_buildBgZdCD']' returned non-zero exit status 100 >>> /home/petmay01/linaro/qemu-for-merges/tests/docker/Makefile.include:53: >>> recipe for target 'docker-image-debian10' failed > > Yes, we should definitively improve this error report. > >>> make: *** [docker-image-debian10] Error 1 >>> make: Leaving directory >>> '/home/petmay01/linaro/qemu-for-merges/build/all-linux-static' >> >> Odd. Does: >> >> make docker-image-debian10 V=1 >> >> fail for you? Can you retry with: >> >> make docker-image-debian10 V=1 NOCACHE=1 > > Should we use a stable tag for the stable release? Such: > > -- >8 -- > diff --git a/tests/docker/dockerfiles/debian10.docker > b/tests/docker/dockerfiles/debian10.docker > index aeeb151b52..0f2800377d 100644 > --- a/tests/docker/dockerfiles/debian10.docker > +++ b/tests/docker/dockerfiles/debian10.docker > @@ -7,7 +7,7 @@ > # On its own you can't build much but the docker-foo-cross targets > # build on top of the base debian image. > # > -FROM debian:buster-slim > +FROM debian:buster-20190708-slim I don't think so - Buster is stable now - I think the problem is stale cache states from previous interrupted builds. If NOCACHE makes it go away then I think we are good. > > # Duplicate deb line as deb-src > --- > >>> >>> I also got a failure with openbsd which seems to be when >>> the tests run check-block.sh: >>> >>> /home/qemu/qemu-test.Dy1Aj3/src/tests/check-block.sh >>> TEST iotest-qcow2: 001 >>> TEST iotest-qcow2: 002 >>> TEST iotest-qcow2: 003 >>> TEST iotest-qcow2: 004 >>> TEST iotest-qcow2: 005 [not run] >>> TEST iotest-qcow2: 007 [fail] >>> QEMU -- >>> "/home/qemu/qemu-test.Dy1Aj3/build/tests/qemu-iotests/../../aarch64-softmmu/qemu-system-aarch64" >>> -nodefaults -machine virt,accel=qtest >>> QEMU_IMG -- >>> "/home/qemu/qemu-test.Dy1Aj3/build/tests/qemu-iotests/../../qemu-img" >>> QEMU_IO -- >>> "/home/qemu/qemu-test.Dy1Aj3/build/tests/qemu-iotests/../../qemu-io" >>> --cache writeback -f qcow2 >>> QEMU_NBD -- >>> "/home/qemu/qemu-test.Dy1Aj3/build/tests/qemu-iotests/../../qemu-nbd" >>> IMGFMT -- qcow2 (compat=1.1) >>> IMGPROTO -- file >>> PLATFORM -- OpenBSD/amd64 openbsd 6.5 >>> TEST_DIR -- /home/qemu/qemu-test.Dy1Aj3/build/tests/qemu-iotests/scratch >>> SOCKET_SCM_HELPER -- >>> >>> --- /home/qemu/qemu-test.Dy1Aj3/src/tests/qemu-iotests/007.out Tue >>> Jul 23 10:49:15 2019 >>> +++ /home/qemu/qemu-test.Dy1Aj3/build/tests/qemu-iotests/007.out.bad >>> Tue Jul 23 11:10:21 2019 >>> @@ -2,16 +2,7 @@ >>> >>> creating image >>> Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=1048576 >>> -savevm 1 >>> -savevm 2 >>> -savevm 3 >>> -savevm 4 >>> -savevm 5 >>> -savevm 6 >>> -savevm 7 >>> -savevm 8 >>> -savevm 9 >>> -savevm 10 >>> +./007: line 51: seq: command not found >>> >>> [and some other failures] >>> >>> I see Thomas Huth has a patch on-list for that, but this >>> didn't manifest as a problem before this pullreq. >> >> OK, I'll add it and rebuild the PR. > > But Thomas got another error later... > >> >> Have you noticed any issues with check-acceptance? >> >>> >>> thanks >>> -- PMM >> >> >> -- >> Alex Bennée >> -- Alex Bennée
Peter Maydell <peter.maydell@linaro.org> writes: > On Tue, 23 Jul 2019 at 13:16, Philippe Mathieu-Daudé <philmd@redhat.com> wrote: >> >> On 7/23/19 1:46 PM, Alex Bennée wrote: >> >> I see Thomas Huth has a patch on-list for that, but this >> >> didn't manifest as a problem before this pullreq. >> > >> > OK, I'll add it and rebuild the PR. >> >> But Thomas got another error later... > > If we're not sure what all the needed fixes are we > should probably just drop the change that starts > running the iotests under 'make check'. Otherwise this > pullreq is going to miss rc2, and it's too big to go into rc3. I'm just double checking now - it does seem OpenBSD is very slow even with 18 cores assigned. > > thanks > -- PMM -- Alex Bennée
On Tue, 23 Jul 2019 at 13:58, Alex Bennée <alex.bennee@linaro.org> wrote: > > > Peter Maydell <peter.maydell@linaro.org> writes: > > > On Tue, 23 Jul 2019 at 13:16, Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > >> > >> On 7/23/19 1:46 PM, Alex Bennée wrote: > >> >> I see Thomas Huth has a patch on-list for that, but this > >> >> didn't manifest as a problem before this pullreq. > >> > > >> > OK, I'll add it and rebuild the PR. > >> > >> But Thomas got another error later... > > > > If we're not sure what all the needed fixes are we > > should probably just drop the change that starts > > running the iotests under 'make check'. Otherwise this > > pullreq is going to miss rc2, and it's too big to go into rc3. > > I'm just double checking now - it does seem OpenBSD is very slow even > with 18 cores assigned. We should avoid enabling "very slow" tests in make check too... thanks -- PMM
On Tue, 23 Jul 2019 at 12:46, Alex Bennée <alex.bennee@linaro.org> wrote: > Odd. Does: > > make docker-image-debian10 V=1 > > fail for you? Yes. The files apt tries to download do not appear to be on the mirror: e104462:bionic:all-linux-static$ make docker-image-debian10 V=1 /home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py build qemu:debian10 /home/petmay01/linaro/qemu-for-merges/tests/docker/dockerfiles/debian10.docker --add-current-user Sending build context to Docker daemon 3.072kB Step 1/7 : FROM debian:buster-slim ---> 7e86f6dc8410 Step 2/7 : RUN cat /etc/apt/sources.list | sed "s/^deb\ /deb-src /" >> /etc/apt/sources.list ---> Using cache ---> a16e81a24df9 Step 3/7 : RUN apt update ---> Using cache ---> 272778d384a0 Step 4/7 : RUN DEBIAN_FRONTEND=noninteractive apt install -yy eatmydata ---> Using cache ---> 0113e60b5abe Step 5/7 : RUN DEBIAN_FRONTEND=noninteractive eatmydata apt install -y --no-install-recommends bison build-essential ca-certificates clang flex gettext git pkg-config psmisc python python3-sphinx texinfo $(apt-get -s build-dep qemu | egrep ^Inst | fgrep '[all]' | cut -d\ -f2) ---> Running in 9f66f5f38684 WARNING: apt does not have a stable CLI interface. Use with caution in scripts. [...] After this operation, 791 MB of additional disk space will be used. Err:1 http://cdn-fastly.deb.debian.org/debian buster/main amd64 perl-base amd64 5.28.1-4 404 Not Found [IP: 151.101.16.204 80] Err:2 http://cdn-fastly.deb.debian.org/debian buster/main amd64 libsystemd0 amd64 240-5 404 Not Found [IP: 151.101.16.204 80] Err:3 http://cdn-fastly.deb.debian.org/debian buster/main amd64 gcc-8-base amd64 8.2.0-16 404 Not Found [IP: 151.101.16.204 80] Err:4 http://cdn-fastly.deb.debian.org/debian buster/main amd64 libgcc1 amd64 1:8.2.0-16 404 Not Found [IP: 151.101.16.204 80] Err:5 http://cdn-fastly.deb.debian.org/debian buster/main amd64 libstdc++6 amd64 8.2.0-16 404 Not Found [IP: 151.101.16.204 80] Err:6 http://cdn-fastly.deb.debian.org/debian buster/main amd64 libc6 amd64 2.28-6 404 Not Found [IP: 151.101.16.204 80] though some are present, eg Get:210 http://cdn-fastly.deb.debian.org/debian buster/main amd64 libatk1.0-data all 2.30.0-2 [145 kB] > Can you retry with: > > make docker-image-debian10 V=1 NOCACHE=1 Yes, this works. It looks like docker is caching the result of the "apt update" state, when it really needs to rerun this every time because the state on the servers may have changed. thanks -- PMM
On 7/23/19 3:33 PM, Peter Maydell wrote: > On Tue, 23 Jul 2019 at 12:46, Alex Bennée <alex.bennee@linaro.org> wrote: >> Odd. Does: >> >> make docker-image-debian10 V=1 >> >> fail for you? > > Yes. The files apt tries to download do not appear to be > on the mirror: > e104462:bionic:all-linux-static$ make docker-image-debian10 V=1 > /home/petmay01/linaro/qemu-for-merges/tests/docker/docker.py build > qemu:debian10 /home/petmay01/linaro/qemu-for-merges/tests/docker/dockerfiles/debian10.docker > --add-current-user > Sending build context to Docker daemon 3.072kB > Step 1/7 : FROM debian:buster-slim > ---> 7e86f6dc8410 > Step 2/7 : RUN cat /etc/apt/sources.list | sed "s/^deb\ /deb-src /" >> > /etc/apt/sources.list > ---> Using cache > ---> a16e81a24df9 > Step 3/7 : RUN apt update > ---> Using cache > ---> 272778d384a0 > Step 4/7 : RUN DEBIAN_FRONTEND=noninteractive apt install -yy eatmydata > ---> Using cache > ---> 0113e60b5abe > Step 5/7 : RUN DEBIAN_FRONTEND=noninteractive eatmydata apt > install -y --no-install-recommends bison > build-essential ca-certificates clang flex > gettext git pkg-config psmisc > python python3-sphinx texinfo $(apt-get -s > build-dep qemu | egrep ^Inst | fgrep '[all]' | cut -d\ -f2) > ---> Running in 9f66f5f38684 > > WARNING: apt does not have a stable CLI interface. Use with caution in scripts. > [...] > After this operation, 791 MB of additional disk space will be used. > Err:1 http://cdn-fastly.deb.debian.org/debian buster/main amd64 > perl-base amd64 5.28.1-4 > 404 Not Found [IP: 151.101.16.204 80] > Err:2 http://cdn-fastly.deb.debian.org/debian buster/main amd64 > libsystemd0 amd64 240-5 > 404 Not Found [IP: 151.101.16.204 80] > Err:3 http://cdn-fastly.deb.debian.org/debian buster/main amd64 > gcc-8-base amd64 8.2.0-16 > 404 Not Found [IP: 151.101.16.204 80] > Err:4 http://cdn-fastly.deb.debian.org/debian buster/main amd64 > libgcc1 amd64 1:8.2.0-16 > 404 Not Found [IP: 151.101.16.204 80] > Err:5 http://cdn-fastly.deb.debian.org/debian buster/main amd64 > libstdc++6 amd64 8.2.0-16 > 404 Not Found [IP: 151.101.16.204 80] > Err:6 http://cdn-fastly.deb.debian.org/debian buster/main amd64 libc6 > amd64 2.28-6 > 404 Not Found [IP: 151.101.16.204 80] > > though some are present, eg > > Get:210 http://cdn-fastly.deb.debian.org/debian buster/main amd64 > libatk1.0-data all 2.30.0-2 [145 kB] > >> Can you retry with: >> >> make docker-image-debian10 V=1 NOCACHE=1 > > Yes, this works. It looks like docker is caching the > result of the "apt update" state, when it really needs > to rerun this every time because the state on the servers > may have changed. Yeah, I fixed Ubuntu here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=beac6a98f6eb271f2520a329ca051313afd70a69 But failed to explain this reason while trying to fix Debian: https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg02081.html
On 23/07/2019 15.01, Peter Maydell wrote: > On Tue, 23 Jul 2019 at 13:58, Alex Bennée <alex.bennee@linaro.org> wrote: >> >> >> Peter Maydell <peter.maydell@linaro.org> writes: >> >>> On Tue, 23 Jul 2019 at 13:16, Philippe Mathieu-Daudé <philmd@redhat.com> wrote: >>>> >>>> On 7/23/19 1:46 PM, Alex Bennée wrote: >>>>>> I see Thomas Huth has a patch on-list for that, but this >>>>>> didn't manifest as a problem before this pullreq. >>>>> >>>>> OK, I'll add it and rebuild the PR. >>>> >>>> But Thomas got another error later... >>> >>> If we're not sure what all the needed fixes are we >>> should probably just drop the change that starts >>> running the iotests under 'make check'. Otherwise this >>> pullreq is going to miss rc2, and it's too big to go into rc3. I think OpenBSD was the final thing that is not working. I've checked freebsd and macOS and they were working fine for me there. The netbsd image does not have "bash", so the tests are skipped there. >> I'm just double checking now - it does seem OpenBSD is very slow even >> with 18 cores assigned. > > We should avoid enabling "very slow" tests in make check too... It's not the iotests that are slow here, it's the whole openbsd image - even compiling is way slower than natively... it feels like it is ignoring the multiple cores and only running single-threaded. Thomas
The following changes since commit 23da9e297b4120ca9702cabec91599a44255fe96: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20190722' into staging (2019-07-22 15:16:48 +0100) are available in the Git repository at: https://github.com/stsquad/qemu.git tags/pull-testing-230719-1 for you to fetch changes up to 2e3b8743cd66f1d0fbc83051b0b6b072a97460cc: gitlab-ci: Remove qcow2 tests that are handled by "make check" already (2019-07-23 11:33:15 +0100) ---------------------------------------------------------------- Final testing updates: - docker sphinx updates - windows build re-enabled in CI - travis_retry for make check - quick iotests enabled for make check - build fixes ---------------------------------------------------------------- Alex Bennée (7): tests/docker: add test-misc for building tools & docs tests/migration-test: don't spam the logs when we fail tests/dockerfiles: update the win cross builds to stretch shippable: re-enable the windows cross builds hw/i386: also turn off VMMOUSE is VMPORT is disabled travis: enable travis_retry for check phase tests/docker: invoke the DEBUG shell with --noprofile/--norc Marc-André Lureau (1): archive-source: also create a stash for submodules Philippe Mathieu-Daudé (11): tests/docker: Install Sphinx in the Ubuntu images tests/docker: Install Sphinx in the Fedora image tests/docker: Install Ubuntu images noninteractively tests/docker: Install Sphinx in the Debian images tests/docker: Install the NSIS tools in the MinGW capable images tests/docker: Set the correct cross-PKG_CONFIG_PATH in the MXE images tests/docker: Install texinfo in the Fedora image buildsys: The NSIS Windows build requires the documentation installed buildsys: The NSIS Windows build requires qemu-nsis.bmp installed tests/docker: Let the test-mingw test generate a NSIS installer NSIS: Add missing firmware blobs Thomas Huth (4): tests/qemu-iotests/check: Allow tests without groups tests/qemu-iotests/group: Remove some more tests from the "auto" group tests: Run the iotests during "make check" again gitlab-ci: Remove qcow2 tests that are handled by "make check" already .gitlab-ci.yml | 13 +-- .shippable.yml | 9 +- .travis.yml | 2 +- Makefile | 3 +- hw/i386/Kconfig | 4 +- qemu.nsi | 11 ++ scripts/archive-source.sh | 18 ++-- tests/Makefile.include | 10 +- tests/check-block.sh | 44 ++++++-- tests/docker/Makefile.include | 6 +- tests/docker/dockerfiles/debian-win32-cross.docker | 10 +- tests/docker/dockerfiles/debian-win64-cross.docker | 10 +- tests/docker/dockerfiles/debian10.docker | 1 + .../{debian8-mxe.docker => debian9-mxe.docker} | 11 +- tests/docker/dockerfiles/debian9.docker | 1 + tests/docker/dockerfiles/fedora.docker | 4 + tests/docker/dockerfiles/ubuntu.docker | 3 +- tests/docker/dockerfiles/ubuntu1804.docker | 3 +- tests/docker/run | 4 +- tests/docker/test-mingw | 4 +- tests/docker/test-misc | 22 ++++ tests/migration-test.c | 19 ++-- tests/qemu-iotests-quick.sh | 8 -- tests/qemu-iotests/check | 4 +- tests/qemu-iotests/group | 120 +++++++++++---------- 25 files changed, 212 insertions(+), 132 deletions(-) rename tests/docker/dockerfiles/{debian8-mxe.docker => debian9-mxe.docker} (56%) create mode 100755 tests/docker/test-misc delete mode 100755 tests/qemu-iotests-quick.sh -- 2.20.1