| Message ID | 20190807135814.12906-1-naresh.kamboju@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2] selftests: kvm: Adding config fragments | expand |
Hi Naresh, On 8/7/19 7:58 AM, Naresh Kamboju wrote: > selftests kvm test cases need pre-required kernel configs for the test > to get pass. > Can you elaborate and add more information on which tests fail without these configs. I am all for adding configs, however I would like to see more information explaining which tests don't pass without this change. > Signed-off-by: Naresh Kamboju <naresh.kamboju@linaro.org> > --- > tools/testing/selftests/kvm/config | 3 +++ > 1 file changed, 3 insertions(+) > create mode 100644 tools/testing/selftests/kvm/config > > diff --git a/tools/testing/selftests/kvm/config b/tools/testing/selftests/kvm/config > new file mode 100644 > index 000000000000..63ed533f73d6 > --- /dev/null > +++ b/tools/testing/selftests/kvm/config > @@ -0,0 +1,3 @@ > +CONFIG_KVM=y > +CONFIG_KVM_INTEL=y > +CONFIG_KVM_AMD=y > That being said, it is up to Paolo to decide a call on this patch. thanks, -- Shuah
On 07/08/19 17:52, shuah wrote: > > > On 8/7/19 7:58 AM, Naresh Kamboju wrote: >> selftests kvm test cases need pre-required kernel configs for the test >> to get pass. >> > > Can you elaborate and add more information on which tests fail without > these configs. I am all for adding configs, however I would like to > see more information explaining which tests don't pass without this > change. The KVM tests are skipped without these configs: dev_fd = open(KVM_DEV_PATH, O_RDONLY); if (dev_fd < 0) exit(KSFT_SKIP); Paolo
On 8/7/19 10:19 AM, Paolo Bonzini wrote: > On 07/08/19 17:52, shuah wrote: >> >> >> On 8/7/19 7:58 AM, Naresh Kamboju wrote: >>> selftests kvm test cases need pre-required kernel configs for the test >>> to get pass. >>> >> >> Can you elaborate and add more information on which tests fail without >> these configs. I am all for adding configs, however I would like to >> see more information explaining which tests don't pass without this >> change. > > The KVM tests are skipped without these configs: > > dev_fd = open(KVM_DEV_PATH, O_RDONLY); > if (dev_fd < 0) > exit(KSFT_SKIP); > Thanks Paolo! This would be great info. to add to the commit log. thanks, -- Shuah
diff --git a/tools/testing/selftests/kvm/config b/tools/testing/selftests/kvm/config new file mode 100644 index 000000000000..63ed533f73d6 --- /dev/null +++ b/tools/testing/selftests/kvm/config @@ -0,0 +1,3 @@ +CONFIG_KVM=y +CONFIG_KVM_INTEL=y +CONFIG_KVM_AMD=y
selftests kvm test cases need pre-required kernel configs for the test to get pass. Signed-off-by: Naresh Kamboju <naresh.kamboju@linaro.org> --- tools/testing/selftests/kvm/config | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 tools/testing/selftests/kvm/config -- 2.17.1