mbox series

[v1,0/9] testing/next (docker,podman,float)

Message ID 20190917184109.12564-1-alex.bennee@linaro.org
Headers show
Series testing/next (docker,podman,float) | expand

Message

Alex Bennée Sept. 17, 2019, 6:41 p.m. UTC 
Hi,

This is the current status of the testing/next queue. It contains a
number of fixes for docker and podman as well as some additional tests
for floating point under TCG I've been experimenting with.

Although we have reasonable confidence in large chunks of the core
softfloat code thanks to check-softfloat there is a wide range of
guest specific behaviour. I've written a couple of tests while trying
to generalise test cases for some PPC bugs and have tried to make them
multiarch so they can run on all targets. To be fully effective a
reference trace needs to be added for each target it exercises.

I was a little worried about the impact of adding reference files
after the test-i386-fprem debacle (which was around 64M). However the
new references files are ~32-80k per test per target which is fairly
favourable considering tests/qemu-iotests contains around 10Mb of text
files. Git should do a fairly good job at compressing the common stuff
anyway.

If other architecture maintainers want to run the tests on known good
hardware we can add them to the appropriate places in tests/tcg.

Alex Bennée (7):
  tests/docker: fix DOCKER_PARTIAL_IMAGES
  target/ppc: fix signal delivery for ppc64abi32
  tests/tcg: clean-up some comments after the de-tangling
  tests/tcg: re-enable linux-test for ppc64abi32
  tests/tcg: add float_madds test to multiarch
  tests/tcg: add generic version of float_convs
  tests/tcg: add refs for PPC float_[convs|madds] tests (FAILS TESTS)

John Snow (2):
  tests/docker: add sanitizers back to clang build
  podman: fix command invocation

 linux-user/ppc/signal.c              |   4 +-
 tests/docker/Makefile.include        |   2 +-
 tests/docker/docker.py               |   2 +-
 tests/docker/test-clang              |   6 +-
 tests/tcg/Makefile.target            |  16 +-
 tests/tcg/aarch64/Makefile.target    |   3 +-
 tests/tcg/aarch64/float_convs.ref    | 748 ++++++++++++++++++++++
 tests/tcg/aarch64/float_madds.ref    | 892 +++++++++++++++++++++++++++
 tests/tcg/arm/Makefile.target        |  16 +-
 tests/tcg/arm/float_convs.ref        | 748 ++++++++++++++++++++++
 tests/tcg/arm/float_madds.ref        | 892 +++++++++++++++++++++++++++
 tests/tcg/configure.sh               |   1 +
 tests/tcg/multiarch/Makefile.target  |  23 +-
 tests/tcg/multiarch/float_convs.c    | 102 +++
 tests/tcg/multiarch/float_helpers.c  | 275 +++++++++
 tests/tcg/multiarch/float_helpers.h  |  31 +
 tests/tcg/multiarch/float_madds.c    | 104 ++++
 tests/tcg/ppc/float_convs.ref        | 748 ++++++++++++++++++++++
 tests/tcg/ppc/float_madds.ref        | 892 +++++++++++++++++++++++++++
 tests/tcg/ppc64/float_convs.ref      | 748 ++++++++++++++++++++++
 tests/tcg/ppc64/float_madds.ref      | 892 +++++++++++++++++++++++++++
 tests/tcg/ppc64abi32/float_convs.ref | 748 ++++++++++++++++++++++
 tests/tcg/ppc64abi32/float_madds.ref | 892 +++++++++++++++++++++++++++
 23 files changed, 8759 insertions(+), 26 deletions(-)
 create mode 100755 tests/tcg/aarch64/float_convs.ref
 create mode 100644 tests/tcg/aarch64/float_madds.ref
 create mode 100644 tests/tcg/arm/float_convs.ref
 create mode 100644 tests/tcg/arm/float_madds.ref
 create mode 100644 tests/tcg/multiarch/float_convs.c
 create mode 100644 tests/tcg/multiarch/float_helpers.c
 create mode 100644 tests/tcg/multiarch/float_helpers.h
 create mode 100644 tests/tcg/multiarch/float_madds.c
 create mode 100644 tests/tcg/ppc/float_convs.ref
 create mode 100644 tests/tcg/ppc/float_madds.ref
 create mode 100644 tests/tcg/ppc64/float_convs.ref
 create mode 100644 tests/tcg/ppc64/float_madds.ref
 create mode 100644 tests/tcg/ppc64abi32/float_convs.ref
 create mode 100644 tests/tcg/ppc64abi32/float_madds.ref

-- 
2.20.1

Comments

no-reply@patchew.org Sept. 18, 2019, 8:02 a.m. UTC | #1 
Patchew URL: https://patchew.org/QEMU/20190917184109.12564-1-alex.bennee@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH  v1 0/9] testing/next (docker,podman,float)
Message-id: 20190917184109.12564-1-alex.bennee@linaro.org
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20190917184109.12564-1-alex.bennee@linaro.org -> patchew/20190917184109.12564-1-alex.bennee@linaro.org
Switched to a new branch 'test'
484a149 tests/tcg: add refs for PPC float_[convs|madds] tests (FAILS TESTS)
5f79356 tests/tcg: add generic version of float_convs
c4eebe8 tests/tcg: add float_madds test to multiarch
a21855f tests/tcg: re-enable linux-test for ppc64abi32
ec04d62 tests/tcg: clean-up some comments after the de-tangling
6040174 target/ppc: fix signal delivery for ppc64abi32
e554591 podman: fix command invocation
de8a1e1 tests/docker: fix DOCKER_PARTIAL_IMAGES
4b02888 tests/docker: add sanitizers back to clang build

=== OUTPUT BEGIN ===
1/9 Checking commit 4b028882bb30 (tests/docker: add sanitizers back to clang build)
2/9 Checking commit de8a1e184fc1 (tests/docker: fix DOCKER_PARTIAL_IMAGES)
3/9 Checking commit e554591a7f1e (podman: fix command invocation)
4/9 Checking commit 60401740b757 (target/ppc: fix signal delivery for ppc64abi32)
5/9 Checking commit ec04d62eca41 (tests/tcg: clean-up some comments after the de-tangling)
6/9 Checking commit a21855f21eae (tests/tcg: re-enable linux-test for ppc64abi32)
7/9 Checking commit c4eebe811e75 (tests/tcg: add float_madds test to multiarch)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#41: 
new file mode 100644

ERROR: do not initialise statics to 0 or NULL
#1942: FILE: tests/tcg/multiarch/float_helpers.c:59:
+static int num_extra_f16 = 0;

ERROR: do not initialise statics to 0 or NULL
#1943: FILE: tests/tcg/multiarch/float_helpers.c:60:
+static int alloc_f16 = 0;

ERROR: open brace '{' following function declarations go on the next line
#1946: FILE: tests/tcg/multiarch/float_helpers.c:63:
+int get_num_f16(void) {

ERROR: open brace '{' following function declarations go on the next line
#1950: FILE: tests/tcg/multiarch/float_helpers.c:67:
+void add_f16_const(uint16_t new) {

ERROR: open brace '{' following function declarations go on the next line
#1958: FILE: tests/tcg/multiarch/float_helpers.c:75:
+uint16_t get_f16(int i) {

ERROR: open brace '{' following function declarations go on the next line
#1968: FILE: tests/tcg/multiarch/float_helpers.c:85:
+char *fmt_16(uint16_t num) {

WARNING: architecture specific defines should be avoided
#1980: FILE: tests/tcg/multiarch/float_helpers.c:97:
+# if __GNUC_PREREQ(3, 3)

ERROR: space prohibited between function name and open parenthesis '('
#1981: FILE: tests/tcg/multiarch/float_helpers.c:98:
+#  define SNANF (__builtin_nansf (""))

ERROR: space prohibited between function name and open parenthesis '('
#1982: FILE: tests/tcg/multiarch/float_helpers.c:99:
+#  define SNAN (__builtin_nans (""))

ERROR: space prohibited between function name and open parenthesis '('
#1983: FILE: tests/tcg/multiarch/float_helpers.c:100:
+#  define SNANL (__builtin_nansl (""))

ERROR: spaces required around that '+' (ctx:VxV)
#1992: FILE: tests/tcg/multiarch/float_helpers.c:109:
+    -0x1.1874b2p+103,
                 ^

ERROR: spaces required around that '+' (ctx:VxV)
#1993: FILE: tests/tcg/multiarch/float_helpers.c:110:
+    -0x1.c0bab6p+99,
                 ^

ERROR: spaces required around that '-' (ctx:VxV)
#1994: FILE: tests/tcg/multiarch/float_helpers.c:111:
+    -0x1.31f75p-40,
                ^

ERROR: spaces required around that '-' (ctx:VxV)
#1995: FILE: tests/tcg/multiarch/float_helpers.c:112:
+    -0x1.505444p-66,
                 ^

ERROR: spaces required around that '-' (ctx:VxV)
#1999: FILE: tests/tcg/multiarch/float_helpers.c:116:
+    0x1p-25,
         ^

ERROR: spaces required around that '-' (ctx:VxV)
#2000: FILE: tests/tcg/multiarch/float_helpers.c:117:
+    0x1.ffffe6p-25, /* min positive FP16 subnormal */
                ^

ERROR: spaces required around that '-' (ctx:VxV)
#2001: FILE: tests/tcg/multiarch/float_helpers.c:118:
+    0x1.ff801ap-15, /* max subnormal FP16 */
                ^

ERROR: spaces required around that '-' (ctx:VxV)
#2002: FILE: tests/tcg/multiarch/float_helpers.c:119:
+    0x1.00000cp-14, /* min positive normal FP16 */
                ^

ERROR: spaces required around that '+' (ctx:VxV)
#2004: FILE: tests/tcg/multiarch/float_helpers.c:121:
+    0x1.004p+0, /* smallest float after 1.0 FP16 */
             ^

ERROR: spaces required around that '+' (ctx:VxV)
#2007: FILE: tests/tcg/multiarch/float_helpers.c:124:
+    0x1.ffbep+15,
              ^

ERROR: spaces required around that '+' (ctx:VxV)
#2008: FILE: tests/tcg/multiarch/float_helpers.c:125:
+    0x1.ffcp+15, /* max FP16 */
             ^

ERROR: spaces required around that '+' (ctx:VxV)
#2009: FILE: tests/tcg/multiarch/float_helpers.c:126:
+    0x1.ffc2p+15,
              ^

ERROR: spaces required around that '+' (ctx:VxV)
#2010: FILE: tests/tcg/multiarch/float_helpers.c:127:
+    0x1.ffbfp+16,
              ^

ERROR: spaces required around that '+' (ctx:VxV)
#2011: FILE: tests/tcg/multiarch/float_helpers.c:128:
+    0x1.ffcp+16, /* max AFP */
             ^

ERROR: spaces required around that '+' (ctx:VxV)
#2012: FILE: tests/tcg/multiarch/float_helpers.c:129:
+    0x1.ffc1p+16,
              ^

ERROR: spaces required around that '+' (ctx:VxV)
#2013: FILE: tests/tcg/multiarch/float_helpers.c:130:
+    0x1.c0bab6p+99,
                ^

ERROR: do not initialise statics to 0 or NULL
#2023: FILE: tests/tcg/multiarch/float_helpers.c:140:
+static int num_extra_f32 = 0;

ERROR: do not initialise statics to 0 or NULL
#2024: FILE: tests/tcg/multiarch/float_helpers.c:141:
+static int alloc_f32 = 0;

ERROR: open brace '{' following function declarations go on the next line
#2027: FILE: tests/tcg/multiarch/float_helpers.c:144:
+int get_num_f32(void) {

ERROR: open brace '{' following function declarations go on the next line
#2031: FILE: tests/tcg/multiarch/float_helpers.c:148:
+void add_f32_const(float new) {

ERROR: spaces required around that '*' (ctx:WxV)
#2033: FILE: tests/tcg/multiarch/float_helpers.c:150:
+        alloc_f32 = (alloc_f32 == 0 ? 2 : alloc_f32 *2);
                                                     ^

ERROR: open brace '{' following function declarations go on the next line
#2039: FILE: tests/tcg/multiarch/float_helpers.c:156:
+float get_f32(int i) {

ERROR: open brace '{' following function declarations go on the next line
#2048: FILE: tests/tcg/multiarch/float_helpers.c:165:
+char *fmt_f32(float num) {

ERROR: spaces required around that '-' (ctx:VxV)
#2067: FILE: tests/tcg/multiarch/float_helpers.c:184:
+    {-FLT_MAX-1.0},
              ^

ERROR: spaces required around that '+' (ctx:VxV)
#2069: FILE: tests/tcg/multiarch/float_helpers.c:186:
+    {-1.111E+31},
             ^

ERROR: spaces required around that '+' (ctx:VxV)
#2070: FILE: tests/tcg/multiarch/float_helpers.c:187:
+    {-1.111E+30}, /* half prec */
             ^

ERROR: spaces required around that '-' (ctx:VxV)
#2076: FILE: tests/tcg/multiarch/float_helpers.c:193:
+    {2.98023224e-08},
                 ^

ERROR: spaces required around that '-' (ctx:VxV)
#2077: FILE: tests/tcg/multiarch/float_helpers.c:194:
+    {5.96046E-8}, /* min positive FP16 subnormal */
              ^

ERROR: spaces required around that '-' (ctx:VxV)
#2078: FILE: tests/tcg/multiarch/float_helpers.c:195:
+    {6.09756E-5}, /* max subnormal FP16 */
              ^

ERROR: spaces required around that '-' (ctx:VxV)
#2079: FILE: tests/tcg/multiarch/float_helpers.c:196:
+    {6.10352E-5}, /* min positive normal FP16 */
              ^

ERROR: spaces required around that '-' (ctx:VxV)
#2083: FILE: tests/tcg/multiarch/float_helpers.c:200:
+    {1.3789972848607228e-308},
                         ^

ERROR: spaces required around that '-' (ctx:VxV)
#2084: FILE: tests/tcg/multiarch/float_helpers.c:201:
+    {1.4914738736681624e-308},
                         ^

ERROR: do not initialise statics to 0 or NULL
#2106: FILE: tests/tcg/multiarch/float_helpers.c:223:
+static int num_extra_f64 = 0;

ERROR: do not initialise statics to 0 or NULL
#2107: FILE: tests/tcg/multiarch/float_helpers.c:224:
+static int alloc_f64 = 0;

ERROR: open brace '{' following function declarations go on the next line
#2110: FILE: tests/tcg/multiarch/float_helpers.c:227:
+int get_num_f64(void) {

ERROR: open brace '{' following function declarations go on the next line
#2114: FILE: tests/tcg/multiarch/float_helpers.c:231:
+void add_f64_const(double new) {

ERROR: open brace '{' following function declarations go on the next line
#2122: FILE: tests/tcg/multiarch/float_helpers.c:239:
+double get_f64(int i) {

ERROR: open brace '{' following function declarations go on the next line
#2131: FILE: tests/tcg/multiarch/float_helpers.c:248:
+char *fmt_f64(double num) {

ERROR: "foo * bar" should be "foo *bar"
#2191: FILE: tests/tcg/multiarch/float_helpers.h:27:
+char * fmt_f16(uint16_t);

ERROR: "foo * bar" should be "foo *bar"
#2192: FILE: tests/tcg/multiarch/float_helpers.h:28:
+char * fmt_f32(float);

ERROR: "foo * bar" should be "foo *bar"
#2193: FILE: tests/tcg/multiarch/float_helpers.h:29:
+char * fmt_f64(double);

ERROR: "foo * bar" should be "foo *bar"
#2195: FILE: tests/tcg/multiarch/float_helpers.h:31:
+char * fmt_flags(void);

ERROR: spaces required around that '-' (ctx:VxV)
#2271: FILE: tests/tcg/multiarch/float_madds.c:70:
+    add_f32_const(0x1.ffffffffffffcp-1022);
                                     ^

ERROR: spaces required around that '-' (ctx:VxV)
#2272: FILE: tests/tcg/multiarch/float_madds.c:71:
+    add_f32_const(0x1.0000000000001p-1);
                                     ^

ERROR: spaces required around that '-' (ctx:VxV)
#2273: FILE: tests/tcg/multiarch/float_madds.c:72:
+    add_f32_const(0x0.0000000000001p-1022);
                                     ^

ERROR: spaces required around that '-' (ctx:VxV)
#2274: FILE: tests/tcg/multiarch/float_madds.c:73:
+    add_f32_const(0x8p-152);
                       ^

ERROR: spaces required around that '-' (ctx:VxV)
#2275: FILE: tests/tcg/multiarch/float_madds.c:74:
+    add_f32_const(0x8p-152);
                       ^

ERROR: spaces required around that '-' (ctx:VxV)
#2276: FILE: tests/tcg/multiarch/float_madds.c:75:
+    add_f32_const(0x8p-152);
                       ^

ERROR: spaces required around that '%' (ctx:VxV)
#2285: FILE: tests/tcg/multiarch/float_madds.c:84:
+                a = get_f32(j + ((k)%3));
                                     ^

ERROR: spaces required around that '+' (ctx:VxV)
#2286: FILE: tests/tcg/multiarch/float_madds.c:85:
+                b = get_f32(j + ((k+1)%3));
                                    ^

ERROR: spaces required around that '%' (ctx:VxV)
#2286: FILE: tests/tcg/multiarch/float_madds.c:85:
+                b = get_f32(j + ((k+1)%3));
                                       ^

ERROR: spaces required around that '+' (ctx:VxV)
#2287: FILE: tests/tcg/multiarch/float_madds.c:86:
+                c = get_f32(j + ((k+2)%3));
                                    ^

ERROR: spaces required around that '%' (ctx:VxV)
#2287: FILE: tests/tcg/multiarch/float_madds.c:86:
+                c = get_f32(j + ((k+2)%3));
                                       ^

WARNING: architecture specific defines should be avoided
#2293: FILE: tests/tcg/multiarch/float_madds.c:92:
+#if defined(__arm__)

total: 62 errors, 3 warnings, 2241 lines checked

Patch 7/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

8/9 Checking commit 5f79356da3e0 (tests/tcg: add generic version of float_convs)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#16: 
new file mode 100755

ERROR: space prohibited after that open parenthesis '('
#1622: FILE: tests/tcg/multiarch/float_convs.c:75:
+CONVERT_SINGLE_TO_INT( int32, PRId32)

ERROR: space prohibited after that open parenthesis '('
#1624: FILE: tests/tcg/multiarch/float_convs.c:77:
+CONVERT_SINGLE_TO_INT( int64, PRId64)

total: 2 errors, 1 warnings, 1612 lines checked

Patch 8/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

9/9 Checking commit 484a1497b19d (tests/tcg: add refs for PPC float_[convs|madds] tests (FAILS TESTS))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17: 
new file mode 100644

total: 0 errors, 1 warnings, 4920 lines checked

Patch 9/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190917184109.12564-1-alex.bennee@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com